starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[Terminal]: 'Duplicate' button should remain in disabled state until user don't select a profile radio control. #16291

New Issue
Closed
opened 2026-01-31 05:02:57 +00:00 by claunia · 6 comments
claunia commented 2026-01-31 05:02:57 +00:00
Owner
Copy Link

Originally created by @ghost on GitHub (Dec 28, 2021).

Windows Terminal version

1.12.3472.0

Windows build number

10.0.22504.1010

Other Software

Test Environment:
OS: Windows 11 Version Dev (OS Build 22504.1010)
App: Windows Terminal Preview
Screen Reader: Narrator

Steps to reproduce

Repro Steps:

  1. Open Windows Terminal.
  2. Open Settings page using 'Ctr+,'.
  3. Activate 'Add a new profile' tab and then navigate 'Duplicate' button.
  4. Observe the issue.

User Experience:
Users UX will not be good especially Screen Reader as nothing will happen when they activate 'Duplicate' button.

Attachments:
'Duplicate' button should remain in disabled state until user don't select a profile radio control..zip

Expected Behavior

'Duplicate' button should remain in disabled state until user don't select a profile radio control.

Actual Behavior

'Duplicate' button is in enabled state even when user don't select a profile radio control.

Note Issue: 'Save' and 'Discard' button should remain in disabled state until we don't make any changes.

Originally created by @ghost on GitHub (Dec 28, 2021). ### Windows Terminal version 1.12.3472.0 ### Windows build number 10.0.22504.1010 ### Other Software **Test Environment:** OS: Windows 11 Version Dev (OS Build 22504.1010) App: Windows Terminal Preview Screen Reader: Narrator ### Steps to reproduce **Repro Steps:** 1. Open Windows Terminal. 2. Open Settings page using 'Ctr+,'. 3. Activate 'Add a new profile' tab and then navigate 'Duplicate' button. 4. Observe the issue. **User Experience:** Users UX will not be good especially Screen Reader as nothing will happen when they activate 'Duplicate' button. **Attachments:** ['Duplicate' button should remain in disabled state until user don't select a profile radio control..zip](https://github.com/microsoft/terminal/files/7783152/Duplicate.button.should.remain.in.disabled.state.until.user.don.t.select.a.profile.radio.control.zip) ### Expected Behavior 'Duplicate' button should remain in disabled state until user don't select a profile radio control. ### Actual Behavior 'Duplicate' button is in enabled state even when user don't select a profile radio control. **Note Issue:** 'Save' and 'Discard' button should remain in disabled state until we don't make any changes.
claunia commented 2026-01-31 05:03:00 +00:00
Author
Owner
Copy Link

@rinkydevi commented on GitHub (Feb 5, 2022):

hey @v-rpundir ! I would to contribute in this issue, how can i proceed ?

@rinkydevi commented on GitHub (Feb 5, 2022): hey @v-rpundir ! I would to contribute in this issue, how can i proceed ?
claunia commented 2026-01-31 05:03:00 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Feb 6, 2022):

@rinkydevi Sorry for the confusion here. This was actually already fixed in #12096 (and then we entirely changed this UI again in #12326 such that this was no longer an issue). There's just a bit of a delay between when a11y bugs are fixed and when we can close them out. I'll yank off the help wanted/easy starter tags, since that's confusing.

@v-rpundir can we confirm that this one is no longer an issue?

@zadjii-msft commented on GitHub (Feb 6, 2022): @rinkydevi Sorry for the confusion here. This was actually already fixed in #12096 (and then we entirely changed this UI again in #12326 such that this was no longer an issue). There's just a bit of a delay between when a11y bugs are fixed and when we can close them out. I'll yank off the help wanted/easy starter tags, since that's confusing. @v-rpundir can we confirm that this one is no longer an issue?
claunia commented 2026-01-31 05:03:01 +00:00
Author
Owner
Copy Link

@rinkydevi commented on GitHub (Feb 6, 2022):

@zadjii-msft thank u for your response sir!

@rinkydevi commented on GitHub (Feb 6, 2022): @zadjii-msft thank u for your response sir!
claunia commented 2026-01-31 05:03:01 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Feb 7, 2022):

@zadjii-msft Main issue is fixed but Note issue still repro.

Note Issue: 'Save' and 'Discard' button should remain in disabled state until we don't make any changes.

@ghost commented on GitHub (Feb 7, 2022): @zadjii-msft Main issue is fixed but Note issue still repro. **Note Issue:** 'Save' and 'Discard' button should remain in disabled state until we don't make any changes.
claunia commented 2026-01-31 05:03:01 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Feb 7, 2022):

@v-rpundir Ah okay. Missed that bit. That's actually quite a bit more complicated than disabling this one button till the user makes a selection. The Terminal doesn't have a good way to check when the user has actually made any changes via the UI. Also, the button will technically write out their settings to the file if they hit save even without changes. (I could have sworn there was a specific issue tracking this laying around but all I could find was a single bulletpoint in the https://github.com/microsoft/terminal/issues/6800 megathread).

For tracking purposes, what do you think the best strategy is here?

  • file a new issue for a11y tracking of the save/discard bug?
  • wholly repurpose this thread to track that bug?

I'd rather not have two separate issues tracked in the same thread, so I just want to clarify a bit. Thanks!

@zadjii-msft commented on GitHub (Feb 7, 2022): @v-rpundir Ah okay. Missed that bit. That's actually quite a bit more complicated than disabling this one button till the user makes a selection. The Terminal doesn't have a good way to check when the user has actually made any changes via the UI. Also, the button will technically write out their settings to the file if they hit save even without changes. (I could have sworn there was a specific issue tracking this laying around but all I could find was a single bulletpoint in the https://github.com/microsoft/terminal/issues/6800 megathread). For tracking purposes, what do you think the best strategy is here? * file a new issue for a11y tracking of the save/discard bug? * wholly repurpose this thread to track that bug? I'd rather not have two separate issues tracked in the same thread, so I just want to clarify a bit. Thanks!
claunia commented 2026-01-31 05:03:02 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Feb 8, 2022):

@zadjii-msft Closing this bug as Main issue is fixed and logged new separate issue for Note https://github.com/microsoft/terminal/issues/12424

@ghost commented on GitHub (Feb 8, 2022): @zadjii-msft Closing this bug as Main issue is fixed and logged new separate issue for Note https://github.com/microsoft/terminal/issues/12424
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label A11yCO A11yTTValidated A11yUsable Area-Accessibility HCL-E+D HCL-WindowsTerminal Issue-Bug Priority-3 Product-Terminal Resolution-Fix-Committed WindowsTerminal_Win32
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#16291
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?