starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[VT Render] Investigate not breaking lines for node-pty #1630

New Issue
Closed
opened 2026-01-30 22:32:29 +00:00 by claunia · 2 comments
claunia commented 2026-01-30 22:32:29 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Jun 12, 2019).

From MSFT:19012792

I didn't have any details in here. I presume that this was to track trying to not render a \r\n at the end of a line, so that a terminal would wrap the line itself. IIRC I tried that in RS5, but it broke something else, and there wasn't time to get it working for that release, so we reverted it.

Originally created by @zadjii-msft on GitHub (Jun 12, 2019). From MSFT:19012792 ----------- I didn't have any details in here. I presume that this was to track trying to not render a `\r\n` at the end of a line, so that a terminal would wrap the line itself. IIRC I tried that in RS5, but it broke something else, and there wasn't time to get it working for that release, so we reverted it.
claunia added the Area-RenderingIssue-BugNeeds-Tag-FixProduct-ConptyPriority-2 labels 2026-01-30 22:32:30 +00:00
claunia commented 2026-01-30 22:32:30 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jul 3, 2019):

Related: https://github.com/microsoft/terminal/issues/405

@ghost commented on GitHub (Jul 3, 2019): Related: https://github.com/microsoft/terminal/issues/405
claunia commented 2026-01-30 22:32:30 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jan 4, 2022):

I've been up and down the internal PRs around this time, and I can't find where this originally came from. The original bug has no details in it other than "it was a revert of something in the RS5 timeframe". I recall making some change to wrapping and having to revert it, but I can't find it, or the original bug.

Chances are, we've already fixed this along the way. I'm closing this.

@zadjii-msft commented on GitHub (Jan 4, 2022): I've been up and down the internal PRs around this time, and I can't find where this originally came from. The original bug has no details in it other than "it was a revert of something in the RS5 timeframe". I recall making some change to wrapping and having to revert it, but I can't find it, or the original bug. Chances are, we've already fixed this along the way. I'm closing this.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Rendering Issue-Bug Needs-Tag-Fix Priority-2 Product-Conpty
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#1630
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?