After CTRL+Scroll to zoom in and out a ton, the text gets garbled #1634

Closed
opened 2026-01-30 22:32:33 +00:00 by claunia · 12 comments
Owner

Originally created by @zadjii-msft on GitHub (Jun 12, 2019).

From MSFT:21430356

After CTRL+Scroll to zoom in and out a ton, the text gets garbled

I scrolled with CTRL+Scroll to make it really small and really big and went back and forth. Then, I can scroll up and get garbled text that only extends a few characters but are truncated rather than wrapping.

Originally created by @zadjii-msft on GitHub (Jun 12, 2019). From MSFT:21430356 After CTRL+Scroll to zoom in and out a ton, the text gets garbled I scrolled with CTRL+Scroll to make it really small and really big and went back and forth. Then, I can scroll up and get garbled text that only extends a few characters but are truncated rather than wrapping.
Author
Owner

@dash-mode commented on GitHub (Jun 16, 2019):

Has anyone been working on this?
When I begin a new tab and then I change the size of the text using ctrl+scroll, I see some garbage text when I scroll up.

@dash-mode commented on GitHub (Jun 16, 2019): Has anyone been working on this? When I begin a new tab and then I change the size of the text using ctrl+scroll, I see some garbage text when I scroll up.
Author
Owner

@zadjii-msft commented on GitHub (Jun 18, 2019):

Nope, feel free to take a stab at it if you'd like. My guess is that we're not "reflowing" text that's outside of the viewport when we resize the buffer, we're merely truncating it to the new size of the buffer. There's almost certainly code in conhost's SCREEN_INFORMATION class that could help with this, though it'd have to be ported down a layer, to the TextBuffer class.

@zadjii-msft commented on GitHub (Jun 18, 2019): Nope, feel free to take a stab at it if you'd like. My guess is that we're not "reflowing" text that's outside of the viewport when we resize the buffer, we're merely truncating it to the new size of the buffer. There's almost certainly code in conhost's `SCREEN_INFORMATION` class that could help with this, though it'd have to be ported down a layer, to the `TextBuffer` class.
Author
Owner

@dash-mode commented on GitHub (Jun 19, 2019):

Alright, thanks for the suggestion. I will take a look at it.

@dash-mode commented on GitHub (Jun 19, 2019): Alright, thanks for the suggestion. I will take a look at it.
Author
Owner

@dash-mode commented on GitHub (Jun 23, 2019):

Annotation 2019-06-23 150611 window::verticalScroll is called in this function ^ Annotation 2019-06-23 151149 Here is the definition of window::verticalScroll.

I think this is where the issue might be. But I am a little stuck here. Can someone help me out here?

@dash-mode commented on GitHub (Jun 23, 2019): <img width="960" alt="Annotation 2019-06-23 150611" src="https://user-images.githubusercontent.com/32212134/59980793-96f2c080-95c8-11e9-8472-fc0d8c037a67.png"> window::verticalScroll is called in this function ^ <img width="960" alt="Annotation 2019-06-23 151149" src="https://user-images.githubusercontent.com/32212134/59980851-4f206900-95c9-11e9-8efb-be193fa3f74a.png"> Here is the definition of window::verticalScroll. I think this is where the issue might be. But I am a little stuck here. Can someone help me out here?
Author
Owner

@Shorotshishir commented on GitHub (Jun 23, 2019):

This is the max I could get to zoom and render. I have a 1080p display this is too much!
image

@Shorotshishir commented on GitHub (Jun 23, 2019): This is the max I could get to zoom and render. I have a 1080p display this is too much! ![image](https://user-images.githubusercontent.com/16465879/59981098-cf25ed80-9620-11e9-9342-7db2edf87905.png)
Author
Owner

@DHowett-MSFT commented on GitHub (Jun 24, 2019):

I’m sorry, are you complaining that you made your font too big and now your font is too big?

@DHowett-MSFT commented on GitHub (Jun 24, 2019): I’m sorry, are you complaining that you made your font too big and now your font is too big?
Author
Owner

@Shorotshishir commented on GitHub (Jun 24, 2019):

@DHowett I am not complaining about my font being too big :D but saying it is not stopping! I do believe it should have a max limit, where scrolling won't have any effect. I could see the cursor growing and growing.

@Shorotshishir commented on GitHub (Jun 24, 2019): @DHowett I am not complaining about my font being too big :D but saying it is not stopping! I do believe it should have a max limit, where scrolling won't have any effect. I could see the cursor growing and growing.
Author
Owner

@zadjii-msft commented on GitHub (Jul 2, 2019):

@dash-mode The function you're actually looking for is SCREEN_INFORMATION::ResizeWithReflow in screeninfo.cpp

@zadjii-msft commented on GitHub (Jul 2, 2019): @dash-mode The function you're actually looking for is `SCREEN_INFORMATION::ResizeWithReflow` in `screeninfo.cpp`
Author
Owner

@WSLUser commented on GitHub (Jul 2, 2019):

I do believe it should have a max limit, where scrolling won't have any effect. I could see the cursor growing and growing.

I agree though probably not for exactly the same reason. I could see a potential crash occurring either with the tab, the Terminal, or potentially Windows itself (though I find that highly unlikely) or a crash in the GPU that causes a reset. It raises an availability concern and potentially other security concerns. Setting a max limit would be best but I think if it can fit on the screen, it should be permitted. I would execute some query logic based on device type to determine the visual range available for the screen.

@WSLUser commented on GitHub (Jul 2, 2019): > I do believe it should have a max limit, where scrolling won't have any effect. I could see the cursor growing and growing. I agree though probably not for exactly the same reason. I could see a potential crash occurring either with the tab, the Terminal, or potentially Windows itself (though I find that highly unlikely) or a crash in the GPU that causes a reset. It raises an availability concern and potentially other security concerns. Setting a max limit would be best but I think if it can fit on the screen, it should be permitted. I would execute some query logic based on device type to determine the visual range available for the screen.
Author
Owner

@KoalaBear84 commented on GitHub (Dec 13, 2019):

Luckily I have found an issue representing my problems and then seeing it is already known for a half year. Aww.

Anyway, here is a visual I created to demonstrate. It is good to have anyway.

ezgif-5-88b15fa6f3d7

@KoalaBear84 commented on GitHub (Dec 13, 2019): Luckily I have found an issue representing my problems and then seeing it is already known for a half year. Aww. Anyway, here is a visual I created to demonstrate. It is good to have anyway. ![ezgif-5-88b15fa6f3d7](https://user-images.githubusercontent.com/5886900/70790190-db4f6400-1d94-11ea-850b-a56b2b5e0424.gif)
Author
Owner

@zadjii-msft commented on GitHub (Jan 22, 2020):

Wait a hot second, this is actually the same bug as /dup #1465 and more broadly, #4200

@zadjii-msft commented on GitHub (Jan 22, 2020): Wait a hot second, this is actually the same bug as /dup #1465 and more broadly, #4200
Author
Owner

@ghost commented on GitHub (Jan 22, 2020):

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost commented on GitHub (Jan 22, 2020): Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#1634