starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 00:15:10 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Theme changes don't work correctly after opening the About box #16343

New Issue
Open
opened 2026-01-31 05:04:45 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 05:04:45 +00:00
Owner
Copy Link

Originally created by @j4james on GitHub (Jan 5, 2022).

Windows Terminal version

1.12.3472.0

Windows build number

10.0.19041.1415

Other Software

No response

Steps to reproduce

  1. Start Windows Terminal (don't just use an existing session).
  2. Open the Settings UI, and go to the Appearance section.
  3. Set the Theme to Light, and click Save.
  4. Without closing the settings, open the About box, and close it again.
  5. Now switch the Theme to Dark, and click Save.

Expected Behavior

The UI colors should change to the dark theme.

Actual Behavior

Most of the UI remains using the light theme, but some elements appear to be updated in such a way that they become invisible.

image

This breaks in a similar way when switching from dark to light, and it's also not only the About box that triggers it - I think any popup dialog will do (e.g. the "Do you want to close all tabs?" warning has the same effect).

If you open the About box again, it temporarily "fixes" the problem (i.e. it refreshes the colors correctly), but that only last until you try and change the theme again.

Originally created by @j4james on GitHub (Jan 5, 2022). ### Windows Terminal version 1.12.3472.0 ### Windows build number 10.0.19041.1415 ### Other Software _No response_ ### Steps to reproduce 1. Start Windows Terminal (don't just use an existing session). 2. Open the Settings UI, and go to the _Appearance_ section. 3. Set the _Theme_ to _Light_, and click _Save_. 4. Without closing the settings, open the _About_ box, and close it again. 5. Now switch the _Theme_ to _Dark_, and click _Save_. ### Expected Behavior The UI colors should change to the dark theme. ### Actual Behavior Most of the UI remains using the light theme, but some elements appear to be updated in such a way that they become invisible. ![image](https://user-images.githubusercontent.com/4181424/148288163-7b90c170-ca0b-4d7a-bf30-5e7becd6f76b.png) This breaks in a similar way when switching from dark to light, and it's also not only the _About_ box that triggers it - I think any popup dialog will do (e.g. the "Do you want to close all tabs?" warning has the same effect). If you open the _About_ box again, it temporarily "fixes" the problem (i.e. it refreshes the colors correctly), but that only last until you try and change the theme again.
claunia added the Help WantedIssue-BugPriority-3Product-TerminalArea-SettingsUI labels 2026-01-31 05:04:45 +00:00
claunia commented 2026-01-31 05:04:46 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Jan 5, 2022):

Btw, if this is something that's fixed in Windows 11, feel free to close it. I only noticed while testing the PR I was going to submit for #1230, but if there are going to be a whole lot of these issues specific to Windows 10, I'm happy to just ditch that PR and accept that Windows 10 won't handle themes very well.

@j4james commented on GitHub (Jan 5, 2022): Btw, if this is something that's fixed in Windows 11, feel free to close it. I only noticed while testing the PR I was going to submit for #1230, but if there are going to be a whole lot of these issues specific to Windows 10, I'm happy to just ditch that PR and accept that Windows 10 won't handle themes very well.
claunia commented 2026-01-31 05:04:47 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jan 5, 2022):

holy butts that's bad, definitely not fixed in Windows 11. I suspect our hack for "walk up the UI tree and change the resources manually" doesn't totally work great with the SUI. The place to investigate this would be AppLogic::ShowDialog. This is also firmly in BODGY territory, and considering there is a workaround ("just reopen the about dialog"), then this isn't the biggest issue.

@zadjii-msft commented on GitHub (Jan 5, 2022): holy butts that's bad, definitely not fixed in Windows 11. I suspect our hack for "walk up the UI tree and change the resources manually" doesn't totally work great with the SUI. The place to investigate this would be `AppLogic::ShowDialog`. This is also firmly in BODGY territory, and considering there is a workaround ("just reopen the about dialog"), then this isn't the _biggest_ issue.
claunia commented 2026-01-31 05:04:47 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jan 5, 2022):

We may want to just run the themeingLambda whenever we reload the settings. IDK if that would work or not though.

@zadjii-msft commented on GitHub (Jan 5, 2022): We may want to just run the `themeingLambda` whenever we reload the settings. IDK if that would work or not though.
claunia commented 2026-01-31 05:04:47 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Jan 5, 2022):

Yeah, I was looking at the AppLogic::ShowDialog implementation, and I tried running something similar to the themeingLambda thing in the IslandWindow::OnApplicationThemeChanged handler, but I couldn't get it to work. I thought at the time that my attempted fix for #1230 was to blame, and it was becoming a lot more effort than I had anticipated for a "quick fix", so I gave up on it pretty quickly. If it's not going to be fixed in Windows 11, though, I may take another stab at it when I have more time.

@j4james commented on GitHub (Jan 5, 2022): Yeah, I was looking at the `AppLogic::ShowDialog` implementation, and I tried running something similar to the `themeingLambda` thing in the `IslandWindow::OnApplicationThemeChanged` handler, but I couldn't get it to work. I thought at the time that my attempted fix for #1230 was to blame, and it was becoming a lot more effort than I had anticipated for a "quick fix", so I gave up on it pretty quickly. If it's not going to be fixed in Windows 11, though, I may take another stab at it when I have more time.
claunia commented 2026-01-31 05:04:47 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Feb 6, 2023):

Heck, this still isn't fixed in 1.17, even after all the other changes to theming.

@zadjii-msft commented on GitHub (Feb 6, 2023): Heck, this still isn't fixed in 1.17, even after all the other changes to theming.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-SettingsUI Help Wanted Issue-Bug Priority-3 Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#16343
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?