starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

DECAWM escape sequence doesn't work correctly in non-active buffer #16433

New Issue
Open
opened 2026-01-31 05:10:50 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 05:10:50 +00:00
Owner
Copy Link

Originally created by @j4james on GitHub (Jan 18, 2022).

Windows Terminal version

1.12.3472.0

Windows build number

10.0.19041.1415

Other Software

No response

Steps to reproduce

Run the following C++ test case in Windows Terminal or conhost.

#include <windows.h>
#include <conio.h>
#include <string>

int main() {
  // Get the handle of the main buffer, and also create a second buffer.
  HANDLE buff1 = GetStdHandle(STD_OUTPUT_HANDLE);
  HANDLE buff2 = CreateConsoleScreenBuffer(GENERIC_READ|GENERIC_WRITE, 0, NULL, CONSOLE_TEXTMODE_BUFFER, NULL);

  // Enable VT processing.
  DWORD dwMode = 0;
  GetConsoleMode(buff1, &dwMode);
  dwMode |= ENABLE_VIRTUAL_TERMINAL_PROCESSING;
  SetConsoleMode(buff1, dwMode);

  DWORD written;
  std::wstring s;

  // Switch to the second buffer, but disable DECAWM in the main buffer.
  SetConsoleActiveScreenBuffer(buff2);
  s = L"\033[?7l";
  WriteConsoleW(buff1, s.data(), s.length(), &written, NULL);

  // Write some content starting at the end of the line in the second buffer.
  s = L"\033[2J\033[H\033[999C Second Buffer";
  WriteConsoleW(buff2, s.data(), s.length(), &written, NULL);
  getch();

  // Close the second buffer so the main buffer is active again.
  CloseHandle(buff2);

  // Write some content starting at the end of the line in the main buffer.
  s = L"\033[2J\033[H\033[999C Main Buffer";
  WriteConsoleW(buff1, s.data(), s.length(), &written, NULL);

  return 0;
}

Expected Behavior

The sample above opens two screen buffers, and while the second one is active, sends an DECAWM escape sequence (disabling auto-wrap) to the handle of the first buffer. It then writes some text at the end of the line in the second buffer, which should still wrap. After a keypress, it switches back to the main buffer, and again writes some text at the end of the line, which now shouldn't wrap.

Actual Behavior

The text written to the second buffer doesn't wrap, while the text written to the main buffer does wrap.

This is a similar in cause to issue #12193. The DoSrvPrivateSetAutoWrapMode function is updating the output mode in the active screen buffer, when it should be obtaining the target buffer from the handle that initiated the operation.

62c95b5017/src/host/getset.cpp (L1258-L1262)

Again I'm hoping this will be fixed by the conhost refactoring I'm working on.

Originally created by @j4james on GitHub (Jan 18, 2022). ### Windows Terminal version 1.12.3472.0 ### Windows build number 10.0.19041.1415 ### Other Software _No response_ ### Steps to reproduce Run the following C++ test case in Windows Terminal or conhost. ```cpp #include <windows.h> #include <conio.h> #include <string> int main() { // Get the handle of the main buffer, and also create a second buffer. HANDLE buff1 = GetStdHandle(STD_OUTPUT_HANDLE); HANDLE buff2 = CreateConsoleScreenBuffer(GENERIC_READ|GENERIC_WRITE, 0, NULL, CONSOLE_TEXTMODE_BUFFER, NULL); // Enable VT processing. DWORD dwMode = 0; GetConsoleMode(buff1, &dwMode); dwMode |= ENABLE_VIRTUAL_TERMINAL_PROCESSING; SetConsoleMode(buff1, dwMode); DWORD written; std::wstring s; // Switch to the second buffer, but disable DECAWM in the main buffer. SetConsoleActiveScreenBuffer(buff2); s = L"\033[?7l"; WriteConsoleW(buff1, s.data(), s.length(), &written, NULL); // Write some content starting at the end of the line in the second buffer. s = L"\033[2J\033[H\033[999C Second Buffer"; WriteConsoleW(buff2, s.data(), s.length(), &written, NULL); getch(); // Close the second buffer so the main buffer is active again. CloseHandle(buff2); // Write some content starting at the end of the line in the main buffer. s = L"\033[2J\033[H\033[999C Main Buffer"; WriteConsoleW(buff1, s.data(), s.length(), &written, NULL); return 0; } ``` ### Expected Behavior The sample above opens two screen buffers, and while the second one is active, sends an `DECAWM` escape sequence (disabling auto-wrap) to the handle of the first buffer. It then writes some text at the end of the line in the second buffer, which should still wrap. After a keypress, it switches back to the main buffer, and again writes some text at the end of the line, which now shouldn't wrap. ### Actual Behavior The text written to the second buffer doesn't wrap, while the text written to the main buffer does wrap. This is a similar in cause to issue #12193. The `DoSrvPrivateSetAutoWrapMode` function is updating the output mode in the active screen buffer, when it should be obtaining the target buffer from the handle that initiated the operation. https://github.com/microsoft/terminal/blob/62c95b5017e92a780cdc43008e30b4e43d2edc9b/src/host/getset.cpp#L1258-L1262 Again I'm hoping this will be fixed by the conhost refactoring I'm working on.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-VT Help Wanted Issue-Bug Priority-2 Product-Conhost Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#16433
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?