starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

When booting an elevated profile, UAC says that it's from an unknown publisher #16435

New Issue
Closed
opened 2026-01-31 05:11:11 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 05:11:11 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Jan 18, 2022).

Originally assigned to: @zadjii-msft on GitHub.

image

You know what OneNote, I'm leaving it like this, I know what it means.

Originally created by @zadjii-msft on GitHub (Jan 18, 2022). Originally assigned to: @zadjii-msft on GitHub. ![image](https://user-images.githubusercontent.com/18356694/150029679-56b13100-ee05-4a81-9619-b11e38a00678.png) You know what OneNote, I'm leaving it like this, I know what it means.
claunia commented 2026-01-31 05:11:27 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jan 20, 2022):

Hmmm. This might be tricky to test. It seems like right-clicking on the taskbar and using that to spawn the dev build of the Terminal also reports an Unknown Publisher, when the Preview build doesn't. That makes me think there's no way for me to test this locally...

FWIW I think you can fix this with

diff --git a/src/cascadia/ElevateShim/elevate-shim.cpp b/src/cascadia/ElevateShim/elevate-shim.cpp
index e9b4d859c..5e7adb903 100644
--- a/src/cascadia/ElevateShim/elevate-shim.cpp
+++ b/src/cascadia/ElevateShim/elevate-shim.cpp
@@ -11,6 +11,13 @@
 #include <wil/win32_helpers.h>
 #include <shellapi.h>

+#include <winrt/Windows.ApplicationModel.h>^M
+^M
+// This file does't need all of til, but it does need:^M
+#define _TIL_INLINEPREFIX __declspec(noinline) inline^M
+#include "til/string.h"^M
+#include "../WinRTUtils/inc/WtExeUtils.h"^M
+^M
 // BODGY
 //
 // If we try to do this in the Terminal itself, then there's a bunch of weird
@@ -30,10 +37,8 @@ int __stdcall wWinMain(HINSTANCE, HINSTANCE, LPWSTR pCmdLine, int)
     // All of the args passed to us (something like `new-tab -p {guid}`) are in
     // pCmdLine

-    // Get the path to WindowsTerminal.exe, which should live next to us.
-    std::filesystem::path module{ wil::GetModuleFileNameW<std::wstring>(nullptr) };
-    // Swap elevate-shim.exe for WindowsTerminal.exe
-    module.replace_filename(L"WindowsTerminal.exe");
+    // Use GetWtExePath which should find the right packaged version of wt.exe^M
+    std::filesystem::path module{ GetWtExePath() };^M

     // Go!

but I need to figure out how now. See 49f31554c

@zadjii-msft commented on GitHub (Jan 20, 2022): Hmmm. This might be tricky to test. It seems like right-clicking on the taskbar and using that to spawn the dev build of the Terminal also reports an Unknown Publisher, when the Preview build doesn't. That makes me think there's no way for me to test this locally... FWIW I think you can fix this with ```diff diff --git a/src/cascadia/ElevateShim/elevate-shim.cpp b/src/cascadia/ElevateShim/elevate-shim.cpp index e9b4d859c..5e7adb903 100644 --- a/src/cascadia/ElevateShim/elevate-shim.cpp +++ b/src/cascadia/ElevateShim/elevate-shim.cpp @@ -11,6 +11,13 @@ #include <wil/win32_helpers.h> #include <shellapi.h> +#include <winrt/Windows.ApplicationModel.h>^M +^M +// This file does't need all of til, but it does need:^M +#define _TIL_INLINEPREFIX __declspec(noinline) inline^M +#include "til/string.h"^M +#include "../WinRTUtils/inc/WtExeUtils.h"^M +^M // BODGY // // If we try to do this in the Terminal itself, then there's a bunch of weird @@ -30,10 +37,8 @@ int __stdcall wWinMain(HINSTANCE, HINSTANCE, LPWSTR pCmdLine, int) // All of the args passed to us (something like `new-tab -p {guid}`) are in // pCmdLine - // Get the path to WindowsTerminal.exe, which should live next to us. - std::filesystem::path module{ wil::GetModuleFileNameW<std::wstring>(nullptr) }; - // Swap elevate-shim.exe for WindowsTerminal.exe - module.replace_filename(L"WindowsTerminal.exe"); + // Use GetWtExePath which should find the right packaged version of wt.exe^M + std::filesystem::path module{ GetWtExePath() };^M // Go! ``` but I need to figure out how now. See 49f31554c
claunia commented 2026-01-31 05:11:28 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Apr 28, 2022):

I think this was fixed on the OS side, cause I can't repro this anymore.

@zadjii-msft commented on GitHub (Apr 28, 2022): I think this was fixed on the OS side, cause I can't repro this anymore.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Windowing Issue-Bug Priority-2 Product-Terminal Resolution-External
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#16435
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?