starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Rename TextAttribute::IsBold to TextAttribute::IsIntense #16502

New Issue
Closed
opened 2026-01-31 05:14:04 +00:00 by claunia · 4 comments
claunia commented 2026-01-31 05:14:04 +00:00
Owner
Copy Link

Originally created by @j4james on GitHub (Jan 25, 2022).

Description of the new feature/enhancement

When we added support for controlling the rendering of the SGR 1 attribute, we referred to it as "intense", so we have options like IntenseIsBold and IntenseIsBright. However, internally we refer to SGR 1 as "bold", with the TextAttribute methods SetBold and IsBold. This results in awkward expressions like this:

e3aa9ff7a8/src/renderer/dx/DxRenderer.cpp (L1965)

It's not a big deal, but I think the code would make a lot more sense as:

useBoldFont = textAttributes.IsIntense() && renderSettings.GetRenderMode(RenderSettings::Mode::IntenseIsBold);

Similarly, when handling the IntenseIsBright mode, instead of this:

f605adc994/src/renderer/base/RenderSettings.cpp (L183)

we'd have this:

brightenFg = attr.IsIntense() && GetRenderMode(Mode::IntenseIsBright);

Proposed technical implementation details (optional)

Rename the Bold option in the ExtendedAttributes enum to Intense, the SetBold and IsBold methods in the TextAttribute class to SetIntense and IsIntense. There will probably also be a few more variables and methods in other places that needed to be updated to match.

Originally created by @j4james on GitHub (Jan 25, 2022). # Description of the new feature/enhancement When we added support for controlling the rendering of the `SGR 1` attribute, we referred to it as "intense", so we have options like `IntenseIsBold` and `IntenseIsBright`. However, internally we refer to `SGR 1` as "bold", with the `TextAttribute` methods `SetBold` and `IsBold`. This results in awkward expressions like this: https://github.com/microsoft/terminal/blob/e3aa9ff7a84cdef801591913b002a8a904168e22/src/renderer/dx/DxRenderer.cpp#L1965 It's not a big deal, but I think the code would make a lot more sense as: useBoldFont = textAttributes.IsIntense() && renderSettings.GetRenderMode(RenderSettings::Mode::IntenseIsBold); Similarly, when handling the `IntenseIsBright` mode, instead of this: https://github.com/microsoft/terminal/blob/f605adc994c7c7cf06b0c83169b54ead62238f23/src/renderer/base/RenderSettings.cpp#L183 we'd have this: brightenFg = attr.IsIntense() && GetRenderMode(Mode::IntenseIsBright); # Proposed technical implementation details (optional) Rename the `Bold` option in the `ExtendedAttributes` enum to `Intense`, the `SetBold` and `IsBold` methods in the `TextAttribute` class to `SetIntense` and `IsIntense`. There will probably also be a few more variables and methods in other places that needed to be updated to match.
claunia commented 2026-01-31 05:14:07 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Jan 25, 2022):

I find "bold" a lot easier to grasp than the more abstract term "intense", since nowadays CRT displays are kinda rare and we don't have the capability to make LCD "rays" more "intense". 😅 But I still find this suggestion good, because it makes things more consistent.

@lhecker commented on GitHub (Jan 25, 2022): I find "bold" a lot easier to grasp than the more abstract term "intense", since nowadays CRT displays are kinda rare and we don't have the capability to make LCD "rays" more "intense". 😅 But I still find this suggestion good, because it makes things more consistent.
claunia commented 2026-01-31 05:14:07 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Jan 26, 2022):

I find "bold" a lot easier to grasp than the more abstract term "intense"

Yeah, me too, but that is the terminology that was ultimately decided on, and I've kind of got used to it now. Whatever term we use, though, I would like it to be consistent.

@j4james commented on GitHub (Jan 26, 2022): > I find "bold" a lot easier to grasp than the more abstract term "intense" Yeah, me too, but that is the terminology that was ultimately decided on, and I've kind of got used to it now. Whatever term we use, though, I would like it to be consistent.
claunia commented 2026-01-31 05:14:07 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jan 26, 2022):

Yea I'm 100% for this. Clear up the ambiguity. At least "intense" makes a person think "what does intense mean?" which will lead them to IntenseIsBright, IntenseIsBold. Go for it ☺️

@zadjii-msft commented on GitHub (Jan 26, 2022): Yea I'm 100% for this. Clear up the ambiguity. At least "intense" makes a person think "what does _intense_ mean?" which will lead them to IntenseIsBright, IntenseIsBold. Go for it ☺️
claunia commented 2026-01-31 05:14:08 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Feb 3, 2022):

:tada:This issue was addressed in #12270, which has now been successfully released as Windows Terminal Preview v1.13.10336.0.🎉

Handy links:

@ghost commented on GitHub (Feb 3, 2022): :tada:This issue was addressed in #12270, which has now been successfully released as `Windows Terminal Preview v1.13.10336.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.13.10336.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-VT Help Wanted Issue-Task Product-Meta Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#16502
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?