starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Do we really need the DispatchCommon class? #16508

New Issue
Closed
opened 2026-01-31 05:14:14 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 05:14:14 +00:00
Owner
Copy Link

Originally created by @j4james on GitHub (Jan 25, 2022).

Originally assigned to: @j4james on GitHub.

Description of the new feature/enhancement

If we move the DispatchCommon::s_ResizeWindow implementation into the ConhostInternalGetSet class, then DispatchCommon is just a set of static functions that indirectly call into the ConGetSet interface. The calling code could just as easily call the ConGetSet API directly.

Proposed technical implementation details (optional)

Everywhere that we're making a call like this:

DispatchCommon::s_RefreshWindow(*_pConApi);

we'd simple change it to something like this:

_pConApi->RefreshWindow();
Originally created by @j4james on GitHub (Jan 25, 2022). Originally assigned to: @j4james on GitHub. # Description of the new feature/enhancement If we move the `DispatchCommon::s_ResizeWindow` implementation into the `ConhostInternalGetSet` class, then `DispatchCommon` is just a set of static functions that indirectly call into the `ConGetSet` interface. The calling code could just as easily call the `ConGetSet` API directly. # Proposed technical implementation details (optional) Everywhere that we're making a call like this: DispatchCommon::s_RefreshWindow(*_pConApi); we'd simple change it to something like this: _pConApi->RefreshWindow();
claunia commented 2026-01-31 05:14:15 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jan 26, 2022):

I have no idea why I didn't just do it that way in the first place 😅

@zadjii-msft commented on GitHub (Jan 26, 2022): I have no idea why I didn't just do it that way in the first place 😅
claunia commented 2026-01-31 05:14:16 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (May 24, 2022):

:tada:This issue was addressed in #12389, which has now been successfully released as Windows Terminal Preview v1.14.143.🎉

Handy links:

@ghost commented on GitHub (May 24, 2022): :tada:This issue was addressed in #12389, which has now been successfully released as `Windows Terminal Preview v1.14.143`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.14.143) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-VT Help Wanted Issue-Task Product-Meta Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#16508
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?