starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Can we eliminate some of the IStateMachineEngine virtuals #16509

New Issue
Closed
opened 2026-01-31 05:14:19 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 05:14:19 +00:00
Owner
Copy Link

Originally created by @j4james on GitHub (Jan 25, 2022).

Description of the new feature/enhancement

The IStateMachineEngine interface has a bunch of methods that influence how the StateMachine works. I'm referring to methods like ParseControlSequenceAfterSs3 and DispatchControlCharsFromEscape. They all return a boolean value that is always true for the InputStateMachineEngine, and false for the OutputStateMachineEngine.

If we just constructed the StateMachine with another parameter indicating whether it was input or output, we could reimplement those methods in the state machine itself with a simple field lookup, thus avoiding the expensive overhead of those virtual method calls.

Proposed technical implementation details (optional)

As described above.

Another idea I had, which may be a bit crazy, is to turn the StateMachine into a template, with separate instances for the input and output engines. That way you could avoid all of the virtual method calls, which could make quite a difference to the performance.

I realise that could bloat the code size a bit, but maybe the avoidance of virtuals will give the compiler more scope for optimising things, which could save a bit of space. I wouldn't expect it to be smaller, but the increase in size may not be that bad. Is it worth trying?

Originally created by @j4james on GitHub (Jan 25, 2022). # Description of the new feature/enhancement The `IStateMachineEngine` interface has a bunch of methods that influence how the `StateMachine` works. I'm referring to methods like `ParseControlSequenceAfterSs3` and `DispatchControlCharsFromEscape`. They all return a boolean value that is always true for the `InputStateMachineEngine`, and false for the `OutputStateMachineEngine`. If we just constructed the `StateMachine` with another parameter indicating whether it was input or output, we could reimplement those methods in the state machine itself with a simple field lookup, thus avoiding the expensive overhead of those virtual method calls. # Proposed technical implementation details (optional) As described above. Another idea I had, which may be a bit crazy, is to turn the `StateMachine` into a template, with separate instances for the input and output engines. That way you could avoid _all_ of the virtual method calls, which could make quite a difference to the performance. I realise that could bloat the code size a bit, but maybe the avoidance of virtuals will give the compiler more scope for optimising things, which could save a bit of space. I wouldn't expect it to be smaller, but the increase in size may not be _that_ bad. Is it worth trying?
claunia commented 2026-01-31 05:14:20 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jan 26, 2022):

Meh yea probably. These are likely artifacts from a time when we thought we should be more open to possible future implementations, but I think the perf gain is more important now. Let's do it

@zadjii-msft commented on GitHub (Jan 26, 2022): Meh yea probably. These are likely artifacts from a time when we thought we should be more open to possible future implementations, but I think the perf gain is more important now. Let's do it
claunia commented 2026-01-31 05:14:21 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Feb 3, 2022):

:tada:This issue was addressed in #12277, which has now been successfully released as Windows Terminal Preview v1.13.10336.0.🎉

Handy links:

@ghost commented on GitHub (Feb 3, 2022): :tada:This issue was addressed in #12277, which has now been successfully released as `Windows Terminal Preview v1.13.10336.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.13.10336.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-VT Help Wanted Issue-Task Product-Meta Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#16509
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?