starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

A bunch of settings don't get duplicated #16521

New Issue
Closed
opened 2026-01-31 05:14:38 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 05:14:38 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Jan 26, 2022).

How did the X macros for settings not help this?

Apparently we didnt use the macro for CascadiaSettings::DuplicateProfile!

UseAtlasEngine, BellSound, and Elevate are all missing from the duplicate. Connection type too, but that one's... tricky maybe. Opacity is duplicated, but it's not otherwise in the appearance macro. Uh oh.

Originally posted by @zadjii-msft in https://github.com/microsoft/terminal/pull/12257#issuecomment-1022657199

Originally created by @zadjii-msft on GitHub (Jan 26, 2022). > How did the X macros for settings not help this? Apparently we didnt use the macro for `CascadiaSettings::DuplicateProfile`! `UseAtlasEngine`, `BellSound`, and `Elevate` are all missing from the duplicate. Connection type too, but that one's... tricky maybe. `Opacity` is duplicated, but it's not otherwise in the appearance macro. Uh oh. _Originally posted by @zadjii-msft in https://github.com/microsoft/terminal/pull/12257#issuecomment-1022657199_
claunia commented 2026-01-31 05:14:40 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jan 26, 2022):

We should really use the macros for these. MTSM_PROFILE_SETTINGS et. al.

@zadjii-msft commented on GitHub (Jan 26, 2022): We should really use the macros for these. `MTSM_PROFILE_SETTINGS` et. al.
claunia commented 2026-01-31 05:14:41 +00:00
Author
Owner
Copy Link

@ianjoneill commented on GitHub (Jan 27, 2022):

So I've done a quick comparison between the macros and the duplicate method. Given the number of differences, I think I'm going to have to pass up on my offer of fixing this - I don't know the consequence of some of the properties not currently existing in the macro!

Profile settings

Missing from duplicate but in MTSM_PROFILE_SETTINGS

  • BellSound
  • Elevate
  • UseAtlasEngine

Missing from MTSM_PROFILE_SETTINGS but duplicated

  • Padding
  • TabColor

ConnectionType is duplicated, but special cased at the end (#12120)

Font settings

All good 🎉

Appearance settings

Missing from MTSM_APPEARANCE_SETTINGS but duplicated

  • Background
  • CursorColor
  • Foreground
  • Opacity
  • SelectionBackground
@ianjoneill commented on GitHub (Jan 27, 2022): So I've done a quick comparison between the macros and the duplicate method. Given the number of differences, I think I'm going to have to pass up on my offer of fixing this - I don't know the consequence of some of the properties not currently existing in the macro! ## Profile settings ### Missing from duplicate but in `MTSM_PROFILE_SETTINGS` * `BellSound` * `Elevate` * `UseAtlasEngine` ### Missing from `MTSM_PROFILE_SETTINGS` but duplicated * `Padding` * `TabColor` `ConnectionType` is duplicated, but special cased at the end (#12120) ## Font settings All good 🎉 ## Appearance settings ### Missing from `MTSM_APPEARANCE_SETTINGS` but duplicated * `Background` * `CursorColor` * `Foreground` * `Opacity` * `SelectionBackground`
claunia commented 2026-01-31 05:14:41 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jan 27, 2022):

@ianjoneill that's perfectly reasonable. As soon as I saw how the two had diverged I was a little worried about asking an external contributor to help with that mess 😅

Thanks for the great write-up! This should make our lives a lot easier

@zadjii-msft commented on GitHub (Jan 27, 2022): @ianjoneill that's perfectly reasonable. As soon as I saw how the two had diverged I was a little worried about asking an external contributor to help with that mess 😅 Thanks for the great write-up! This should make our lives a lot easier
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings Issue-Bug Priority-1 Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#16521
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?