starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-24 16:05:21 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Can we get rid of the AdaptDefaults interface? #16582

New Issue
Closed
opened 2026-01-31 05:16:23 +00:00 by claunia · 4 comments
claunia commented 2026-01-31 05:16:23 +00:00
Owner
Copy Link

Originally created by @j4james on GitHub (Feb 1, 2022).

Originally assigned to: @j4james on GitHub.

Description of the new feature/enhancement

There are three methods in the AdaptDefaults interface:

  • The Execute method is never used at all. This is equivalent to the ExecuteChar method in ITerminalApi, which is also not used.
  • The Print method, which takes a char, is ultimately implemented as a call to PrintString, so this could easily be replaced with PrintString in the calling code, as is done in the TerminalDispatch implementation.
  • The PrintString method is all that's left, and that could be moved into the ConGetSet interface, the same way we have a PrintString method in the ITerminalApi interface.

This means the AdaptDispatch class only needs to be constructed with a ConGetSet parameter, which would more closely match the TerminalDispatch class.

Proposed technical implementation details (optional)

Most of the details are covered above. Essentially we'd move the PrintString method into ConGetSet interface and nuke everything else.

Originally created by @j4james on GitHub (Feb 1, 2022). Originally assigned to: @j4james on GitHub. # Description of the new feature/enhancement There are three methods in the [`AdaptDefaults`](https://github.com/microsoft/terminal/blob/fb597ed304ec6eef245405c9652e9b8a029b821f/src/terminal/adapter/adaptDefaults.hpp#L21) interface: * The `Execute` method is never used at all. This is equivalent to the [`ExecuteChar`](https://github.com/microsoft/terminal/blob/62c95b5017e92a780cdc43008e30b4e43d2edc9b/src/cascadia/TerminalCore/ITerminalApi.hpp#L23) method in `ITerminalApi`, which is also not used. * The `Print` method, which takes a char, is ultimately implemented as a call to `PrintString`, so this could easily be replaced with `PrintString` in the calling code, as is done in the [`TerminalDispatch`](https://github.com/microsoft/terminal/blob/main/src/cascadia/TerminalCore/TerminalDispatch.cpp#L29) implementation. * The `PrintString` method is all that's left, and that could be moved into the `ConGetSet` interface, the same way we have a `PrintString` method in the `ITerminalApi` interface. This means the `AdaptDispatch` class only needs to be constructed with a `ConGetSet` parameter, which would more closely match the `TerminalDispatch` class. # Proposed technical implementation details (optional) Most of the details are covered above. Essentially we'd move the `PrintString` method into `ConGetSet` interface and nuke everything else.
claunia commented 2026-01-31 05:16:24 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Feb 1, 2022):

We absolutely can!

@DHowett commented on GitHub (Feb 1, 2022): We absolutely can!
claunia commented 2026-01-31 05:16:25 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Feb 1, 2022):

James -- do you want me to formally assign you on these "can we do a cleanup" bugs? You're knocking it out of the park here, as usual. :)

@DHowett commented on GitHub (Feb 1, 2022): James -- do you want me to formally assign you on these "can we do a cleanup" bugs? You're knocking it out of the park here, as usual. :)
claunia commented 2026-01-31 05:16:25 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Feb 1, 2022):

You can if that helps. I'm definitely working on this one and #12253, but ideally they'd both need PR #12247 merged first.

@j4james commented on GitHub (Feb 1, 2022): You can if that helps. I'm definitely working on this one and #12253, but ideally they'd both need PR #12247 merged first.
claunia commented 2026-01-31 05:16:25 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (May 24, 2022):

:tada:This issue was addressed in #12390, which has now been successfully released as Windows Terminal Preview v1.14.143.🎉

Handy links:

@ghost commented on GitHub (May 24, 2022): :tada:This issue was addressed in #12390, which has now been successfully released as `Windows Terminal Preview v1.14.143`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.14.143) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-VT Help Wanted Issue-Task Product-Meta Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#16582
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?