starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Profile matching doesn't work with paths containing unquoted whitespace #16609

New Issue
Open
opened 2026-01-31 05:17:13 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 05:17:13 +00:00
Owner
Copy Link

Originally created by @lhecker on GitHub (Feb 3, 2022).

Windows Terminal version

1.12.2922.0

Steps to reproduce

Issue 1 - paths with more than 1 whitespace

This code:
e064c15675/src/cascadia/TerminalSettingsModel/CascadiaSettings.cpp (L756-L757)

When the loop is executed a second time (meaning: paths having more than one whitespace), argv[2][-1] should be set to whitespace, since argv[1][-1] still refers to the old whitespace between the first two arguments.

Due to this, the path

C:\foo - bar\baz.exe 60 120

is resolved to

"C:\\foo - bar\\baz.exe 60 120"

when it should be

"C:\\foo - bar\\baz.exe\060\0120"

Since SearchPathW will never have been given a valid path, path resolution will fail entirely and the input path be returned unmodified.

Issue 2 - path resolution picks the first matching directory

This code:
e064c15675/src/cascadia/TerminalSettingsModel/CascadiaSettings.cpp (L717-L719)

SearchPathW resolves to any path including directories and not just to file paths.

If you have

  • a directory at C:\foo
  • an executable at C:\foo - bar\baz.exe

then the path

C:\foo - bar\baz.exe 60 120

will be resolved to

"C:\\foo\0-\0bar\\baz.exe\060\0120"
        ^^ ^^

when it should be

"C:\\foo - bar\\baz.exe\060\0120"

Profile matching will still succeed since the path of the handed off process is normalized the exact same way. However matching will be buggy, since it's ambigious with any path that actually has arguments in these places.

Originally created by @lhecker on GitHub (Feb 3, 2022). ## Windows Terminal version 1.12.2922.0 ## Steps to reproduce ### Issue 1 - paths with more than 1 whitespace This code: https://github.com/microsoft/terminal/blob/e064c1567548f098233b7a2d1101cb5201dec049/src/cascadia/TerminalSettingsModel/CascadiaSettings.cpp#L756-L757 When the loop is executed a second time (meaning: paths having more than one whitespace), `argv[2][-1]` should be set to whitespace, since `argv[1][-1]` still refers to the old whitespace between the first two arguments. Due to this, the path ``` C:\foo - bar\baz.exe 60 120 ``` is resolved to ```cpp "C:\\foo - bar\\baz.exe 60 120" ``` when it should be ```cpp "C:\\foo - bar\\baz.exe\060\0120" ``` Since `SearchPathW` will never have been given a valid path, path resolution will fail entirely and the input path be returned unmodified. ### Issue 2 - path resolution picks the first matching directory This code: https://github.com/microsoft/terminal/blob/e064c1567548f098233b7a2d1101cb5201dec049/src/cascadia/TerminalSettingsModel/CascadiaSettings.cpp#L717-L719 `SearchPathW` resolves to any path including directories and not just to file paths. If you have * a directory at `C:\foo` * an executable at `C:\foo - bar\baz.exe` then the path ``` C:\foo - bar\baz.exe 60 120 ``` will be resolved to ```cpp "C:\\foo\0-\0bar\\baz.exe\060\0120" ^^ ^^ ``` when it should be ```cpp "C:\\foo - bar\\baz.exe\060\0120" ``` Profile matching will still succeed since the path of the handed off process is normalized the exact same way. However matching will be buggy, since it's ambigious with any path that actually has arguments in these places.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-DefApp Issue-Bug Priority-2 Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#16609
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?