Update Actions, Color Schemes pages in SUI to match Controlsv2 style #16660

Open
opened 2026-01-31 05:18:53 +00:00 by claunia · 5 comments
Owner

Originally created by @elsaco on GitHub (Feb 5, 2022).

Windows Terminal version

1.13.10336.0

Windows build number

10.0.19044.0

Other Software

No response

Steps to reproduce

  • open SUI and maximize terminal or Close Navigation (maximized is move visible)
  • go to Defaults or Rendering

Expected Behavior

  • text aligns with other SUI elements

Actual Behavior

wt_sui_align

Originally created by @elsaco on GitHub (Feb 5, 2022). ### Windows Terminal version 1.13.10336.0 ### Windows build number 10.0.19044.0 ### Other Software _No response_ ### Steps to reproduce - open SUI and maximize terminal or `Close Navigation` (maximized is move visible) - go to `Defaults` or `Rendering` ### Expected Behavior - text aligns with other SUI elements ### Actual Behavior ![wt_sui_align](https://user-images.githubusercontent.com/3933920/152649836-fe5dbad2-09e5-4d3a-a582-f63fed82b038.png)
claunia added the Issue-FeatureProduct-TerminalPriority-1Area-SettingsUI labels 2026-01-31 05:18:53 +00:00
Author
Owner

@j4james commented on GitHub (Feb 6, 2022):

I also think the alignment feels wrong on the Color schemes and Actions pages. The contents of those pages is centered, but the titles are way off to the left. I'm assuming that's intended match the title position on the other pages, but then I'd expect the content to be similarly left aligned rather than centered. As it is, it just looks broken to me.

@j4james commented on GitHub (Feb 6, 2022): I also think the alignment feels wrong on the _Color schemes_ and _Actions_ pages. The contents of those pages is centered, but the titles are way off to the left. I'm assuming that's intended match the title position on the other pages, but then I'd expect the content to be similarly left aligned rather than centered. As it is, it just looks broken to me.
Author
Owner

@zadjii-msft commented on GitHub (Feb 7, 2022):

This might already be fixed in #12374, @PankajBhojwani to confirm the bit about the ColorSchemes and Actions pages too

@zadjii-msft commented on GitHub (Feb 7, 2022): This might already be fixed in #12374, @PankajBhojwani to confirm the bit about the ColorSchemes and Actions pages too
Author
Owner

@PankajBhojwani commented on GitHub (Feb 7, 2022):

The disclaimer text on the Rendering and Defaults pages is fixed in #12374. As for the ColorSchemes and Actions pages, those pages have not yet been updated to the new style - once we get to updating those pages the alignment will be fixed. (We have to do some amount of backend work first before we can get to updating those pages - mainly implementing the MVVM pattern there).

@PankajBhojwani commented on GitHub (Feb 7, 2022): The disclaimer text on the Rendering and Defaults pages is fixed in #12374. As for the ColorSchemes and Actions pages, those pages have not yet been updated to the new style - once we get to updating those pages the alignment will be fixed. (We have to do some amount of backend work first before we can get to updating those pages - mainly implementing the MVVM pattern there).
Author
Owner

@zadjii-msft commented on GitHub (Mar 10, 2022):

Repurposing this to track the rejuv for those pages, and retitling. We've been using this to track that work anyways, the title may as well match.

Punted out of 1.14 because we don't have runway for the refactor required here.


Greatly trimmed Teams chat regarding design:

image

Then the expander gives a place for action args once we get those into the SUI

so expanded, that's got the action dropdown and the keybinding editor, and the.... delete button?

Yeah I'm thinking like this
image

Then since it's a text box inside the expander, it should show up on the top of the expander itself

okay so the expander content would basically just be what we have for the action now

@zadjii-msft commented on GitHub (Mar 10, 2022): Repurposing this to track the rejuv for those pages, and retitling. We've been using this to track that work anyways, the title may as well match. Punted out of 1.14 because we don't have runway for the refactor required here. <hr> Greatly trimmed Teams chat regarding design: > ![image](https://user-images.githubusercontent.com/18356694/157710425-798476a8-ad0c-4d3c-9296-da33260b1e55.png) > Then the expander gives a place for action args once we get those into the SUI > so expanded, that's got the action dropdown and the keybinding editor, and the.... delete button? > Yeah I'm thinking like this > ![image](https://user-images.githubusercontent.com/18356694/157711177-4899b79f-745c-4008-a4b6-7dcc192792fe.png) > Then since it's a text box inside the expander, it should show up on the top of the expander itself > okay so the expander content would basically just be what we have for the action now
Author
Owner

@zadjii-msft commented on GitHub (Jun 15, 2022):

See also

@zadjii-msft commented on GitHub (Jun 15, 2022): See also * #9775
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#16660