starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[Terminal]: 'Save' and 'Discard Changes' button should remain in disabled state until we don't make any changes inside Settings page. #16707

New Issue
Open
opened 2026-01-31 05:20:18 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 05:20:18 +00:00
Owner
Copy Link

Originally created by @ghost on GitHub (Feb 8, 2022).

Windows Terminal version

1.13.10336.0

Windows build number

10.0.22543.1000

Other Software

Test Environment:
OS: Windows 11 Version Dev (OS Build 22543.1000)
App: Windows Terminal Preview
Screen Reader: Narrator

Steps to reproduce

Repro Steps:

  1. Open Windows Terminal.
  2. Open Settings page using 'Ctr+,'.
  3. Observe the issue.

User Experience:
Users UX will not be good especially Screen Reader as nothing will happen when they activate 'Save' and 'Discard' as result they will not be able to figure out whether these buttons are actionable or not.

Attachments:
'Save' and 'Discard Changes' button should remain in disabled state until we don't make any changes..zip

Expected Behavior

'Save' and 'Discard Changes' button should remain in disabled state until we don't make any changes inside Setting page.

Actual Behavior

'Save' and 'Discard Changes' buttons are in active state even if they are not actionable inside Setting page.

Originally created by @ghost on GitHub (Feb 8, 2022). ### Windows Terminal version 1.13.10336.0 ### Windows build number 10.0.22543.1000 ### Other Software **Test Environment:** OS: Windows 11 Version Dev (OS Build 22543.1000) App: Windows Terminal Preview Screen Reader: Narrator ### Steps to reproduce **Repro Steps:** 1. Open Windows Terminal. 2. Open Settings page using 'Ctr+,'. 3. Observe the issue. **User Experience:** Users UX will not be good especially Screen Reader as nothing will happen when they activate 'Save' and 'Discard' as result they will not be able to figure out whether these buttons are actionable or not. **Attachments:** ['Save' and 'Discard Changes' button should remain in disabled state until we don't make any changes..zip](https://github.com/microsoft/terminal/files/8021036/Save.and.Discard.Changes.button.should.remain.in.disabled.state.until.we.don.t.make.any.changes.zip) ### Expected Behavior 'Save' and 'Discard Changes' button should remain in disabled state until we don't make any changes inside Setting page. ### Actual Behavior 'Save' and 'Discard Changes' buttons are in active state even if they are not actionable inside Setting page.
claunia commented 2026-01-31 05:20:19 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Feb 8, 2022):

This depends on #9207. Once that's complete, we can detect if changes have been made, and enable/disable the buttons.

We probably need to use SettingContainer to detect when a change occurred, and update some global view model property s_ChangesDetected = true.

Come to think of it, it would be cleaner to do this with MVVM done, but we could just store that static property off of MainPage (or MainPage's new view model, which we then populate more later). That would be a step in the right direction.

@carlos-zamora commented on GitHub (Feb 8, 2022): This depends on #9207. Once that's complete, we can detect if changes have been made, and enable/disable the buttons. We probably need to use `SettingContainer` to detect when a change occurred, and update some global view model property `s_ChangesDetected = true`. Come to think of it, it would be cleaner to do this with MVVM done, but we could just store that static property off of `MainPage` (or `MainPage`'s new view model, which we then populate more later). That would be a step in the right direction.
claunia commented 2026-01-31 05:20:19 +00:00
Author
Owner
Copy Link

@akash07k commented on GitHub (Feb 16, 2022):

@carlos-zamora Absolutely.
MVVM pattern in settings UI will be a lot appreciated.
It will make the things more flexible

@akash07k commented on GitHub (Feb 16, 2022): @carlos-zamora Absolutely. MVVM pattern in settings UI will be a lot appreciated. It will make the things more flexible
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label A11yCO A11yUsable Area-Accessibility Area-SettingsUI HCL-E+D HCL-WindowsTerminal Issue-Feature Priority-3 Product-Terminal WindowsTerminal_Win32
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#16707
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?