starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[MSVC][std:c++latest] terminal failed to build with /std:c++latest on MSVC #16796

New Issue
Closed
opened 2026-01-31 05:23:00 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 05:23:00 +00:00
Owner
Copy Link

Originally created by @xiaoxiao-Xu on GitHub (Feb 17, 2022).

Windows Terminal version

No response

Windows build number

10.0.19041.0

Other Software

No response

Steps to reproduce

The MSVC team recently added terminal as part of RWC testing. But we found some errors when building terminal with '/std:c++latest'.

repro steps:

  1. git clone https://github.com/microsoft/terminal.git F:\gitP\microsoft\terminal
  2. cd F:\gitP\microsoft\terminal
  3. set _CL_= /std:c++latest
  4. set _CL_=/wd4189 %_CL_%
  5. msbuild /m /p:Platform=x64 /p:Configuration=Release /p:WindowsTargetPlatformVersion=10.0.20348.0 OpenConsole.sln /t:Restore /t:Rebuild

Expected Behavior

Terminal could build successfully with '/std:c++latest'.

Actual Behavior

precomp.cpp
C:\Program Files (x86)\Windows Kits\10\include\10.0.19041.0\winrt\wrl\module.h(1275,10): error C2220: the following warning is treated as an error
C:\Program Files (x86)\Windows Kits\10\include\10.0.19041.0\winrt\wrl\module.h(1275,10): warning C5104: found 'L#serverName' in macro replacement list, did you mean 'L""#serverName'?
C:\Program Files (x86)\Windows Kits\10\include\10.0.19041.0\winrt\wrl\module.h(1275,10): note: to simplify migration, consider the temporary use of /Wv:18 flag with the version of the compiler with which you used to build without warnings
F:\gitP\microsoft\terminal\src\inc\til\bit.h(12,1): fatal error C1021: invalid preprocessor command 'warning'
build.log

Originally created by @xiaoxiao-Xu on GitHub (Feb 17, 2022). ### Windows Terminal version _No response_ ### Windows build number 10.0.19041.0 ### Other Software _No response_ ### Steps to reproduce The MSVC team recently added terminal as part of RWC testing. But we found some errors when building terminal with '/std:c++latest'. **repro steps:** 1. `git clone https://github.com/microsoft/terminal.git F:\gitP\microsoft\terminal` 2. `cd F:\gitP\microsoft\terminal` 3. `set _CL_= /std:c++latest` 4. `set _CL_=/wd4189 %_CL_%` 5. `msbuild /m /p:Platform=x64 /p:Configuration=Release /p:WindowsTargetPlatformVersion=10.0.20348.0 OpenConsole.sln /t:Restore /t:Rebuild` ### Expected Behavior Terminal could build successfully with '/std:c++latest'. ### Actual Behavior precomp.cpp C:\Program Files (x86)\Windows Kits\10\include\10.0.19041.0\winrt\wrl\module.h(1275,10): error C2220: the following warning is treated as an error C:\Program Files (x86)\Windows Kits\10\include\10.0.19041.0\winrt\wrl\module.h(1275,10): warning C5104: found 'L#serverName' in macro replacement list, did you mean 'L""#serverName'? C:\Program Files (x86)\Windows Kits\10\include\10.0.19041.0\winrt\wrl\module.h(1275,10): note: to simplify migration, consider the temporary use of /Wv:18 flag with the version of the compiler with which you used to build without warnings F:\gitP\microsoft\terminal\src\inc\til\bit.h(12,1): fatal error C1021: invalid preprocessor command 'warning' [build.log](https://github.com/microsoft/terminal/files/8086582/build.log)
claunia commented 2026-01-31 05:23:03 +00:00
Author
Owner
Copy Link

@xiaoxiao-Xu commented on GitHub (Feb 17, 2022):

Note: It's lucky that the warning C5104 disappeared with Windows SDK 10.0.20348.0.

@xiaoxiao-Xu commented on GitHub (Feb 17, 2022): Note: It's lucky that the warning C5104 disappeared with Windows SDK 10.0.20348.0.
claunia commented 2026-01-31 05:23:04 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Feb 17, 2022):

The MSVC team recently added terminal as part of RWC testing

Thanks!

winrt\wrl\module.h(1275,10): warning C5104

welp, we'll have to just suppress that one, since we don't own WRL

src\inc\til\bit.h(12,1): fatal error C1021

okay yea that one's on us 😅

@zadjii-msft commented on GitHub (Feb 17, 2022): > The MSVC team recently added terminal as part of RWC testing Thanks! > `winrt\wrl\module.h(1275,10): warning C5104` welp, we'll have to just suppress that one, since we don't own WRL > `src\inc\til\bit.h(12,1): fatal error C1021` okay yea that one's on us 😅
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Build good first issue Help Wanted Issue-Task Priority-1 Product-Meta Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#16796
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?