starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Partners cannot rename a template via fragment plugins #16804

New Issue
Closed
opened 2026-01-31 05:23:31 +00:00 by claunia · 6 comments
claunia commented 2026-01-31 05:23:31 +00:00
Owner
Copy Link

Originally created by @didrocks on GitHub (Feb 18, 2022).

Windows Terminal version

No response

Windows build number

No response

Other Software

No response

Steps to reproduce

Ship a template fragment with something like:

"profiles": [
      {
        "updates": "{f184b75f-6c82-5ea5-9b3e-3203d66c5f82}",
        "name": "My new profile name",
      },
    ]
  }

Then restart the terminal to take the new fragment in account.

Expected Behavior

"My new profile name" should appear as the profile name

Actual Behavior

The old name still appears, "name" in case of "update" is discared.

The rationale here is to replace the generated named in WSL, which is using the registered WSL ID (Ubuntu2004LTS for instance) instead of the Display Name registered (and used as the tab name entry) like the more readable Ubuntu 20.04 LTS.
Other kind of entries are overridden by the fragment, but not the name one.

The workaround right now is to hide the generated template with hidden: true and add a whole new entry.

Originally created by @didrocks on GitHub (Feb 18, 2022). ### Windows Terminal version _No response_ ### Windows build number _No response_ ### Other Software _No response_ ### Steps to reproduce Ship a template fragment with something like: ``` "profiles": [ { "updates": "{f184b75f-6c82-5ea5-9b3e-3203d66c5f82}", "name": "My new profile name", }, ] } ``` Then restart the terminal to take the new fragment in account. ### Expected Behavior "My new profile name" should appear as the profile name ### Actual Behavior The old name still appears, "name" in case of "update" is discared. The rationale here is to replace the generated named in WSL, which is using the registered WSL ID (`Ubuntu2004LTS` for instance) instead of the Display Name registered (and used as the tab name entry) like the more readable `Ubuntu 20.04 LTS`. Other kind of entries are overridden by the fragment, but not the `name` one. The workaround right now is to hide the generated template with `hidden: true` and add a whole new entry.
claunia commented 2026-01-31 05:23:33 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Feb 18, 2022):

Huh. It should be able to do that. Why doesn't that work? I bet this regressed in one of the many settings refactors over the last few months.

Thanks for filing this! Let's make sure to get this fixed.

@zadjii-msft commented on GitHub (Feb 18, 2022): Huh. It should be able to do that. Why doesn't that work? I bet this regressed in one of the many settings refactors over the last few months. Thanks for filing this! Let's make sure to get this fixed.
claunia commented 2026-01-31 05:23:33 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Feb 23, 2022):

/cc @lhecker for this one ;)

@DHowett commented on GitHub (Feb 23, 2022): /cc @lhecker for this one ;)
claunia commented 2026-01-31 05:23:34 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Feb 23, 2022):

I'll debug this issue starting next week. 🙂

@lhecker commented on GitHub (Feb 23, 2022): I'll debug this issue starting next week. 🙂
claunia commented 2026-01-31 05:23:34 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Mar 4, 2022):

The problem here is that fields in a user's settings.json take precedence over fragments. Since profiles are created and written with a "name" field, the "name" field in fragments usually has no effect. If you were to remove the "name" field from your settings.json this would work as expected.

What is unexpected however is that we don't respect such updates when the dynamic profile is first added. I'm going to submit a PR for that.

@lhecker commented on GitHub (Mar 4, 2022): The problem here is that fields in a user's settings.json take precedence over fragments. Since profiles are created and written with a "name" field, the "name" field in fragments usually has no effect. If you were to remove the "name" field from your settings.json this would work as expected. What is unexpected however is that we don't respect such updates when the dynamic profile is first added. I'm going to submit a PR for that.
claunia commented 2026-01-31 05:23:35 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Apr 19, 2022):

:tada:This issue was addressed in #12627, which has now been successfully released as Windows Terminal v1.12.1098.🎉

Handy links:

@ghost commented on GitHub (Apr 19, 2022): :tada:This issue was addressed in #12627, which has now been successfully released as `Windows Terminal v1.12.1098`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.12.1098) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
claunia commented 2026-01-31 05:23:35 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Apr 19, 2022):

:tada:This issue was addressed in #12627, which has now been successfully released as Windows Terminal Preview v1.13.1098.🎉

Handy links:

@ghost commented on GitHub (Apr 19, 2022): :tada:This issue was addressed in #12627, which has now been successfully released as `Windows Terminal Preview v1.13.1098`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.13.1098) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings Issue-Bug Priority-1 Product-Terminal Resolution-Fix-Committed zAskModeBug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#16804
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?