starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

TerminalApp.Unit.Tests.manifest gets updated when building #16836

New Issue
Closed
opened 2026-01-31 05:24:30 +00:00 by claunia · 1 comment
claunia commented 2026-01-31 05:24:30 +00:00
Owner
Copy Link

Originally created by @j4james on GitHub (Feb 21, 2022).

Windows Terminal version

Commit 09e9915672

Windows build number

10.0.19041.1415

Other Software

No response

Steps to reproduce

  1. Checkout the latest source (commit 09e9915672 or later).
  2. Build the solution.
  3. Look for any modified files in git status.

Expected Behavior

There shouldn't be any modified files.

Actual Behavior

The TerminalApp.Unit.Tests.manifest file is being updated with the same changes that were made to the WindowsTerminal.manifest file in PR #12462.

Shouldn't those changes have been committed at the same time as the WindowsTerminal manifest? Or if the unit test manifest is generated automatically, then maybe it shouldn't be committed at all.

Or am I the only one that's getting this?

Originally created by @j4james on GitHub (Feb 21, 2022). ### Windows Terminal version Commit 09e99156727a92f84b309f18aee59ea7293b1264 ### Windows build number 10.0.19041.1415 ### Other Software _No response_ ### Steps to reproduce 1. Checkout the latest source (commit 09e99156727a92f84b309f18aee59ea7293b1264 or later). 2. Build the solution. 3. Look for any modified files in git status. ### Expected Behavior There shouldn't be any modified files. ### Actual Behavior The [TerminalApp.Unit.Tests.manifest](https://github.com/microsoft/terminal/blob/main/src/cascadia/ut_app/TerminalApp.Unit.Tests.manifest) file is being updated with the same changes that were made to the [WindowsTerminal.manifest](https://github.com/microsoft/terminal/blob/main/src/cascadia/WindowsTerminal/WindowsTerminal.manifest) file in PR #12462. Shouldn't those changes have been committed at the same time as the WindowsTerminal manifest? Or if the unit test manifest is generated automatically, then maybe it shouldn't be committed at all. Or am I the only one that's getting this?
claunia added the Resolution-Fix-CommittedIssue-BugNeeds-Tag-Fix labels 2026-01-31 05:24:30 +00:00
claunia commented 2026-01-31 05:24:31 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Feb 21, 2022):

What, no, I always build the unit tests.... 😅

I think there's at least one open PR that's got a similar update in it snuck in, but if you'd like to submit a PR just for this tiny bit then that's fine.

Frankly those tests should probably be reworked into the broader localtests or fixed so they don't need to do that anymore, but 🤷

@zadjii-msft commented on GitHub (Feb 21, 2022): What, no, I always build the unit tests.... 😅 I think there's at least one open PR that's got a similar update in it snuck in, but if you'd like to submit a PR just for this tiny bit then that's fine. Frankly those tests should probably be reworked into the broader localtests or fixed so they don't need to do that anymore, but 🤷
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Issue-Bug Needs-Tag-Fix Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#16836
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?