starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

We shouldn't have our own startup setting, we should just use the OS one #16857

New Issue
Closed
opened 2026-01-31 05:25:15 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 05:25:15 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Feb 24, 2022).

From MSFT:34529127

Steps to repro:

  1. Open Settings - App - Start up.
  2. Enable start up setting for Windows Terminal.
  3. Reboot.

Expected results:
Windows Terminal can launch automatically after enter desktop and App start up setting should be on for Windows Terminal.
Actual results:
Windows Terminal can launch automatically after enter desktop, but App start up setting become off for Windows Terminal.

More notes, circa Dec 2023:

Okay so we all re-read all the docs and I think we were wrong entirely here.

We should have never had this setting in our settings JSON in the first place. It should have always just been backed by the OS setting. This probably dates back to us just having a JSON settings file. We should make the settings in the Terminal Settings UI reflect the OS settings. We shouldn't maintain our own separate setting.

We need the Windows Settings Startup being Enabled to trigger Windows to start Terminal on next reboot.
And, we need the Terminal Settings Startup to be Enabled, to keep it in the Enabled state for Windows. If this is not enabled, when Windows launches Terminal after reboot, Terminal app itself disables the startup task here: 306f31acf4/src/cascadia/TerminalApp/AppLogic.cpp (L382)

Quickly glancing through the Terminal code, Terminal Settings Startup relies on "startOnUserLogin" value and is saved in a default file. This value does not change if the user changes startup state in Windows Settings.

I am not sure, why the startup task is disabled when StartupTaskState::Enabled in the above link. But in my opinion it shouldn't be disabled if the user has enabled it in Windows settings. and use the value returned by StartupTask::GetAsync(StartupTaskName) for "startOnUserLogin".

Note

Walkthrough

I need to write a new one!

We need to:

  • Ditch the old setting entirely.
  • Make the toggle in the Settings tab reflect the OS setting
  • probably remove Enabled="false" from our manidest, ala #16244
Originally created by @zadjii-msft on GitHub (Feb 24, 2022). From MSFT:34529127 > Steps to repro: > 1. Open Settings - App - Start up. > 2. Enable start up setting for Windows Terminal. > 3. Reboot. > > Expected results: > Windows Terminal can launch automatically after enter desktop and App start up setting should be on for Windows Terminal. > Actual results: > Windows Terminal can launch automatically after enter desktop, but App start up setting become off for Windows Terminal. ---- More notes, circa Dec 2023: Okay so we all re-read all the docs and I think we were wrong entirely here. We should have never had this setting in our settings JSON in the first place. It should have always just been backed by the OS setting. This probably dates back to us just having a JSON settings file. We should make the settings in the Terminal Settings UI reflect the OS settings. We shouldn't maintain our own _separate_ setting. > We need the Windows Settings Startup being Enabled to trigger Windows to start Terminal on next reboot. And, we need the Terminal Settings Startup to be Enabled, to keep it in the Enabled state for Windows. If this is not enabled, when Windows launches Terminal after reboot, Terminal app itself disables the startup task here: https://github.com/microsoft/terminal/blob/306f31acf482ce84701aabee52981575277f16bb/src/cascadia/TerminalApp/AppLogic.cpp#L382 > > Quickly glancing through the Terminal code, Terminal Settings Startup relies on "`startOnUserLogin`" value and is saved in a default file. This value does not change if the user changes startup state in Windows Settings. > > I am not sure, why the startup task is disabled when `StartupTaskState::Enabled` in the above link. But in my opinion it shouldn't be disabled if the user has enabled it in Windows settings. and use the value returned by `StartupTask::GetAsync(StartupTaskName)` for "`startOnUserLogin`". > [!Note] > ## Walkthrough I need to write a new one! We need to: * Ditch the old setting entirely. * Make the toggle in the Settings tab reflect the OS setting * probably remove `Enabled="false"` from our manidest, ala #16244
claunia commented 2026-01-31 05:25:16 +00:00
Author
Owner
Copy Link

@Griffin641498 commented on GitHub (Sep 22, 2023):

From MSFT:34529127

Steps to repro:

  1. Open Settings - App - Start up.
  2. Enable start up setting for Windows Terminal.
  3. Reboot.

Expected results:
Windows Terminal can launch automatically after enter desktop and App start up setting should be on for Windows Terminal.
Actual results:
Windows Terminal can launch automatically after enter desktop, but App start up setting become off for Windows Terminal.

Note

Walkthrough

        <uap5:Extension Category="windows.startupTask">
          <uap5:StartupTask
            TaskId="StartTerminalOnLoginTask"
            Enabled="false"
            DisplayName="ms-resource:AppName" />
        </uap5:Extension>

That apparently can just be unset like:

        <uap5:Extension Category="windows.startupTask">
          <uap5:StartupTask
            TaskId="StartTerminalOnLoginTask"
            DisplayName="ms-resource:AppName" />
        </uap5:Extension>
@Griffin641498 commented on GitHub (Sep 22, 2023): > From MSFT:34529127 > > > > > Steps to repro: > > 1. Open Settings - App - Start up. > > 2. Enable start up setting for Windows Terminal. > > 3. Reboot. > > > > Expected results: > > Windows Terminal can launch automatically after enter desktop and App start up setting should be on for Windows Terminal. > > Actual results: > > Windows Terminal can launch automatically after enter desktop, but App start up setting become off for Windows Terminal. > > > **Note** > > ## Walkthrough > > ```xml > <uap5:Extension Category="windows.startupTask"> > <uap5:StartupTask > TaskId="StartTerminalOnLoginTask" > Enabled="false" > DisplayName="ms-resource:AppName" /> > </uap5:Extension> > ``` > > That apparently can just be unset like: > > ```xml > <uap5:Extension Category="windows.startupTask"> > <uap5:StartupTask > TaskId="StartTerminalOnLoginTask" > DisplayName="ms-resource:AppName" /> > </uap5:Extension> > ```
claunia commented 2026-01-31 05:25:17 +00:00
Author
Owner
Copy Link

@Harsh-Avinash commented on GitHub (Oct 18, 2023):

I would love to take this up!

@Harsh-Avinash commented on GitHub (Oct 18, 2023): I would love to take this up!
claunia commented 2026-01-31 05:25:17 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Oct 18, 2023):

@Harsh-Avinash Go for it! Lemme know if you need any help ☺️

@zadjii-msft commented on GitHub (Oct 18, 2023): @Harsh-Avinash Go for it! Lemme know if you need any help ☺️
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Help Wanted In-PR Issue-Bug Needs-Tag-Fix Priority-2 Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#16857
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?