starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

the tab title after launching powershell (launches terminal I think) doesn't make sense... "app data"??? #16876

New Issue
Open
opened 2026-01-31 05:25:51 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 05:25:51 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Feb 25, 2022).

From MSFT:38253775

When launching pwsh From the Start Menu with defterm enabled, the title is set to the full path to the shortcut, rather than "PowerShell 7" (or whatever"

image

idle thought: might be because conpty doesn't load ANY settings when we start it. In this case thought, the title is a setting that's in the lnk.

Unclear if this is something we could fix Terminal side. IDK if we know the lnk when we get an inbound connection.

Originally created by @zadjii-msft on GitHub (Feb 25, 2022). From MSFT:38253775 When launching pwsh From the Start Menu with defterm enabled, the title is set to the full path to the shortcut, rather than "PowerShell 7" (or whatever" ![image](https://user-images.githubusercontent.com/18356694/155758395-150af0a6-3902-4f64-8163-19654152e803.png) idle thought: might be because conpty doesn't load ANY settings when we start it. In this case thought, the _title_ is a setting that's in the lnk. Unclear if this is something we could fix Terminal side. IDK if we know the lnk when we get an inbound connection.
claunia commented 2026-01-31 05:25:52 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Feb 25, 2022):

My theory is that this code:
53a454fbd3/src/renderer/base/RenderEngineBase.cpp (L29)

is supposed to be:

if (_titleChanged)

This would match how GdiEngine works, as it assumes it only needs to render if _titleChanged is true.
See OpenConsole!2043946 where a review comment implies that this was actually always supposed to use _titleChanged.

@lhecker commented on GitHub (Feb 25, 2022): My theory is that this code: https://github.com/microsoft/terminal/blob/53a454fbd3e2992be5c1f2c8ed9e2c2974f0e7b8/src/renderer/base/RenderEngineBase.cpp#L29 is supposed to be: ```cpp if (_titleChanged) ``` This would match how GdiEngine works, as it assumes it only needs to render if `_titleChanged` is `true`. See OpenConsole!2043946 where a review comment implies that this was actually always supposed to use `_titleChanged`.
claunia commented 2026-01-31 05:25:52 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Feb 25, 2022):

I suspect that changing the condition there will result in us simply not sending the title in the first frame ... because _titleChanged defaults to false.

Conhost is supposed to send its initial title in the first frame... we just need to make sure that the initial title is correct. I feel like the root of the problem is likely to be in accepting a handoff of a connection packet. srvinit.cpp:408 et al processes the new incoming connection packet from inbox conhost.

@DHowett commented on GitHub (Feb 25, 2022): I suspect that changing the condition there will result in us simply _not sending the title in the first frame_ ... because `_titleChanged` defaults to `false`. Conhost is _supposed_ to send its initial title in the first frame... we just need to make sure that the initial title is correct. I feel like the root of the problem is likely to be in accepting a handoff of a connection packet. srvinit.cpp:408 et al processes the new incoming connection packet from inbox conhost.
claunia commented 2026-01-31 05:25:52 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Feb 25, 2022):

Notes from a discussion: GDI doesn't paint the first title change to the HWND because the window is created with a title already (window.cpp:308)

@DHowett commented on GitHub (Feb 25, 2022): Notes from a discussion: GDI doesn't paint the first title change to the HWND because the window is _created_ with a title already (window.cpp:308)
claunia commented 2026-01-31 05:25:53 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Feb 25, 2022):

SetUpConsole calls GetSettingsFromLink, which uses s_GetLinkValues, which handles STARTF_TITLEISLNKNAME. using s_GetLinkTitle.

SetUpConsole only calls GetSettingsFromLink if it is not in ConPTY mode.

Effectively, it is ignoring the whole lnk (like it is supposed to), but in so doing it is also ignoring the link filename as the title

@DHowett commented on GitHub (Feb 25, 2022): > `SetUpConsole` calls `GetSettingsFromLink`, which uses `s_GetLinkValues`, which handles `STARTF_TITLEISLNKNAME`. using `s_GetLinkTitle`. > > `SetUpConsole` only calls `GetSettingsFromLink` if it is not in ConPTY mode. > > Effectively, it is ignoring the *whole* lnk (like it is supposed to), but in so doing it is also ignoring the link filename as the title
claunia commented 2026-01-31 05:25:53 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Feb 25, 2022):

This suggests that it can be fixed in OpenConsole.exe during bringup, but I am not sure how.

We should actually try to propagate both the EXE and LNK paths to Terminal in the future, but FOR TODAY it is not necessary for Terminal to know about the LNK.

@DHowett commented on GitHub (Feb 25, 2022): This suggests that it can be fixed in OpenConsole.exe during bringup, but I am not sure how. We should actually try to propagate both the EXE _and LNK_ paths to Terminal in the future, but FOR TODAY it is not necessary for Terminal to know about the LNK.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-DefApp Area-UserInterface Issue-Bug Priority-2 Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#16876
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?