starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Make sure caption controls "dim out" when window loses NC focus (WM_NCACTIVATE?) #16941

New Issue
Closed
opened 2026-01-31 05:27:55 +00:00 by claunia · 10 comments
claunia commented 2026-01-31 05:27:55 +00:00
Owner
Copy Link

Originally created by @Poopooracoocoo on GitHub (Mar 6, 2022).

Windows Terminal version

1.13.10395.0

Windows build number

10.0.19044

Other Software

No response

Steps to reproduce

  1. Open Windows Terminal
  2. Click outside of window to lose focus and make the window inactive

Expected Behavior

Current tab would go grey
Caption buttons would go grey

Actual Behavior

Neither titlebar element go grey

Originally created by @Poopooracoocoo on GitHub (Mar 6, 2022). ### Windows Terminal version 1.13.10395.0 ### Windows build number 10.0.19044 ### Other Software _No response_ ### Steps to reproduce 1. Open Windows Terminal 2. Click outside of window to lose focus and make the window inactive ### Expected Behavior Current tab would go grey Caption buttons would go grey ### Actual Behavior Neither titlebar element go grey
claunia commented 2026-01-31 05:27:57 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Mar 7, 2022):

Generally, I've been duping these to #4862. However, I totally missed the one other checkbox in #1625 about the caption button colors, so I'm gonna re-purpose this issue to track that element. Thanks!

Note

Walkthrough

To do this, we'd need to:

  • Listen for a WM_NCACTIVATE in IslandWindow
  • Plumb that as an event up to AppHost
  • Call a new method on AppLogic, which plumbs that down to TerminalPage to tell them that the window was activated/inactivated
  • in TerminalPage, when _settings.GlobalSettings().ShowTabsInTitlebar() is true, call to MinMaxCloseControl in TitlebarControl to tell it the window is no longer active
  • There, change the color of the buttons when the window is activated/deactivated.

See also #10401, which never got finished.

@zadjii-msft commented on GitHub (Mar 7, 2022): Generally, I've been duping these to #4862. However, I totally missed the one other checkbox in #1625 about the caption button colors, so I'm gonna re-purpose this issue to track that element. Thanks! > **Note** > ## Walkthrough To do this, we'd need to: * Listen for a `WM_NCACTIVATE` in `IslandWindow` * Plumb that as an event up to `AppHost` * Call a new method on `AppLogic`, which plumbs that down to `TerminalPage` to tell them that the window was activated/inactivated * in `TerminalPage`, when `_settings.GlobalSettings().ShowTabsInTitlebar()` is true, call to `MinMaxCloseControl` in `TitlebarControl` to tell it the window is no longer active * There, change the color of the buttons when the window is activated/deactivated. See also #10401, which never got finished.
claunia commented 2026-01-31 05:27:57 +00:00
Author
Owner
Copy Link

@Poopooracoocoo commented on GitHub (Sep 14, 2022):

I'm psyched to see that #4862 was implemented. Is this still being worked on?

@Poopooracoocoo commented on GitHub (Sep 14, 2022): I'm psyched to see that #4862 was implemented. Is this still being worked on?
claunia commented 2026-01-31 05:27:58 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Sep 14, 2022):

Is this still being worked on?

Not currently, but it seems fairly trivial these days. The plumbing in #4862 should make it trivial.

proposed "schema":

captionButtons: {
  foreground: ThemeColor,
  background: ThemeColor (default: #00000000),
  unfocusedForeground: ThemeColor,
  unfocusedBackground: ThemeColor (default: #00000000),
}

I don't really think we need to have separate knobs for each of the buttons.

@zadjii-msft commented on GitHub (Sep 14, 2022): > Is this still being worked on? Not currently, but it seems fairly trivial these days. The plumbing in #4862 should make it trivial. proposed "schema": ```js captionButtons: { foreground: ThemeColor, background: ThemeColor (default: #00000000), unfocusedForeground: ThemeColor, unfocusedBackground: ThemeColor (default: #00000000), } ``` I don't really think we need to have separate knobs for each of the buttons.
claunia commented 2026-01-31 05:27:58 +00:00
Author
Owner
Copy Link

@jamespack commented on GitHub (Jul 10, 2023):

I may take a stab at this one if that is ok.

@jamespack commented on GitHub (Jul 10, 2023): I may take a stab at this one if that is ok.
claunia commented 2026-01-31 05:27:58 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jul 10, 2023):

@jamespack Go for it!

@zadjii-msft commented on GitHub (Jul 10, 2023): @jamespack Go for it!
claunia commented 2026-01-31 05:27:58 +00:00
Author
Owner
Copy Link

@techy4shri commented on GitHub (Dec 25, 2024):

is this issue still being worked on?

@techy4shri commented on GitHub (Dec 25, 2024): is this issue still being worked on?
claunia commented 2026-01-31 05:27:58 +00:00
Author
Owner
Copy Link

@jamespack commented on GitHub (Dec 25, 2024):

I actually never started. Missed Mikes go ahead. @techy4shri if you are interested go at it 👍🏻 If I can find some free time I may still take a look though its not high on my wish list. Terminal as is today pretty much checks all my boxes 💯 🥇

@jamespack commented on GitHub (Dec 25, 2024): I actually never started. Missed Mikes go ahead. @techy4shri if you are interested go at it 👍🏻 If I can find some free time I may still take a look though its not high on my wish list. Terminal as is today pretty much checks all my boxes 💯 🥇
claunia commented 2026-01-31 05:27:58 +00:00
Author
Owner
Copy Link

@techy4shri commented on GitHub (Dec 25, 2024):

hmm it does, thanks @jamespack ! @zadjii-msft let me know if there's anything else I should know about :)

@techy4shri commented on GitHub (Dec 25, 2024): hmm it does, thanks @jamespack ! @zadjii-msft let me know if there's anything else I should know about :)
claunia commented 2026-01-31 05:27:59 +00:00
Author
Owner
Copy Link

@Abhii242004 commented on GitHub (Nov 8, 2025):

If this issue still not been resolved then I would like to work on it if you can assign it to me.

@Abhii242004 commented on GitHub (Nov 8, 2025): If this issue still not been resolved then I would like to work on it if you can assign it to me.
claunia commented 2026-01-31 05:27:59 +00:00
Author
Owner
Copy Link

@jamespack commented on GitHub (Nov 8, 2025):

If this issue still not been resolved then I would like to work on it if you can assign it to me.

@Abhii242004 they generally don't assign stuff. If it's still open it's up for grabs.

@jamespack commented on GitHub (Nov 8, 2025): > If this issue still not been resolved then I would like to work on it if you can assign it to me. @Abhii242004 they generally don't assign stuff. If it's still open it's up for grabs.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Theming Area-UserInterface good first issue Help Wanted In-PR Issue-Bug Needs-Tag-Fix Priority-3 Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#16941
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?