starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Trailing commas in profiles schema #16946

New Issue
Closed
opened 2026-01-31 05:28:07 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 05:28:07 +00:00
Owner
Copy Link

Originally created by @aeschli on GitHub (Mar 8, 2022).

Windows Terminal version

1.11.3471.0

Windows build number

10.0.19044.1526]

Other Software

VIsual Studio Code 1.64.2

Steps to reproduce

  • Open the Windows Terminal Setting
  • Click on Open JSON File
  • Opens in VS Code with an error on the schema:

Unable to parse content from 'https://aka.ms/terminal-profiles-schema': Parse error at offset 14830

The problem is
https://github.com/microsoft/terminal/blob/main/doc%2Fcascadia%2Fprofiles.schema.json#L488
See the trailing comma.

Schema file are JSON and trailing commas are a syntax error.

Expected Behavior

No error when opening in VS Code

Actual Behavior

The error comes from trailing commas in the schema file: f217f6dc33/doc/cascadia/profiles.schema.json (L488)

Also:

Originally created by @aeschli on GitHub (Mar 8, 2022). ### Windows Terminal version 1.11.3471.0 ### Windows build number 10.0.19044.1526] ### Other Software VIsual Studio Code 1.64.2 ### Steps to reproduce - Open the Windows Terminal Setting - Click on `Open JSON File` - Opens in VS Code with an error on the schema: `Unable to parse content from 'https://aka.ms/terminal-profiles-schema': Parse error at offset 14830` The problem is https://github.com/microsoft/terminal/blob/main/doc%2Fcascadia%2Fprofiles.schema.json#L488 See the trailing comma. Schema file are JSON and trailing commas are a syntax error. ### Expected Behavior No error when opening in VS Code ### Actual Behavior The error comes from trailing commas in the schema file: https://github.com/microsoft/terminal/blob/f217f6dc331559f57301dfb84ce3898d20c944d6/doc/cascadia/profiles.schema.json#L488 Also: - https://github.com/microsoft/terminal/blob/f217f6dc331559f57301dfb84ce3898d20c944d6/doc/cascadia/profiles.schema.json#L864 - https://github.com/microsoft/terminal/blob/f217f6dc331559f57301dfb84ce3898d20c944d6/doc/cascadia/profiles.schema.json#L884 - https://github.com/microsoft/terminal/blob/f217f6dc331559f57301dfb84ce3898d20c944d6/doc/cascadia/profiles.schema.json#L904
claunia commented 2026-01-31 05:28:09 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Mar 8, 2022):

Well, that wouldn't be hard to fix. Thanks for pointing that out!

@zadjii-msft commented on GitHub (Mar 8, 2022): Well, that wouldn't be hard to fix. Thanks for pointing that out!
claunia commented 2026-01-31 05:28:09 +00:00
Author
Owner
Copy Link

@marceljsh commented on GitHub (Mar 8, 2022):

hi i have the same problem but when i remove the comma, an error occurs and it expected a comma. how do I fix this?
image

@marceljsh commented on GitHub (Mar 8, 2022): hi i have the same problem but when i remove the comma, an error occurs and it expected a comma. how do I fix this? ![image](https://user-images.githubusercontent.com/70991948/157300525-ccdf3139-7e8d-43e6-8d13-f34f9aeec5e9.png)
claunia commented 2026-01-31 05:28:09 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Mar 8, 2022):

.... how did you remove the comma? That $schema line is telling VsCode to load the schema from a URL (which I think points at this repo). Removing the comma locally isn't going to fix the error itself, you'd have to try and change the $schema line to point at your local copy of the file.

@zadjii-msft commented on GitHub (Mar 8, 2022): .... how did you remove the comma? That `$schema` line is telling VsCode to load the schema from a URL (which I think points at this repo). Removing the comma locally isn't going to fix the error itself, you'd have to try and change the `$schema` line to point at your local copy of the file.
claunia commented 2026-01-31 05:28:10 +00:00
Author
Owner
Copy Link

@marceljsh commented on GitHub (Mar 10, 2022):

I'm sorry but I'm new in this thing and I still don't understand how do I fix the problem.
I have copied the raw text from "https://aka.ms/terminal-profiles-schema" and save it to a new local json file. Then I redirect the $schema to my new json file and I remain can't parse the file. How do I fix this?

@marceljsh commented on GitHub (Mar 10, 2022): I'm sorry but I'm new in this thing and I still don't understand how do I fix the problem. I have copied the raw text from "https://aka.ms/terminal-profiles-schema" and save it to a new local json file. Then I redirect the $schema to my new json file and I remain can't parse the file. How do I fix this?
claunia commented 2026-01-31 05:28:10 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Apr 19, 2022):

:tada:This issue was addressed in #12644, which has now been successfully released as Windows Terminal Preview v1.13.1098.🎉

Handy links:

@ghost commented on GitHub (Apr 19, 2022): :tada:This issue was addressed in #12644, which has now been successfully released as `Windows Terminal Preview v1.13.1098`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.13.1098) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Schema good first issue Help Wanted Issue-Bug Needs-Tag-Fix Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#16946
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?