Shaders load but don&#39;t work #16965

@lhecker commented on GitHub (Mar 10, 2022):

@UltraStudioLTD Did you set your antialiasingMode to cleartype? If so: That doesn't seem to work at the moment.
Otherwise, could you update or post your settings.json?

@lhecker commented on GitHub (Mar 10, 2022): @UltraStudioLTD Did you set your `antialiasingMode` to `cleartype`? If so: That doesn't seem to work at the moment. Otherwise, could you update or post your settings.json?

claunia commented

@USLTD commented on GitHub (Mar 10, 2022):

@lhecker It didn't work. I updated setting.json file posted to match currently used.

@USLTD commented on GitHub (Mar 10, 2022): @lhecker It didn't work. I updated **setting.json** file posted to match currently used.

claunia commented

@lhecker commented on GitHub (Mar 10, 2022):

@UltraStudioLTD You have "antialiasingMode": "cleartype", in your settings. Remove that line and it will work. 🙂

@lhecker commented on GitHub (Mar 10, 2022): @UltraStudioLTD You have `"antialiasingMode": "cleartype",` in your settings. Remove that line and it will work. 🙂

claunia commented

@USLTD commented on GitHub (Mar 10, 2022):

@lhecker It didn't work.

@USLTD commented on GitHub (Mar 10, 2022): @lhecker It didn't work.

claunia commented

@USLTD commented on GitHub (Mar 10, 2022):

By the way here is C:\TMP\test.hlsl file

// A minimal pixel shader that shows some raster bars

// The terminal graphics as a texture
Texture2D shaderTexture;
SamplerState samplerState;

// Terminal settings such as the resolution of the texture
cbuffer PixelShaderSettings {
  // The number of seconds since the pixel shader was enabled
  float  Time;
  // UI Scale
  float  Scale;
  // Resolution of the shaderTexture
  float2 Resolution;
  // Background color as rgba
  float4 Background;
};

// A pixel shader is a program that given a texture coordinate (tex) produces a color.
// tex is an x,y tuple that ranges from 0,0 (top left) to 1,1 (bottom right).
// Just ignore the pos parameter.
float4 main(float4 pos : SV_POSITION, float2 tex : TEXCOORD) : SV_TARGET
{
    // Read the color value at the current texture coordinate (tex)
    //  float4 is tuple of 4 floats, rgba
    float4 color = shaderTexture.Sample(samplerState, tex);

    // Read the color value at some offset, will be used as shadow
    float4 ocolor = shaderTexture.Sample(samplerState, tex+2.0*Scale*float2(-1.0, -1.0)/Resolution.y);

    // Thickness of raster
    const float thickness = 0.1;

    float ny = floor(tex.y/thickness);
    float my = tex.y%thickness;
    const float pi = 3.141592654;


    // ny is used to compute the rasterbar base color
    float cola = ny*2.0*pi;
    float3 col = 0.75+0.25*float3(sin(cola*0.111), sin(cola*0.222), sin(cola*0.333));

    // my is used to compute the rasterbar brightness
    //  smoothstep is a great little function: https://en.wikipedia.org/wiki/Smoothstep
    float brightness = 1.0-smoothstep(0.0, thickness*0.5, abs(my - 0.5*thickness));

    float3 rasterColor = col*brightness;

    // lerp(x, y, a) is another very useful function: https://en.wikipedia.org/wiki/Linear_interpolation
    float3 final = rasterColor;
    // Create the drop shadow of the terminal graphics
    //  .w is the alpha channel, 0 is fully transparent and 1 is fully opaque
    final = lerp(final, float(0.0), ocolor.w);
    // Draw the terminal graphics
    final = lerp(final, color.xyz, color.w);

    // Return the final color, set alpha to 1 (ie opaque)
    return float4(final, 1.0);
}

@USLTD commented on GitHub (Mar 10, 2022): By the way here is **C:\TMP\test.hlsl** file ```hlsl // A minimal pixel shader that shows some raster bars // The terminal graphics as a texture Texture2D shaderTexture; SamplerState samplerState; // Terminal settings such as the resolution of the texture cbuffer PixelShaderSettings { // The number of seconds since the pixel shader was enabled float Time; // UI Scale float Scale; // Resolution of the shaderTexture float2 Resolution; // Background color as rgba float4 Background; }; // A pixel shader is a program that given a texture coordinate (tex) produces a color. // tex is an x,y tuple that ranges from 0,0 (top left) to 1,1 (bottom right). // Just ignore the pos parameter. float4 main(float4 pos : SV_POSITION, float2 tex : TEXCOORD) : SV_TARGET { // Read the color value at the current texture coordinate (tex) // float4 is tuple of 4 floats, rgba float4 color = shaderTexture.Sample(samplerState, tex); // Read the color value at some offset, will be used as shadow float4 ocolor = shaderTexture.Sample(samplerState, tex+2.0*Scale*float2(-1.0, -1.0)/Resolution.y); // Thickness of raster const float thickness = 0.1; float ny = floor(tex.y/thickness); float my = tex.y%thickness; const float pi = 3.141592654; // ny is used to compute the rasterbar base color float cola = ny*2.0*pi; float3 col = 0.75+0.25*float3(sin(cola*0.111), sin(cola*0.222), sin(cola*0.333)); // my is used to compute the rasterbar brightness // smoothstep is a great little function: https://en.wikipedia.org/wiki/Smoothstep float brightness = 1.0-smoothstep(0.0, thickness*0.5, abs(my - 0.5*thickness)); float3 rasterColor = col*brightness; // lerp(x, y, a) is another very useful function: https://en.wikipedia.org/wiki/Linear_interpolation float3 final = rasterColor; // Create the drop shadow of the terminal graphics // .w is the alpha channel, 0 is fully transparent and 1 is fully opaque final = lerp(final, float(0.0), ocolor.w); // Draw the terminal graphics final = lerp(final, color.xyz, color.w); // Return the final color, set alpha to 1 (ie opaque) return float4(final, 1.0); } ```

claunia commented

@lhecker commented on GitHub (Mar 10, 2022):

Are you 100% sure? 😅

You did reload the tab after disabling AtlasEngine / the experimental text renderer right?

@lhecker commented on GitHub (Mar 10, 2022): Are you 100% sure? 😅 ![image](https://user-images.githubusercontent.com/2256941/157720263-2539b2f3-395f-4d7a-93c5-52f4f852d4ba.png) You did reload the tab after disabling AtlasEngine / the experimental text renderer right?

claunia commented

@USLTD commented on GitHub (Mar 10, 2022):

I even reopened it

@USLTD commented on GitHub (Mar 10, 2022): I even reopened it

claunia commented

@USLTD commented on GitHub (Mar 10, 2022):

What's your settings,json?

@USLTD commented on GitHub (Mar 10, 2022): What's your **settings,json**?

claunia commented

@USLTD commented on GitHub (Mar 10, 2022):

Oh and I am using Preview version by the way

@USLTD commented on GitHub (Mar 10, 2022): Oh and I am using Preview version by the way

claunia commented

@lhecker commented on GitHub (Mar 10, 2022):

What's your settings,json?

I'm using your settings.json and the same Windows Terminal version (1.13.10336.0).

@lhecker commented on GitHub (Mar 10, 2022): > What's your settings,json? I'm using your settings.json and the same Windows Terminal version (1.13.10336.0).

claunia commented

@USLTD commented on GitHub (Mar 11, 2022):

I solved issue by switching to Software Rendering instead of Hardware Rendering

@USLTD commented on GitHub (Mar 11, 2022): I solved issue by switching to **Software Rendering** instead of **Hardware Rendering**

claunia commented

@lhecker commented on GitHub (Mar 11, 2022):

I solved issue by switching to Software Rendering instead of Hardware Rendering

This is interesting actually. Can you tell us more about the hardware you use? What's your CPU and GPU? Do you use Windows Terminal via a Virtual Machine, Remote Desktop, or some other mechanism?
This shouldn't happen and we should try and fix your issue. 🙂

If you have the time and would like to investigate (really just in case), could you enable hardware rendering again and download DebugView and see if any logs come up when you start Windows Terminal ("WT")? If you go into your start menu and search for dxcpl.exe you can find a tool that can enable DirectX debugging for WT. Here's how to use it:

If you're done debugging, don't forget to "Clear" the "Executable List". You need to click "Apply" (or "OK") in the primary window in order for the change to take effect.

All of that is just in case you have the time and interest in investigating this of course. 🙂

@lhecker commented on GitHub (Mar 11, 2022): > I solved issue by switching to Software Rendering instead of Hardware Rendering This is interesting actually. Can you tell us more about the hardware you use? What's your CPU and GPU? Do you use Windows Terminal via a Virtual Machine, Remote Desktop, or some other mechanism? This shouldn't happen and we should try and fix your issue. 🙂 If you have the time and would like to investigate (really just in case), could you enable hardware rendering again and download [DebugView](https://docs.microsoft.com/en-us/sysinternals/downloads/debugview) and see if any logs come up when you start Windows Terminal ("WT")? If you go into your start menu and search for `dxcpl.exe` you can find a tool that can enable DirectX debugging for WT. Here's how to use it: ![image](https://user-images.githubusercontent.com/2256941/157915837-ff7027d5-483a-4b0f-a8fc-a21b65c8187c.png) If you're done debugging, don't forget to "Clear" the "Executable List". You need to click "Apply" (or "OK") in the primary window in order for the change to take effect. All of that is just in case you have the time and interest in investigating this of course. 🙂

claunia commented

@USLTD commented on GitHub (Mar 11, 2022):

@lhecker I will upload details later when I will have time. For now I will enjoy CRT shader that I always wanted (since cool-retro-term)
Edit: CRT shader is super slow due Software Rendering 😭. Only option is Retro

@USLTD commented on GitHub (Mar 11, 2022): @lhecker I will upload details later when I will have time. For now I will enjoy CRT shader that I always wanted (since **cool-retro-term**) Edit: **CRT** shader is super slow due **Software Rendering** 😭. Only option is **Retro**

claunia commented

WTPreviewHardwareRendering.LOG

@USLTD commented on GitHub (Mar 11, 2022):

@lhecker
OK, here are the details:

My CPU is Intel® Core™2 Duo CPU E6750 @ 2.66GHz
My GPU is NVIDIA GeForce 8600 GT or Alternative Technical Specifications (UnOfficial)
I don't use Windows Terminal via any remote or virtual means.

@USLTD commented on GitHub (Mar 11, 2022): @lhecker OK, here are the details: - My **CPU** is [**Intel® Core™2 Duo CPU E6750 @ 2.66GHz**](https://www.intel.com/content/www/us/en/products/sku/30784/intel-core2-duo-processor-e6750-4m-cache-2-66-ghz-1333-mhz-fsb/specifications.html) - My **GPU** is [**NVIDIA GeForce 8600 GT**](https://www.nvidia.com/en-us/drivers/geforce-8600-8500-tech-specs) or [**Alternative Technical Specifications (UnOfficial)**](https://www.techpowerup.com/gpu-specs/geforce-8600-gt.c198) - I don't use Windows Terminal via any remote or virtual means. [WTPreviewHardwareRendering.LOG](https://github.com/microsoft/terminal/files/8234892/WTPreviewHardwareRendering.LOG)

claunia commented

@USLTD commented on GitHub (Mar 11, 2022):

And as I mentioned HLSL rendering works only with Software Rendering with both Preview and Stable versions

@USLTD commented on GitHub (Mar 11, 2022): And as I mentioned **HLSL** rendering works only with **Software Rendering** with both **Preview** and **Stable** versions

claunia commented

@lhecker commented on GitHub (Mar 11, 2022):

Found it:

00000232	1.32877946	[8336] D3D11 ERROR: ID3D11Device::CreateVertexShader: Shader must be vs_4_0. Shader version provided: vs_5_0 [ STATE_CREATION ERROR #167: CREATEVERTEXSHADER_INVALIDSHADERTYPE]

Your GPU only supports feature level 10.0 for DirectX, which only apparently supports HLSL 4.0.

@lhecker commented on GitHub (Mar 11, 2022): Found it: ``` 00000232 1.32877946 [8336] D3D11 ERROR: ID3D11Device::CreateVertexShader: Shader must be vs_4_0. Shader version provided: vs_5_0 [ STATE_CREATION ERROR #167: CREATEVERTEXSHADER_INVALIDSHADERTYPE] ``` Your GPU only supports feature level 10.0 for DirectX, which only apparently supports HLSL 4.0.

claunia commented