starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Terminal editor keeps running even when closed #17027

New Issue
Closed
opened 2026-01-31 05:30:15 +00:00 by claunia · 4 comments
claunia commented 2026-01-31 05:30:15 +00:00
Owner
Copy Link

Originally created by @zuixalias on GitHub (Mar 17, 2022).

Windows Terminal version

1.12.10393.0

Windows build number

10.0.22000.556

Other Software

Helix 0.6.0 [Download from Github]

Steps to reproduce

Shown in video
Video showing the issue : wt_issue.mp4

Expected Behavior

[Everything shown in video]
'hx.exe' (helix) should close when terminal is closed

Actual Behavior

[Everything shown in video]

  • 'hx.exe' keeps running in background after terminal is closed
  • Happens only with helix, 'nvim.exe' (neovim) runs in background just like 'hx.exe' but it closes with terminal (then maybe a helix issue? Idk...)
Originally created by @zuixalias on GitHub (Mar 17, 2022). ### Windows Terminal version 1.12.10393.0 ### Windows build number 10.0.22000.556 ### Other Software Helix 0.6.0 [[Download from Github](https://github.com/helix-editor/helix/releases/tag/v0.6.0)] ### Steps to reproduce Shown in video Video showing the issue : [wt_issue.mp4](https://mega.nz/file/Q4liUTCD#Qyk-s5Oba0swJWuJmrLO6hdQvQpfjlvrPd5AoJOBgOU) ### Expected Behavior [Everything shown in video] 'hx.exe' (helix) should close when terminal is closed ### Actual Behavior [Everything shown in video] - 'hx.exe' keeps running in background after terminal is closed - Happens only with helix, 'nvim.exe' (neovim) runs in background just like 'hx.exe' but it closes with terminal (then maybe a helix issue? Idk...)
claunia commented 2026-01-31 05:30:17 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Mar 17, 2022):

Huh, so when helix is started into a defterm connection, it doesn't close when the console does. Weird. Couldn't get this to repro with like cmd.exe or python, just as a simple test, so nothing to raise the alarm bells over, but still not good.

Happens only with helix, 'nvim.exe' (neovim) runs in background just like 'hx.exe' but it closes with terminal (then maybe a helix issue? Idk...)

That's an interesting observation indeed. For something like that I'd usually point at Helix as the root cause of the issue, but we can take a look.

Maybe helix is like, leaking a handle to the console somehow such that it doesn't tear down the console as well. There's probably a conhost.exe that leaks each time as well. Hopefully, there isn't also an openconsole.exe that leaks with it.

@zadjii-msft commented on GitHub (Mar 17, 2022): Huh, so when helix is started into a defterm connection, it doesn't close when the console does. Weird. Couldn't get this to repro with like cmd.exe or python, just as a simple test, so nothing to raise the alarm bells over, but still not good. > Happens only with helix, 'nvim.exe' (neovim) runs in background just like 'hx.exe' but it closes with terminal (then maybe a helix issue? Idk...) That's an interesting observation indeed. For something like that I'd usually point at Helix as the root cause of the issue, but we can take a look. Maybe helix is like, leaking a handle to the console somehow such that it doesn't tear down the console as well. There's probably a conhost.exe that leaks each time as well. Hopefully, there isn't _also_ an openconsole.exe that leaks with it.
claunia commented 2026-01-31 05:30:17 +00:00
Author
Owner
Copy Link

@zuixalias commented on GitHub (Mar 17, 2022):

Okay, actually it's working fine with other files. Just checked the logs and turns out that the issue is related to rust-analyzer being run when .rs files are opened and helix doing something with it...something is happening and something closes in between or something like that, i am not sure...

So i am guessing the issue is on helix's side...with open an issue there.

@zuixalias commented on GitHub (Mar 17, 2022): Okay, actually it's working fine with other files. Just checked the logs and turns out that the issue is related to `rust-analyzer` being run when .rs files are opened and helix doing something with it...something is happening and something closes in between or something like that, i am not sure... So i am guessing the issue is on helix's side...with open an issue there.
claunia commented 2026-01-31 05:30:17 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Mar 18, 2022):

Well cool, thanks for following up!

/dup https://github.com/helix-editor/helix/issues/1828

@zadjii-msft commented on GitHub (Mar 18, 2022): Well cool, thanks for following up! /dup https://github.com/helix-editor/helix/issues/1828
claunia commented 2026-01-31 05:30:17 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Mar 18, 2022):

Hi! We've identified this issue as a duplicate of one that exists on somebody else's Issue Tracker. Please make sure you subscribe to the referenced external issue for future updates. Thanks for your report!

@ghost commented on GitHub (Mar 18, 2022): Hi! We've identified this issue as a duplicate of one that exists on somebody else's Issue Tracker. Please make sure you subscribe to the referenced external issue for future updates. Thanks for your report!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-DefApp Help Wanted Issue-Bug Needs-Tag-Fix Priority-2 Product-Terminal Resolution-External
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#17027
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?