starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Cursor droppings are back in conhost #17053

New Issue
Closed
opened 2026-01-31 05:30:54 +00:00 by claunia · 6 comments
claunia commented 2026-01-31 05:30:54 +00:00
Owner
Copy Link

Originally created by @j4james on GitHub (Mar 22, 2022).

Originally assigned to: @lhecker on GitHub.

Windows Terminal version

OpenConsole 8a34a0e59a

Windows build number

10.0.19041.1415

Other Software

No response

Steps to reproduce

  1. You must be using a somewhat recent version of OpenConsole.
  2. Open a WSL bash shell.
  3. Execute the following: printf "\e[2 q\e[9999C "; sleep 1

The CSI 2 q is to get a non-blinking cursor which makes the issue easier to produce. The CSI 9999C moves the cursor to the end of the line, and the space initiates a delayed wrap. The sleep then gives the cursor a chance to be rendered before the next output will trigger the actual wrap.

Expected Behavior

The output should wrap to the next line without leaving a visible cursor block behind.

Actual Behavior

The cursor at the end of the line isn't cleared when the output wraps, so you end up with two cursors visible on the screen.

image

This doesn't occur in my inbox version of conhost, so I think it might be a regression.

Originally created by @j4james on GitHub (Mar 22, 2022). Originally assigned to: @lhecker on GitHub. ### Windows Terminal version OpenConsole 8a34a0e59ac41bc805c308fb82bc7683e583d45d ### Windows build number 10.0.19041.1415 ### Other Software _No response_ ### Steps to reproduce 1. You must be using a somewhat recent version of OpenConsole. 2. Open a WSL bash shell. 3. Execute the following: `printf "\e[2 q\e[9999C "; sleep 1` The `CSI 2 q` is to get a non-blinking cursor which makes the issue easier to produce. The `CSI 9999C` moves the cursor to the end of the line, and the space initiates a delayed wrap. The sleep then gives the cursor a chance to be rendered before the next output will trigger the actual wrap. ### Expected Behavior The output should wrap to the next line without leaving a visible cursor block behind. ### Actual Behavior The cursor at the end of the line isn't cleared when the output wraps, so you end up with two cursors visible on the screen. ![image](https://user-images.githubusercontent.com/4181424/159455638-1195fc5b-bea1-4e0f-8820-75bfd8d10318.png) This doesn't occur in my inbox version of conhost, so I think it might be a regression.
claunia commented 2026-01-31 05:30:56 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Mar 22, 2022):

DROP EVERYTHING, THEY'RE BACK.

Thanks for noticing! Definitely can't let these back into the world 😝

@zadjii-msft commented on GitHub (Mar 22, 2022): DROP EVERYTHING, THEY'RE BACK. Thanks for noticing! Definitely can't let these back into the world 😝
claunia commented 2026-01-31 05:30:56 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Mar 22, 2022):

I think this was broken by the deferred cursor drawing introduced in PR #10394. I can fix it by removing the StartDeferDrawing and EndDeferDrawing here:

f936c4443d/src/host/outputStream.cpp (L45-L55)

But then we lose the performance improvements we were getting from the PR. Hopefully there's a way to fix it without undoing that completely.

@j4james commented on GitHub (Mar 22, 2022): I think this was broken by the deferred cursor drawing introduced in PR #10394. I can fix it by removing the `StartDeferDrawing` and `EndDeferDrawing` here: https://github.com/microsoft/terminal/blob/f936c4443d4b7b11da32077b0dc0a9aa8652bc77/src/host/outputStream.cpp#L45-L55 But then we lose the performance improvements we were getting from the PR. Hopefully there's a way to fix it without undoing that completely.
claunia commented 2026-01-31 05:30:56 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Mar 22, 2022):

I've got a possible solution that doesn't require undoing the deferred drawing. We save the current cursor position in StartDeferDrawing, and then trigger a redraw for both the old and new positions in EndDeferDrawing (assuming the position has changed).

Hopefully the overhead of that additional maintenance doesn't outweigh the benefits we're getting from the deferred drawing, but I'm not the best person to evaluate the performance issues here. I'm also not positive this is going to work in all scenarios - need to play around with it some more.

@j4james commented on GitHub (Mar 22, 2022): I've got a possible solution that doesn't require undoing the deferred drawing. We save the current cursor position in `StartDeferDrawing`, and then trigger a redraw for both the old and new positions in `EndDeferDrawing` (assuming the position has changed). Hopefully the overhead of that additional maintenance doesn't outweigh the benefits we're getting from the deferred drawing, but I'm not the best person to evaluate the performance issues here. I'm also not positive this is going to work in all scenarios - need to play around with it some more.
claunia commented 2026-01-31 05:30:56 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Apr 29, 2022):

Fixing #12917 doesn't magically fix this 😢

Note: only repros when you're above the bottom of the viewport, so the view doesn't scroll

@zadjii-msft commented on GitHub (Apr 29, 2022): Fixing #12917 doesn't magically fix this 😢 Note: only repros when you're above the bottom of the viewport, so the view doesn't scroll
claunia commented 2026-01-31 05:30:57 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Dec 5, 2022):

Might get fixed by snapshots

@zadjii-msft commented on GitHub (Dec 5, 2022): Might get fixed by snapshots
claunia commented 2026-01-31 05:30:57 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jan 24, 2023):

:tada:This issue was addressed in #14640, which has now been successfully released as Windows Terminal Preview v1.17.1023.🎉

Handy links:

@ghost commented on GitHub (Jan 24, 2023): :tada:This issue was addressed in #14640, which has now been successfully released as `Windows Terminal Preview v1.17.1023`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.17.1023) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Rendering Issue-Bug Priority-2 Product-Conhost Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#17053
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?