starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Microsoft.Terminal.Settings.ModelLib.vcxproj fails to build due to missing $quote; in <Exec Command= ...> #17062

New Issue
Open
opened 2026-01-31 05:31:11 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 05:31:11 +00:00
Owner
Copy Link

Originally created by @RonWright on GitHub (Mar 24, 2022).

Windows Terminal version

No response

Windows build number

No response

Other Software

VisualStudio 2022.

Steps to reproduce

Microsoft.Terminal.Settings.ModelLib.vcxproj fails to build when the source directory path contains spaces (as in "P:\GitHub Projects...").
Microsoft.Terminal.Settings.ModelLib.vcxproj has three <Exec Command=pwsh.exe ...> nodes which do not have double-quotes (") around the file spec for the GenerateHeaderForJson.ps1 file. Without the double-quotes the execution of pwsh.exe fails.

Expected Behavior

Modify the section of Microsoft.Terminal.Settings.ModelLib.vcxproj containing the Commands to be executed. Following is the changed section:

Changes.txt

Actual Behavior

Without the additional "'s in the project file, the Microsoft.Terminal.Settings.ModelLib project fails to build.

Originally created by @RonWright on GitHub (Mar 24, 2022). ### Windows Terminal version _No response_ ### Windows build number _No response_ ### Other Software VisualStudio 2022. ### Steps to reproduce Microsoft.Terminal.Settings.ModelLib.vcxproj fails to build when the source directory path contains spaces (as in "P:\GitHub Projects\..."). Microsoft.Terminal.Settings.ModelLib.vcxproj has three <Exec Command=pwsh.exe ...> nodes which do not have double-quotes (&quot;) around the file spec for the GenerateHeaderForJson.ps1 file. Without the double-quotes the execution of pwsh.exe fails. ### Expected Behavior Modify the section of Microsoft.Terminal.Settings.ModelLib.vcxproj containing the Commands to be executed. Following is the changed section: <!-- This target will take our defaults.json and stamp it into a .h file that we can include in the code directly. This way, we don't need to worry about failing to load the default settings at runtime. --> <Target Name="_TerminalAppGenerateDefaultsH" Inputs="defaults.json" Outputs="Generated Files\defaults.h" BeforeTargets="BeforeClCompile"> <Exec Command="pwsh.exe -NoProfile –ExecutionPolicy Unrestricted &quot;$(OpenConsoleDir)\tools\GenerateHeaderForJson.ps1&quot; -JsonFile defaults.json -OutPath &quot;Generated Files\defaults.h&quot; -VariableName DefaultJson" /> </Target> <!-- A different set of defaults for Universal variant --> <Target Name="_TerminalAppGenerateDefaultsUniversalH" Inputs="defaults-universal.json" Outputs="Generated Files\defaults-universal.h" BeforeTargets="BeforeClCompile"> <Exec Command="pwsh.exe -NoProfile –ExecutionPolicy Unrestricted &quot;$(OpenConsoleDir)\tools\GenerateHeaderForJson.ps1&quot; -JsonFile defaults-universal.json -OutPath &quot;Generated Files\defaults-universal.h&quot; -VariableName DefaultUniversalJson" /> </Target> <!-- Same as above, but for the default settings.json template --> <Target Name="_TerminalAppGenerateUserSettingsH" Inputs="userDefaults.json" Outputs="Generated Files\userDefaults.h" BeforeTargets="BeforeClCompile"> <Exec Command="pwsh.exe -NoProfile –ExecutionPolicy Unrestricted &quot;$(OpenConsoleDir)\tools\GenerateHeaderForJson.ps1&quot; -JsonFile userDefaults.json -OutPath &quot;Generated Files\userDefaults.h&quot; -VariableName UserSettingsJson" /> </Target> [Changes.txt](https://github.com/microsoft/terminal/files/8338413/Changes.txt) ### Actual Behavior Without the additional &quot;'s in the project file, the Microsoft.Terminal.Settings.ModelLib project fails to build.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Build Area-CodeHealth good first issue Help Wanted Issue-Bug Product-Meta Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#17062
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?