Terminal crash on high unicode chars: out of range exception reading UnicodeStorage during UpdatePatternLocations #17170

Closed
opened 2026-01-31 05:34:12 +00:00 by claunia · 4 comments
Owner

Originally created by @DHowett on GitHub (Apr 6, 2022).

1.12.10908

Uncertain as to repro steps.

Watson failure hash 326e3a1b-889b-f24e-582d-0e18d3c853b4

<html>
Frame Name offset file line
0 KERNELBASE!RaiseException   0x000000000000006C       xcpt.c   936
1 VCRUNTIME140!_CxxThrowException   0x0000000000000090       throw.cpp   75
2 msvcp140!std::_Xout_of_range   0x0000000000000022       xthrow.cpp   25
3 Microsoft_Terminal_Control!CharRow::GetText   0x000000000004414C       CharRow.cpp   217
4 Microsoft_Terminal_Control!TextBuffer::GetPatterns   0x00000000000000C0       textBuffer.cpp   2665
5 Microsoft_Terminal_Control!Microsoft::Terminal::Core::Terminal::UpdatePatternsUnderLock   0x000000000000008E       Terminal.cpp   1255
6 Microsoft_Terminal_Control!winrt::Microsoft::Terminal::Control::implementation::ControlCore::UpdatePatternLocations   0x0000000000000044       ControlCore.cpp   494
</html>
Originally created by @DHowett on GitHub (Apr 6, 2022). 1.12.10908 Uncertain as to repro steps. Watson failure hash 326e3a1b-889b-f24e-582d-0e18d3c853b4 <html> <body> <!--StartFragment--> Frame | Name | | offset | | | | file || line -- | -- | -- | -- | -- | -- | -- | -- | -- | -- 0 | KERNELBASE!RaiseException |   | 0x000000000000006C |   |   |   | xcpt.c |   | 936 1 | VCRUNTIME140!_CxxThrowException |   | 0x0000000000000090 |   |   |   | throw.cpp |   | 75 2 | msvcp140!std::_Xout_of_range |   | 0x0000000000000022 |   |   |   | xthrow.cpp |   | 25 3 | Microsoft_Terminal_Control!CharRow::GetText |   | 0x000000000004414C |   |   |   | CharRow.cpp |   | 217 4 | Microsoft_Terminal_Control!TextBuffer::GetPatterns |   | 0x00000000000000C0 |   |   |   | textBuffer.cpp |   | 2665 5 | Microsoft_Terminal_Control!Microsoft::Terminal::Core::Terminal::UpdatePatternsUnderLock |   | 0x000000000000008E |   |   |   | Terminal.cpp |   | 1255 6 | Microsoft_Terminal_Control!winrt::Microsoft::Terminal::Control::implementation::ControlCore::UpdatePatternLocations |   | 0x0000000000000044 |   |   |   | ControlCore.cpp |   | 494 <!--EndFragment--> </body> </html>
Author
Owner

@zadjii-msft commented on GitHub (Apr 7, 2022):

IT'S SUPER BAD

@zadjii-msft commented on GitHub (Apr 7, 2022): IT'S SUPER BAD
Author
Owner

@zadjii-msft commented on GitHub (Apr 7, 2022):

Wait, this isn't the UnicodeStorage one

@zadjii-msft commented on GitHub (Apr 7, 2022): Wait, this _isn't_ the UnicodeStorage one
Author
Owner

@ghost commented on GitHub (Apr 19, 2022):

:tada:This issue was addressed in #12853, which has now been successfully released as Windows Terminal v1.12.1098.🎉

Handy links:

@ghost commented on GitHub (Apr 19, 2022): :tada:This issue was addressed in #12853, which has now been successfully released as `Windows Terminal v1.12.1098`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.12.1098) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Author
Owner

@ghost commented on GitHub (Apr 19, 2022):

:tada:This issue was addressed in #12853, which has now been successfully released as Windows Terminal Preview v1.13.1098.🎉

Handy links:

@ghost commented on GitHub (Apr 19, 2022): :tada:This issue was addressed in #12853, which has now been successfully released as `Windows Terminal Preview v1.13.1098`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.13.1098) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#17170