starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Ability to save selected text as a sendInput action #17185

New Issue
Closed
opened 2026-01-31 05:34:44 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 05:34:44 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Apr 8, 2022).

Originally assigned to: @shubhamvrs on GitHub.

I write some long command. I need to use this frequently (or infrequently), but I don't want to have to remember all the args. I want to be able to pull it up straight from the command palette. So I want to write the command once, select it, and {perform some action}1 that lets me save it as a sendInput action.

The action should

  • immediately save it.
  • provide a UI2 for immediately editing3 the name, contents of this action, because Send "git log --graph --abbrev-commit --decorate..." to the Terminal is not useful to anyone.

Just doing the immediate save would be a good enough start on this, to the point I'd consider that an easy starter. The UI - that's Hard, for reasons listed below.

Note

Walkthrough

As an initial version of this, it's more than good enough to just save the selected text as an action without the UI. We can iterate on the UI in follow-ups.

  • Probably start with something like dev/migrie/fhl/save-command
  • We probably want to skip all the AppCommandlineArgs stuff for now. That's spicier.
  • in TerminalPage::_HandleSaveTask, we will want to try and save the current selection as a sendInput action, if there's no commandline specified.
  • AppActionHandlers.cpp has plenty of examples of getting the active control. Should be easy enough to get the selected text from it.
  • We'll probably want to generate the name of this action (without a commandline) as "Save Task..."
  • Over and above: It would be valuable to Toast the user with a message "Saved selected text as a new action". TerminalPage::IdentifyWindow has an example of a Toast

  1. Obviously, easiest way is via cmdpal or keybinding. Also consider a right-click context menu entry, #3337 ↩︎

  2. This has it's own challenges. It can't be a ContentDialog (https://github.com/microsoft/microsoft-ui-xaml/issues/3804). It could be nested in a Flyout, maybe. Hopefully the dialog thing is limited just to ContentDialogs and not all Flyouts. It probably shouldn't be a TeachingTip (#12798). We could roll our own ContentDialog for this of course (#11308). ↩︎

  3. Might be tricky - we'd have to hand on to an instance of the actual Command itself, so we can edit it... in place? and hopefully writing to the settings would then just refresh all the other name->command maps instantly. ↩︎

Originally created by @zadjii-msft on GitHub (Apr 8, 2022). Originally assigned to: @shubhamvrs on GitHub. I write some long command. I need to use this frequently (or infrequently), but I don't want to have to remember all the args. I want to be able to pull it up straight from the command palette. So I want to write the command once, select it, and {perform some action}[^1] that lets me save it as a `sendInput` action. The action should * immediately save it. * provide a UI[^2] for immediately editing[^3] the name, contents of this action, because `Send "git log --graph --abbrev-commit --decorate..." to the Terminal` is not useful to anyone. Just doing the immediate save would be a good enough start on this, to the point I'd consider that an easy starter. The UI - that's **H**ard, for reasons listed below. > **Note** > ## Walkthrough As an initial version of this, it's more than good enough to just save the selected text as an action without the UI. We can iterate on the UI in follow-ups. * Probably start with something like [`dev/migrie/fhl/save-command`](https://github.com/microsoft/terminal/compare/6f5b9fb...1cde67ac466e19394eea1eb3a41405513d160a6f) * We probably want to skip all the `AppCommandlineArgs` stuff for now. That's spicier. * in `TerminalPage::_HandleSaveTask`, we will want to try and save the current selection as a `sendInput` action, if there's no `commandline` specified. * AppActionHandlers.cpp has plenty of examples of getting the active control. Should be easy enough to get the selected text from it. * We'll probably want to generate the name of this action (without a commandline) as "Save Task..." * Over and above: It would be valuable to `Toast` the user with a message "Saved selected text as a new action". `TerminalPage::IdentifyWindow` has an example of a `Toast` [^1]: Obviously, easiest way is via cmdpal or keybinding. Also consider a right-click context menu entry, #3337 [^2]: This has it's own challenges. It can't be a `ContentDialog` (https://github.com/microsoft/microsoft-ui-xaml/issues/3804). It could be nested in a `Flyout`, maybe. Hopefully the dialog thing is limited just to ContentDialogs and not all Flyouts. It probably shouldn't be a `TeachingTip` (#12798). We _could_ roll our own ContentDialog for this of course (#11308). [^3]: Might be tricky - we'd have to hand on to an instance of the actual `Command` itself, so we can edit it... in place? and hopefully writing to the settings would then just refresh all the other name->command maps instantly.
claunia commented 2026-01-31 05:34:45 +00:00
Author
Owner
Copy Link

@shubhamvrs commented on GitHub (Aug 10, 2023):

/assign

@shubhamvrs commented on GitHub (Aug 10, 2023): /assign
claunia commented 2026-01-31 05:34:45 +00:00
Author
Owner
Copy Link

@Ben-EJ commented on GitHub (Dec 4, 2023):

Can I work on this? : )

@Ben-EJ commented on GitHub (Dec 4, 2023): Can I work on this? : )
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings good first issue Help Wanted In-PR Issue-Task Needs-Tag-Fix Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#17185
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?