starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

"New tab..." iterable command should iterate over all profiles (not just active ones) #17192

New Issue
Closed
opened 2026-01-31 05:34:56 +00:00 by claunia · 6 comments
claunia commented 2026-01-31 05:34:56 +00:00
Owner
Copy Link

Originally created by @carlos-zamora on GitHub (Apr 8, 2022).

Windows Terminal version

1.14.892.0

Windows build number

10.0.22596.0

Other Software

No response

Steps to reproduce

  1. hide some profiles from the dropdown using "hidden": "true" (or Settings UI)
  2. Open the command palette
  3. Invoke the "New tab..." iterable command

Expected Behavior

The hidden profiles should be in the list.

Actual Behavior

The hidden profiles are omitted from the list

Originally created by @carlos-zamora on GitHub (Apr 8, 2022). ### Windows Terminal version 1.14.892.0 ### Windows build number 10.0.22596.0 ### Other Software _No response_ ### Steps to reproduce 1. hide some profiles from the dropdown using `"hidden": "true"` (or Settings UI) 2. Open the command palette 3. Invoke the "New tab..." iterable command ### Expected Behavior The hidden profiles should be in the list. ### Actual Behavior The hidden profiles are _omitted_ from the list
claunia added the Issue-BugProduct-TerminalResolution-Won't-FixArea-CmdPal labels 2026-01-31 05:34:57 +00:00
claunia commented 2026-01-31 05:34:58 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Apr 8, 2022):

I think the change would be fairly simple. We would just need to pass CascadiaSettings::_allProfiles into Command::ExpandCommands() (as opposed to CascadiaSettings::_activeProfiles).

@carlos-zamora commented on GitHub (Apr 8, 2022): I think the change would be fairly simple. We would just need to pass `CascadiaSettings::_allProfiles` into `Command::ExpandCommands()` (as opposed to `CascadiaSettings::_activeProfiles`).
claunia commented 2026-01-31 05:34:58 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Apr 8, 2022):

I dunno about this one -- I just added an iterable to my root command palette that goes over profiles as well, and I sure would be surprised if hidden ones popped up.

@DHowett commented on GitHub (Apr 8, 2022): I dunno about this one -- I just added an iterable to my _root command palette_ that goes over profiles as well, and I sure would be surprised if hidden ones popped up.
claunia commented 2026-01-31 05:34:58 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Apr 8, 2022):

Yeah, the part I'm conflicted on is this: what does it mean for a profile to be "hidden"? In SUI, we say "Hide profile from dropdown", so that means hiding it should still make it appear in the command palette, right? (granted, historically we've just used "hidden" as a way to fake-delete profiles from SUI).

@carlos-zamora commented on GitHub (Apr 8, 2022): Yeah, the part I'm conflicted on is this: what does it mean for a profile to be "hidden"? In SUI, we say "Hide profile from dropdown", so that means hiding it should still make it appear in the command palette, right? (granted, historically we've just used "hidden" as a way to fake-delete profiles from SUI).
claunia commented 2026-01-31 05:34:59 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Apr 26, 2023):

This one requires discussion rather than triage!

@DHowett commented on GitHub (Apr 26, 2023): This one requires discussion rather than triage!
claunia commented 2026-01-31 05:34:59 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Apr 26, 2023):

FYI, some developers use fragment extensions to customize how their applications are displayed without adding a profile to the list by using hidden: true. It would be more surprising IMO if those ones showed up, but they're not different from user-hidden profiles.

@DHowett commented on GitHub (Apr 26, 2023): FYI, some developers use fragment extensions to customize how their applications are displayed _without_ adding a profile to the list by using `hidden: true`. It would be more surprising IMO if those ones showed up, but they're not different from user-hidden profiles.
claunia commented 2026-01-31 05:35:00 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (May 15, 2023):

Long-term we'd like to treat hidden profiles as if they were deleted, because hidden used to be a workaround to "delete" generated profiles. In the future we'd additionally prefer if generated profiles don't get added to the visible list of profiles anymore by default. Instead users have to explicitly add them in the settings.

@lhecker commented on GitHub (May 15, 2023): Long-term we'd like to treat hidden profiles as if they were deleted, because hidden used to be a workaround to "delete" generated profiles. In the future we'd additionally prefer if generated profiles don't get added to the visible list of profiles anymore by default. Instead users have to explicitly add them in the settings.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CmdPal Issue-Bug Product-Terminal Resolution-Won't-Fix
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#17192
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?