Settings file being reformatted when the Terminal opens #1732

Closed
opened 2026-01-30 22:34:59 +00:00 by claunia · 6 comments
Owner

Originally created by @giggio on GitHub (Jun 18, 2019).

Environment

Built as release from latest commit on master: 440bee0e4a
Windows build number: Microsoft Windows [Version 10.0.18362.175]

Steps to reproduce

When the Terminal opens the settings file gets reformatted.

And (what is really, really annoying) the new format adds trailing white spaces to every JSON key and the new format is not tasteful (what are those spaces before every colon?).

Expected behavior

Settings file is left untouched when the Terminal opens.

Actual behavior

File is reformatted every time the Terminal opens.

Originally created by @giggio on GitHub (Jun 18, 2019). # Environment Built as `release` from latest commit on master: 440bee0e4abd0a778cbdff5b86f73fb34a92f3ed Windows build number: `Microsoft Windows [Version 10.0.18362.175]` # Steps to reproduce When the Terminal opens the settings file gets reformatted. And (what is really, really annoying) the new format adds trailing white spaces to every JSON key and the new format is not tasteful (what are those spaces before every colon?). # Expected behavior Settings file is left untouched when the Terminal opens. # Actual behavior File is reformatted every time the Terminal opens.
claunia added the Resolution-Fix-AvailableArea-SettingsIssue-BugProduct-Terminal labels 2026-01-30 22:34:59 +00:00
Author
Owner

@DHowett-MSFT commented on GitHub (Jun 18, 2019):

Huh. We try to only save the file if it's logically different from the one you saved. I'll retitle this a bit.

@DHowett-MSFT commented on GitHub (Jun 18, 2019): Huh. We try to only save the file if it's logically different from the one you saved. I'll retitle this a bit.
Author
Owner

@DHowett-MSFT commented on GitHub (Jun 19, 2019):

We were thinking that this might have been #1325. @zadjii-msft do you agree?

@DHowett-MSFT commented on GitHub (Jun 19, 2019): We were thinking that this might have been #1325. @zadjii-msft do you agree?
Author
Owner

@giggio commented on GitHub (Jun 19, 2019):

I just pulled the latest from master which contains the fix for #1325 and the issue still happens. The difference is that now the file is reformatted when the Terminal opens, not when you save it. I'll update the description.

@giggio commented on GitHub (Jun 19, 2019): I just pulled the latest from `master` which contains the fix for #1325 and the issue still happens. The difference is that now the file is reformatted when the Terminal opens, not when you save it. I'll update the description.
Author
Owner

@giggio commented on GitHub (Jun 19, 2019):

Just as history, this is the previous description:

Environment

Built as release from latest commit on master: 5f07f58fda
Windows build number: Microsoft Windows [Version 10.0.18362.175]

Steps to reproduce

If you save the settings file, it gets reformated.

And (what is really, really annoying) the new format adds trailing white spaces to every JSON key and the new format is not tasteful (what are those spaces before every colon?).

See it happening:

wt-reformat

Expected behavior

Settings file is saved and left untouched.

Actual behavior

File is reformatted.

@giggio commented on GitHub (Jun 19, 2019): Just as history, this is the previous description: # Environment Built as `release` from latest commit on master: 5f07f58fdaec89bfe30737f4f7f30723b2dae90e Windows build number: `Microsoft Windows [Version 10.0.18362.175]` # Steps to reproduce If you save the settings file, it gets reformated. And (what is really, really annoying) the new format adds trailing white spaces to every JSON key and the new format is not tasteful (what are those spaces before every colon?). See it happening: ![wt-reformat](https://user-images.githubusercontent.com/334958/59720980-94721e80-91f6-11e9-9574-a2644cee99f9.gif) # Expected behavior Settings file is saved and left untouched. # Actual behavior File is reformatted.
Author
Owner

@cinnamon-msft commented on GitHub (Aug 9, 2019):

I believe #1326 fixed this

@cinnamon-msft commented on GitHub (Aug 9, 2019): I believe #1326 fixed this
Author
Owner

@giggio commented on GitHub (Aug 12, 2019):

@cinnamon-msft ok, but the problem still happens on some situations. I opened a more comprehensive issue on #2411

@giggio commented on GitHub (Aug 12, 2019): @cinnamon-msft ok, but the problem still happens on some situations. I opened a more comprehensive issue on #2411
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#1732