starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Powerline glyph does not fill whole 'cell' / 'box' height #17393

New Issue
Closed
opened 2026-01-31 05:41:07 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 05:41:07 +00:00
Owner
Copy Link

Originally created by @Finii on GitHub (May 3, 2022).

Originally assigned to: @lhecker on GitHub.

Windows Terminal version

1.12.10982.0

Windows build number

10.0.19044.1645

Other Software

Cascadia Code 2111.01

Steps to reproduce

  • Install static Cascadia Code PL Regular [1]:
    • ttf/static/CascadiaCodePL-Regular.ttf or
    • otf/static/CascadiaCodePL-Regular.otf
  • Use it as font with 12 pt
  • Utilize the powerline glyphs like so (copy and paste into command prompt terminal window):
    set prompt=$E[0;33;40m$E[7;33;40m Manuel $E[0;33;40m$E[7;32;40m  ~ $E[0;32;40m$E[7;34;40m  $E[0;34;40m$E[0;37;40m $g

[1] https://github.com/microsoft/cascadia-code/releases/tag/v2111.01

Expected Behavior

The upper and lower 'border' of the powerline glyphs shall line up with the 'cell' top and bottom.
Cell top and bottom can be seen if insert a blank with reverse colors (like done in the prompt command above).

This is how it should look like, roughly (magnified 400%):

image

Actual Behavior

The glyphs are about 1 pixel to small vertically; here with the otf one pixel at the bottom seems to be missing:

image

This is most notable with the rounded D shape powerline symbols, but in fact are present in all.

image

The static ttf seem to have the missing pixel in the top.
I did not try the VF.

Origin of issue: Bottom (after closing) https://github.com/ryanoasis/nerd-fonts/issues/828

I believe this is not a Cascadia Code issue, because the original issue came up with a Nerd Font patched version of that font (Caskaydia Cove); and in the process of that issue I tried a lot like ascent and descent changing (all of them OS/2, typo, Win etc ;), PPEM modification, etc pp, all to no avail.
I do not really know how Windows Terminal finds out its cell size. If one understands that maybe the font can be beat into function. But I fear that it is a rendering issue, as this is always 1 px big, regardless of font size in point.

Edit: Fix typo

Originally created by @Finii on GitHub (May 3, 2022). Originally assigned to: @lhecker on GitHub. ### Windows Terminal version 1.12.10982.0 ### Windows build number 10.0.19044.1645 ### Other Software Cascadia Code 2111.01 ### Steps to reproduce * Install static `Cascadia Code PL Regular` [1]: * `ttf/static/CascadiaCodePL-Regular.ttf` or * `otf/static/CascadiaCodePL-Regular.otf` * Use it as font with 12 pt * Utilize the powerline glyphs like so (copy and paste into command prompt terminal window): `set prompt=$E[0;33;40m$E[7;33;40m Manuel $E[0;33;40m$E[7;32;40m  ~ $E[0;32;40m$E[7;34;40m  $E[0;34;40m$E[0;37;40m $g` [1] https://github.com/microsoft/cascadia-code/releases/tag/v2111.01 ### Expected Behavior The upper and lower 'border' of the powerline glyphs shall line up with the 'cell' top and bottom. Cell top and bottom can be seen if insert a blank with reverse colors (like done in the prompt command above). This is how it should look like, roughly (magnified 400%): ![image](https://user-images.githubusercontent.com/16012374/166445737-77ba0a2d-1d9a-4c89-b511-1afcdf598234.png) ### Actual Behavior The glyphs are about 1 pixel to small vertically; here with the `otf` one pixel at the bottom seems to be missing: ![image](https://user-images.githubusercontent.com/16012374/166445966-9c06e4aa-56a2-43df-aa43-320bcce82eb8.png) This is most notable with the rounded D shape powerline symbols, but in fact are present in all. ![image](https://user-images.githubusercontent.com/16012374/166446192-519be1ba-74de-4d61-8ea0-d6c92805f921.png) The static `ttf` seem to have the missing pixel in the top. I did not try the VF. Origin of issue: Bottom (after closing) https://github.com/ryanoasis/nerd-fonts/issues/828 I believe this is not a Cascadia Code issue, because the original issue came up with a Nerd Font patched version of that font (Caskaydia Cove); and in the process of that issue I tried a lot like ascent and descent changing (all of them OS/2, typo, Win etc ;), PPEM modification, etc pp, all to no avail. I do not really know how `Windows Terminal` finds out its cell size. If one understands that maybe the font can be beat into function. But I fear that it is a rendering issue, as this is always 1 px big, regardless of font size in point. _Edit: Fix typo_
claunia commented 2026-01-31 05:41:09 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 1, 2022):

Admittedly, you're probably using the default DX renderer, but I wonder if we fixed this for the Atlas engine in #13549, /cc @lhecker

Also hints of:

@zadjii-msft commented on GitHub (Aug 1, 2022): Admittedly, you're probably using the default DX renderer, but I wonder if we fixed this for the Atlas engine in #13549, /cc @lhecker Also hints of: * #8993
claunia commented 2026-01-31 05:41:09 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Aug 1, 2022):

@zadjii-msft It looks terrible!

image

The lines occur because I subtract an extra 1px when downsizing glyphs and I did that in response to https://github.com/microsoft/terminal/pull/13549#issuecomment-1191466896
This situation is definitely a bit annoying! 😅

@lhecker commented on GitHub (Aug 1, 2022): @zadjii-msft It looks terrible! ![image](https://user-images.githubusercontent.com/2256941/182234716-65f97c15-3dcc-4cd9-8c54-b7d74d88ed0e.png) The lines occur because I subtract an extra 1px when downsizing glyphs and I did that in response to https://github.com/microsoft/terminal/pull/13549#issuecomment-1191466896 This situation is definitely a bit annoying! 😅
claunia commented 2026-01-31 05:41:09 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Sep 13, 2022):

:tada:This issue was addressed in #13650, which has now been successfully released as Windows Terminal Preview v1.16.252.🎉

Handy links:

@ghost commented on GitHub (Sep 13, 2022): :tada:This issue was addressed in #13650, which has now been successfully released as `Windows Terminal Preview v1.16.252`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.16.252) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Rendering Issue-Bug Priority-3 Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#17393
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?