"Open In Terminal" doesn't have a letter selector or hot key #17426

Closed
opened 2026-01-31 05:42:09 +00:00 by claunia · 8 comments
Owner

Originally created by @keithn on GitHub (May 9, 2022).

Windows Terminal version

No response

Windows build number

No response

Other Software

No response

Steps to reproduce

Open in Terminal when in Explorer is handicapped for keyboard users as there is no direct way to trigger opening a terminal with the keyboard, and if you use your "menu" key on the keyboard, it opens the right click menu, but "Open in Terminal" has no hotkey associated with it, so the only way to select it is to arrow down, which is too fiddly.

image

Expected Behavior

Hotkey and Letter select should be enabled

Actual Behavior

I cried.

Originally created by @keithn on GitHub (May 9, 2022). ### Windows Terminal version _No response_ ### Windows build number _No response_ ### Other Software _No response_ ### Steps to reproduce Open in Terminal when in Explorer is handicapped for keyboard users as there is no direct way to trigger opening a terminal with the keyboard, and if you use your "menu" key on the keyboard, it opens the right click menu, but "Open in Terminal" has no hotkey associated with it, so the only way to select it is to arrow down, which is too fiddly. ![image](https://user-images.githubusercontent.com/86080/167333171-375430fb-de69-4e65-908e-17e150c8af07.png) ### Expected Behavior Hotkey and Letter select should be enabled ### Actual Behavior I cried.
Author
Owner

@ianjoneill commented on GitHub (May 9, 2022):

So this looks to be as easy as adding an &amp; before whatever character you want the accelerator key to be in the resw file. e.g. to get the screenshot below all I did was change dad68edc03/src/cascadia/TerminalApp/Resources/en-US/ContextMenu.resw (L161) to be <value>Open in &amp;Terminal (Dev)</value>. If a core dev can confirm what they want the accelerator key to be for Dev, Preview and Release it should be trivial.

image

@ianjoneill commented on GitHub (May 9, 2022): So this looks to be as easy as adding an `&amp;` before whatever character you want the accelerator key to be in the resw file. e.g. to get the screenshot below all I did was change https://github.com/microsoft/terminal/blob/dad68edc034e5e022b29881ea7e3af77b97c56a0/src/cascadia/TerminalApp/Resources/en-US/ContextMenu.resw#L161 to be `<value>Open in &amp;Terminal (Dev)</value>`. If a core dev can confirm what they want the accelerator key to be for Dev, Preview and Release it should be trivial. ![image](https://user-images.githubusercontent.com/5821575/167366968-735a5fed-f7f7-422c-861c-016375553895.png)
Author
Owner

@keithn commented on GitHub (May 9, 2022):

Yes, should be trivial, not sure what the translations are like, but definitely T in the English version.

@keithn commented on GitHub (May 9, 2022): Yes, should be trivial, not sure what the translations are like, but definitely T in the English version.
Author
Owner

@zadjii-msft commented on GitHub (May 10, 2022):

Oh man I can't believe we never thought of that! Yes, we should totally do that. I'm cool with T as the key. A hot take might be to do T for stable, P for the preview version, and D for the dev build, but I'll let that get sorted out in review.

@zadjii-msft commented on GitHub (May 10, 2022): Oh man I can't believe we never thought of that! Yes, we should totally do that. I'm cool with `T` as the key. A hot take might be to do `T` for stable, `P` for the preview version, and `D` for the dev build, but I'll let that get sorted out in review.
Author
Owner

@keithn commented on GitHub (May 10, 2022):

Oh man I can't believe we never thought of that! Yes, we should totally do that. I'm cool with T as the key. A hot take might be to do T for stable, P for the preview version, and D for the dev build, but I'll let that get sorted out in review.

just a note, P is used already for "Group by" and "Paste" the letter choices for some of the standard stuff are a bit odd, ideally it matches a unique single letter so it opens straightaway.

@keithn commented on GitHub (May 10, 2022): > Oh man I can't believe we never thought of that! Yes, we should totally do that. I'm cool with `T` as the key. A hot take might be to do `T` for stable, `P` for the preview version, and `D` for the dev build, but I'll let that get sorted out in review. just a note, P is used already for "Group by" and "Paste" the letter choices for some of the standard stuff are a bit odd, ideally it matches a unique single letter so it opens straightaway.
Author
Owner

@ianjoneill commented on GitHub (May 11, 2022):

With the English (UK) language variant Group by is G. It's a bit odd that it's different to whatever English variant you're using!

I went with I for preview as I can't see anything in your context menu or mine with that allocation.

@ianjoneill commented on GitHub (May 11, 2022): With the English (UK) language variant Group by is `G`. It's a bit odd that it's different to whatever English variant you're using! I went with `I` for preview as I can't see anything in your context menu or mine with that allocation.
Author
Owner

@keithn commented on GitHub (May 11, 2022):

None of the windows functions use I, but that's what visual studio code has hooked
image

@keithn commented on GitHub (May 11, 2022): None of the windows functions use I, but that's what visual studio code has hooked ![image](https://user-images.githubusercontent.com/86080/167832461-1c42003d-047d-4152-a859-c563e90951c8.png)
Author
Owner

@ghost commented on GitHub (Jul 6, 2022):

:tada:This issue was addressed in #13080, which has now been successfully released as Windows Terminal v1.14.186.🎉

Handy links:

@ghost commented on GitHub (Jul 6, 2022): :tada:This issue was addressed in #13080, which has now been successfully released as `Windows Terminal v1.14.186`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.14.186) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Author
Owner

@ghost commented on GitHub (Jul 6, 2022):

:tada:This issue was addressed in #13080, which has now been successfully released as Windows Terminal Preview v1.15.186.🎉

Handy links:

@ghost commented on GitHub (Jul 6, 2022): :tada:This issue was addressed in #13080, which has now been successfully released as `Windows Terminal Preview v1.15.186`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.15.186) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#17426