starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Another case of the virtual bottom being miscalculated #17463

New Issue
Closed
opened 2026-01-31 05:43:17 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 05:43:17 +00:00
Owner
Copy Link

Originally created by @j4james on GitHub (May 10, 2022).

Windows Terminal version

Commit ec726e7ba7

Windows build number

10.0.19041.1415

Other Software

vttest

Steps to reproduce

  1. Open a bash shell in conhost.
  2. Immediately run vttest.
  3. Select test 4 (Test of double-sized characters).
  4. Press enter twice until it gets to the 132-column test.

Expected Behavior

It should display a 132-column version of the test output with examples of double width and double height content.

Actual Behavior

The page appears mostly blank, but if you scroll back in the buffer, you can see the test content has rendered on the page above (partially overwriting the previous test). This doesn't seem to happen (at least not consistently) if you've already scrolled down in the buffer when you start the test.

I believe this is another victim of PR #12972. And it looks like the source of the problem is again in the ResizeWithReflow code, which picks a position for the virtual bottom that isn't far enough down. I think this is because the majority of the page is blank at the time of the resize.

Originally created by @j4james on GitHub (May 10, 2022). ### Windows Terminal version Commit ec726e7ba70b760f98eb1e1ea1d71124536783c0 ### Windows build number 10.0.19041.1415 ### Other Software [vttest](https://www.invisible-island.net/vttest/) ### Steps to reproduce 1. Open a bash shell in conhost. 2. Immediately run vttest. 3. Select test 4 (Test of double-sized characters). 4. Press enter twice until it gets to the 132-column test. ### Expected Behavior It should display a 132-column version of the test output with examples of double width and double height content. ### Actual Behavior The page appears mostly blank, but if you scroll back in the buffer, you can see the test content has rendered on the page above (partially overwriting the previous test). This doesn't seem to happen (at least not consistently) if you've already scrolled down in the buffer when you start the test. I believe this is another victim of PR #12972. And it looks like the source of the problem is again in the `ResizeWithReflow` code, which picks a position for the virtual bottom that isn't far enough down. I think this is because the majority of the page is blank at the time of the resize.
claunia commented 2026-01-31 05:43:18 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (May 11, 2022):

I should add that I have an idea for fixing this: Essentially what we'd need to do is save the distance between the cursor row and the virtual bottom prior to resizing, and then add that distance to the new cursor row after resizing, and that should give us a good estimate of where the new virtual bottom ought to be. We'd still probably also need to take into account the other boundaries that we're currently checking, like the last non-space row, and the viewport height.

If that works, I'll try and put together a PR with the fix on Thursday.

@j4james commented on GitHub (May 11, 2022): I should add that I have an idea for fixing this: Essentially what we'd need to do is save the distance between the cursor row and the virtual bottom *prior* to resizing, and then add that distance to the new cursor row *after* resizing, and that should give us a good estimate of where the new virtual bottom ought to be. We'd still probably also need to take into account the other boundaries that we're currently checking, like the last non-space row, and the viewport height. If that works, I'll try and put together a PR with the fix on Thursday.
claunia commented 2026-01-31 05:43:18 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (May 11, 2022):

(FWIW: I don't necessarily think you do, but if you do feel bad about introducing more virtual bottom bugs . . . just think about all the ones we already had that you helped to enumerate and fix(!). In true Windows Console fashion, and in the fashion of every other project everywhere, you can't make an omelet without breaking a few lions eggs. I'm eternally grateful for you breaking those eggs.)

@DHowett commented on GitHub (May 11, 2022): (FWIW: I don't necessarily think you do, but _if you do_ feel bad about introducing more virtual bottom bugs . . . just think about all the ones we already had that you helped to enumerate _and fix(!)_. In true Windows Console fashion, and in the fashion of every other project everywhere, you can't make an omelet without breaking a few ~lions~ eggs. I'm eternally grateful for you breaking those eggs.)
claunia commented 2026-01-31 05:43:19 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (May 24, 2022):

:tada:This issue was addressed in #13087, which has now been successfully released as Windows Terminal Preview v1.14.143.🎉

Handy links:

@ghost commented on GitHub (May 24, 2022): :tada:This issue was addressed in #13087, which has now been successfully released as `Windows Terminal Preview v1.14.143`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.14.143) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Output Impact-Correctness Issue-Bug Priority-2 Product-Conhost Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#17463
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?