starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Add support for querying DECAC with DECRQSS #17468

New Issue
Closed
opened 2026-01-31 05:43:23 +00:00 by claunia · 7 comments
claunia commented 2026-01-31 05:43:23 +00:00
Owner
Copy Link

Originally created by @j4james on GitHub (May 13, 2022).

Description of the new feature/enhancement

This is a follow-up to PR #13058. Ideally we should be able to query the state of the DECAC color assignments using a DECRQSS query, so if an application changes those values, it can also restore them to what they were initially.

Proposed technical implementation details (optional)

The problem here is that DECAC works differently from most other DECRQSS queries. Typically there is only one potential response for a query, but in the case of DECAC we need to know whether to return the Normal Text colors, or the Window Frame colors.

This is what the VT525 manual has to say on the subject:

DECAC can be reported using DECRQSS and DECRPSS. Use Ps1 in DECRQSS to select the item to be reported.

But it's not clear to me what that means. Is the Ps1 meant to be included as a parameter value following the DCS introducer, or within the actual body of the string data? For example, if you're querying the window frame (color item 2), do you use this:

\eP2$q,|\e\\

or this:

\eP$q2,|\e\\

Of the modern terminal emulators I've tested, only three support DECAC in any capacity, and only two of those respond to a DECRQSS query for DECAC, but not in the same way. If I was forced to make a choice, I'd likely go with the second option, but I'm hoping we can get confirmation of the correct behavior from someone with a VT525.

Originally created by @j4james on GitHub (May 13, 2022). # Description of the new feature/enhancement This is a follow-up to PR #13058. Ideally we should be able to query the state of the `DECAC` color assignments using a `DECRQSS` query, so if an application changes those values, it can also restore them to what they were initially. # Proposed technical implementation details (optional) The problem here is that `DECAC` works differently from most other `DECRQSS` queries. Typically there is only one potential response for a query, but in the case of `DECAC` we need to know whether to return the _Normal Text_ colors, or the _Window Frame_ colors. This is what the VT525 manual has to say on the subject: > `DECAC` can be reported using `DECRQSS` and `DECRPSS`. Use **Ps1** in `DECRQSS` to select the item to be reported. But it's not clear to me what that means. Is the **Ps1** meant to be included as a parameter value following the `DCS` introducer, or within the actual body of the string data? For example, if you're querying the window frame (color item 2), do you use this: \eP2$q,|\e\\ or this: \eP$q2,|\e\\ Of the modern terminal emulators I've tested, only three support `DECAC` in any capacity, and only two of those respond to a `DECRQSS` query for `DECAC`, but not in the same way. If I was forced to make a choice, I'd likely go with the second option, but I'm hoping we can get confirmation of the correct behavior from someone with a VT525.
claunia added the Help WantedProduct-ConhostIssue-TaskIn-PRArea-VTNeeds-Tag-Fix labels 2026-01-31 05:43:23 +00:00
claunia commented 2026-01-31 05:43:25 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (May 13, 2022):

/cc @jerch If you get back to doing some testing on your VT525, this is one the escape sequences that I'd love to get more info on. And I'd be happy to put together some test scripts if that would help.

@j4james commented on GitHub (May 13, 2022): /cc @jerch If you get back to doing some testing on your VT525, this is one the escape sequences that I'd love to get more info on. And I'd be happy to put together some test scripts if that would help.
claunia commented 2026-01-31 05:43:25 +00:00
Author
Owner
Copy Link

@jerch commented on GitHub (May 13, 2022):

/cc @jerch If you get back to doing some testing on your VT525, this is one the escape sequences that I'd love to get more info on. And I'd be happy to put together some test scripts if that would help.

Yes, if you have ready-to-go test scripts, that would certainly speed up the process, as I could simply run it and return you the output (without actually going into sequence semantics on my own, which is more time consuming).

@jerch commented on GitHub (May 13, 2022): > /cc @jerch If you get back to doing some testing on your VT525, this is one the escape sequences that I'd love to get more info on. And I'd be happy to put together some test scripts if that would help. Yes, if you have ready-to-go test scripts, that would certainly speed up the process, as I could simply run it and return you the output (without actually going into sequence semantics on my own, which is more time consuming).
claunia commented 2026-01-31 05:43:25 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (May 14, 2022):

Thanks @jerch - that would be much appreciated. I've created a test script here:
https://gist.github.com/j4james/eca9bd29189f2abe851f206f1cbda0cd

When it runs, it'll log the responses to a file name decac.log, so it should hopefully be easy to report back. But note that it just appends to the end of the file each time, so you may need to delete it between runs if you rerun the test.

If possible, it would be good if you could assign the default text colors for the terminal to blue on white (more specifically index values 4 on 7) before running the test. You should be able to do this from the Setup menu: select Color, then Assign colors..., then configure the values for the Normal text option. This is not essential though - I'm just curious to see if that has any effect on the default parameters.

@j4james commented on GitHub (May 14, 2022): Thanks @jerch - that would be much appreciated. I've created a test script here: https://gist.github.com/j4james/eca9bd29189f2abe851f206f1cbda0cd When it runs, it'll log the responses to a file name _decac.log_, so it should hopefully be easy to report back. But note that it just appends to the end of the file each time, so you may need to delete it between runs if you rerun the test. If possible, it would be good if you could assign the default text colors for the terminal to blue on white (more specifically index values 4 on 7) before running the test. You should be able to do this from the Setup menu: select _Color_, then _Assign colors..._, then configure the values for the _Normal text_ option. This is not essential though - I'm just curious to see if that has any effect on the default parameters.
claunia commented 2026-01-31 05:43:25 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Mar 12, 2023):

@al20878 I've just remembered this is another test I was hoping to get someone to run on a VT525, so while I'm bombarding you with requests, I'd be grateful if you could add this to the list. The comment above has some notes on how the test should ideally be run (see https://github.com/microsoft/terminal/issues/13091#issuecomment-1126579485).

@j4james commented on GitHub (Mar 12, 2023): @al20878 I've just remembered this is another test I was hoping to get someone to run on a VT525, so while I'm bombarding you with requests, I'd be grateful if you could add this to the list. The comment above has some notes on how the test should ideally be run (see https://github.com/microsoft/terminal/issues/13091#issuecomment-1126579485).
claunia commented 2026-01-31 05:43:25 +00:00
Author
Owner
Copy Link

@al20878 commented on GitHub (Mar 12, 2023):

@j4james Downloaded the script, read the instructions, will try to follow them, and report back the results. Stay tuned ;-)

@al20878 commented on GitHub (Mar 12, 2023): @j4james Downloaded the script, read the instructions, will try to follow them, and report back the results. Stay tuned ;-)
claunia commented 2026-01-31 05:43:26 +00:00
Author
Owner
Copy Link

@al20878 commented on GitHub (Mar 12, 2023):

So I set the color as 4 on 7 and ran the script. Screen shot:

decac

Log:

decac.log

@al20878 commented on GitHub (Mar 12, 2023): So I set the color as 4 on 7 and ran the script. Screen shot: ![decac](https://user-images.githubusercontent.com/44822487/224578449-8148c553-6ada-494b-a67c-2d4c3516e901.png) Log: [decac.log](https://github.com/microsoft/terminal/files/10952271/decac.log)
claunia commented 2026-01-31 05:43:26 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Mar 12, 2023):

@al20878 Thank you again. I think this has given me all the info I need.

And I'm grateful for the screenshot, because that's made me realise that our DECAC implementation is not quite correct. I had thought the color changes would apply to existing text on the screen, but it only seems to effect new output. Will need to rethink our architecture somewhat.

@j4james commented on GitHub (Mar 12, 2023): @al20878 Thank you again. I think this has given me all the info I need. And I'm grateful for the screenshot, because that's made me realise that our `DECAC` implementation is not quite correct. I had thought the color changes would apply to existing text on the screen, but it only seems to effect new output. Will need to rethink our architecture somewhat.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-VT Help Wanted In-PR Issue-Task Needs-Tag-Fix Product-Conhost
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#17468
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?