starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-07-08 18:16:28 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Wrong icon gets rendered when directly running apps in terminal (double click exe to open terminal tab). #17492

New Issue
Closed
opened 2026-01-31 05:44:11 +00:00 by claunia · 7 comments
claunia commented 2026-01-31 05:44:11 +00:00
Owner
Copy Link

Originally created by @AraHaan on GitHub (May 16, 2022).

Windows Terminal version

1.13.10984.0

Windows build number

10.0.22000.0

Other Software

My Discord Bot v2.1.100.

On my Discord bot, it is designed to have an application icon. However when Windows Terminal is configured to be the default console host, all terminal tabs do not render the application icon when you directly double click it's executable file to run it.

Steps to reproduce

  1. Build an .NET Console application with an *.ico file for the program's icon, then double click the built output so it launches in Windows Terminal.

Expected Behavior

For the icon of the application to be rendered on the tab. On MacOS it renders the icon just fine, however that is in Apple's terminal.

Actual Behavior

A different icon is rendered and is provided from the OS or some other application instead?

Originally created by @AraHaan on GitHub (May 16, 2022). ### Windows Terminal version 1.13.10984.0 ### Windows build number 10.0.22000.0 ### Other Software My Discord Bot v2.1.100. On my Discord bot, it is designed to have an application icon. However when Windows Terminal is configured to be the default console host, all terminal tabs do not render the application icon when you directly double click it's executable file to run it. ### Steps to reproduce 1. Build an .NET Console application with an *.ico file for the program's icon, then double click the built output so it launches in Windows Terminal. ### Expected Behavior For the icon of the application to be rendered on the tab. On MacOS it renders the icon just fine, however that is in Apple's terminal. ### Actual Behavior A different icon is rendered and is provided from the OS or some other application instead?
claunia commented 2026-01-31 05:44:13 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 16, 2022):

Huh. Coulda swore we were tracking this somewhere, but doesn't look like it. #10669 looks vaguely related, but that's not it.

For this to work, we'd probably need to some set of:

we need to both be able to get the info on what the icon was supposed to be, and the ability to turn icons in dll's and exe's into XAML icons.

@zadjii-msft commented on GitHub (May 16, 2022): Huh. Coulda swore we were tracking this somewhere, but doesn't look like it. #10669 looks vaguely related, but that's not it. For this to work, we'd probably need to some set of: * #9458 * #1504 we need to both be able to get the info on what the icon was supposed to be, and the ability to turn icons in dll's and exe's into XAML icons.
claunia commented 2026-01-31 05:44:13 +00:00
Author
Owner
Copy Link

@AraHaan commented on GitHub (May 16, 2022):

Cant one use the Windows API to obtain the icon information from the program that terminal is about to run (when it determines the program is about to execute directly) in order to use that information to simulate a profile with the icon?

edit: something like https://docs.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-loadimagew

@AraHaan commented on GitHub (May 16, 2022): Cant one use the Windows API to obtain the icon information from the program that terminal is about to run (when it determines the program is about to execute directly) in order to use that information to simulate a profile with the icon? edit: something like https://docs.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-loadimagew
claunia commented 2026-01-31 05:44:13 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 16, 2022):

Yea probably. Trick there is converting the HANDLE that returns into something that can be used as the source for a XAML icon. If you can figure that out, the rest of this probably isn't too hard to wire up.

@zadjii-msft commented on GitHub (May 16, 2022): Yea probably. Trick there is converting the `HANDLE` that returns into something that can be used as the source for a XAML icon. If you can figure that out, the rest of this probably isn't too hard to wire up.
claunia commented 2026-01-31 05:44:14 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (May 16, 2022):

@zadjii-msft I'm comfortable calling this a dupe of both of those issues. The description for "pass LNK/EXE data" suggests making a fake runtime profile for the handed-off application, and part of that would be making sure it's got the right icon. We do both, we get icons!

/dup #9458 #1504

@DHowett commented on GitHub (May 16, 2022): @zadjii-msft I'm comfortable calling this a dupe of both of those issues. The description for "pass LNK/EXE data" suggests making a fake runtime profile for the handed-off application, and part of that would be making sure it's got the right icon. We do both, we get icons! /dup #9458 #1504
claunia commented 2026-01-31 05:44:14 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (May 16, 2022):

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost commented on GitHub (May 16, 2022): Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!
claunia commented 2026-01-31 05:44:14 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (May 16, 2022):

(Thanks for the report @arahaan!)

@DHowett commented on GitHub (May 16, 2022): (Thanks for the report @arahaan!)
claunia commented 2026-01-31 05:44:14 +00:00
Author
Owner
Copy Link

@AraHaan commented on GitHub (May 16, 2022):

Yea probably. Trick there is converting the HANDLE that returns into something that can be used as the source for a XAML icon. If you can figure that out, the rest of this probably isn't too hard to wire up.

On Winforms what I do is convert the HANDLE to an System.Drawing.Icon, and then convert the icon to an Bitmap, use the bitmap and icon for what I needed. I guess here could do something similar but have the bitmap saved to an temp bitmap file then try loading it as an XAML icon?

@AraHaan commented on GitHub (May 16, 2022): > Yea probably. Trick there is converting the `HANDLE` that returns into something that can be used as the source for a XAML icon. If you can figure that out, the rest of this probably isn't too hard to wire up. On Winforms what I do is convert the HANDLE to an System.Drawing.Icon, and then convert the icon to an Bitmap, use the bitmap and icon for what I needed. I guess here could do something similar but have the bitmap saved to an temp bitmap file then try loading it as an XAML icon?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-DefApp Area-UserInterface Issue-Bug Priority-3 Product-Terminal Resolution-Duplicate
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#17492
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?