starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-07-09 02:26:45 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Deleting all profiles crashes Windows Terminal #17513

New Issue
Closed
opened 2026-01-31 05:44:45 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 05:44:45 +00:00
Owner
Copy Link

Originally created by @lhecker on GitHub (May 18, 2022).

Windows Terminal version

1.13.11373.0

Windows build number

No response

Other Software

No response

Steps to reproduce

  1. Delete all profiles

Expected Behavior

  • Shouldn't crash

Actual Behavior

  • Crash
Originally created by @lhecker on GitHub (May 18, 2022). ### Windows Terminal version 1.13.11373.0 ### Windows build number _No response_ ### Other Software _No response_ ### Steps to reproduce 1. Delete all profiles ### Expected Behavior * Shouldn't crash ### Actual Behavior * Crash
claunia commented 2026-01-31 05:44:46 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (May 19, 2022):

A few quick thoughts...

  1. this is probably relatively new behavior now that you're allowed to delete any profile (instead of just the custom ones, since we blocked deleting CMD before state.json got added)
  2. back in the JSON-only days, we would throw a warning/error and (I believe) fallback to the default settings
  3. Wouldn't this be a case of "play stupid games..."? 100% agree we shouldn't crash, but I feel like solution would be that we fallback to the default settings (like before) until you fix it, but then that might cause a weird state with the SUI. I'm just concerned we'd need major changes to fix a crash that presumably very few (if any) people are accidentally hitting.
@carlos-zamora commented on GitHub (May 19, 2022): A few quick thoughts... 1. this is probably relatively new behavior now that you're allowed to delete _any_ profile (instead of just the custom ones, since we blocked deleting CMD before state.json got added) 2. back in the JSON-only days, we would throw a warning/error and (I believe) fallback to the default settings 3. Wouldn't this be a case of "play stupid games..."? 100% agree we shouldn't crash, but I feel like solution would be that we fallback to the default settings (like before) until you fix it, but then that might cause a weird state with the SUI. I'm just concerned we'd need major changes to fix a crash that presumably very few (if any) people are accidentally hitting.
claunia commented 2026-01-31 05:44:47 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (May 21, 2022):

Is this perhaps the same thing as #13017?

@j4james commented on GitHub (May 21, 2022): Is this perhaps the same thing as #13017?
claunia commented 2026-01-31 05:44:47 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (May 21, 2022):

No those are separate issues as far as I can tell. #13017 occurred when you saved your settings and you deleted a profile afterwards. Due to a bug in the UI code it crashed.

But I noticed that we also crash if you simply delete all profiles.

@lhecker commented on GitHub (May 21, 2022): No those are separate issues as far as I can tell. #13017 occurred when you saved your settings and you deleted a profile afterwards. Due to a bug in the UI code it crashed. But I noticed that we also crash if you simply delete all profiles.
claunia commented 2026-01-31 05:44:47 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jul 6, 2022):

:tada:This issue was addressed in #13242, which has now been successfully released as Windows Terminal v1.14.186.🎉

Handy links:

@ghost commented on GitHub (Jul 6, 2022): :tada:This issue was addressed in #13242, which has now been successfully released as `Windows Terminal v1.14.186`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.14.186) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
claunia commented 2026-01-31 05:44:47 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jul 6, 2022):

:tada:This issue was addressed in #13242, which has now been successfully released as Windows Terminal Preview v1.15.186.🎉

Handy links:

@ghost commented on GitHub (Jul 6, 2022): :tada:This issue was addressed in #13242, which has now been successfully released as `Windows Terminal Preview v1.15.186`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.15.186) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings Issue-Bug Needs-Triage Priority-1 Product-Terminal Resolution-Fix-Committed Severity-Crash
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#17513
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?