starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-24 16:05:21 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Opening a .bat file also executes whichever was the last .bat file I had open!? #17538

New Issue
Closed
opened 2026-01-31 05:45:20 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 05:45:20 +00:00
Owner
Copy Link

Originally created by @rjk on GitHub (May 24, 2022).

Windows Terminal version

1.12.10983.0

Windows build number

10.0.22000.0

Other Software

No response

Steps to reproduce

  • In Terminal settings I have Default profiler=powershell, Launch mode=Open windows from a previous session
  • Create two .bat files in a folder on my desktop:
a.bat:
echo %cd%
echo This is A
set /p someTestVariable="Press a key"

b.bat:
echo %cd%
echo This is B
set /p someTestVariable="Press a key"
  • double-click on a.bat so it's launched in Terminal. Close the window.
  • double-click on b.bat. Notice that both a.bat and b.bat have been run!

a.bat has been opened with working directory as my home directory. b.bat has been opened with working directory as the directory containing the .bat file.

Expected Behavior

Only the .bat file I double-clicked on should run

Actual Behavior

Maybe this is expected behaviour but I find it quite weird: when I launch a .bat file in Terminal it also opens up another window and runs whichever .bat file I ran last. If that's the same as the one I'm opening now then two instances of it are opened.

I don't think .bat files should be auto-launched even if "Open windows from a previous session" is selected. Surely this setting is for how many tabs you have open, current directory, etc, not for re-running .bat files that can have serious consequences?

At the least if you're opening the same .bat file as last time then only a single instance should be opened, not two.

Originally created by @rjk on GitHub (May 24, 2022). ### Windows Terminal version 1.12.10983.0 ### Windows build number 10.0.22000.0 ### Other Software _No response_ ### Steps to reproduce * In Terminal settings I have Default profiler=powershell, Launch mode=Open windows from a previous session * Create two .bat files in a folder on my desktop: ``` a.bat: echo %cd% echo This is A set /p someTestVariable="Press a key" b.bat: echo %cd% echo This is B set /p someTestVariable="Press a key" ``` * double-click on a.bat so it's launched in Terminal. Close the window. * double-click on b.bat. Notice that both a.bat and b.bat have been run! a.bat has been opened with working directory as my home directory. b.bat has been opened with working directory as the directory containing the .bat file. ### Expected Behavior Only the .bat file I double-clicked on should run ### Actual Behavior Maybe this is expected behaviour but I find it quite weird: when I launch a .bat file in Terminal it also opens up another window and runs whichever .bat file I ran last. If that's the same as the one I'm opening now then two instances of it are opened. I don't think .bat files should be auto-launched even if "Open windows from a previous session" is selected. Surely this setting is for how many tabs you have open, current directory, etc, not for re-running .bat files that can have serious consequences? At the least if you're opening the same .bat file as last time then only a single instance should be opened, not two.
claunia commented 2026-01-31 05:45:22 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jun 13, 2022):

Yea, this is the expected behavior. It's basically like running MicrosoftEdge.exe github.com after closing a single edge window - you're gonna get both the previous window and a new tab for github.

Now, maybe we should be more clever for defterm instances like this. Like, should we really persist a tab that was running a bat file like that? That seems... mildly unexpected. But then for something like "run pwsh.exe, close it, open foo.bat", that makes sense to bring the pwsh Terminal window back - that was the last thing you had running.

Yea, I'm gonna say this is by design. Sorry if it's a little unexpected! IIRC, closing the tab with the X button on the tab itself will prevent it from being persisted for the next launch. That we interpret as "the user wanted to close this thing and not see it again", vs closing the window as "close the terminal, but bring everything back".

@zadjii-msft commented on GitHub (Jun 13, 2022): Yea, this is the expected behavior. It's basically like running `MicrosoftEdge.exe github.com` after closing a single edge window - you're gonna get both the previous window and a new tab for github. Now, maybe we should be more clever for defterm instances like this. Like, should we really persist a tab that was running a `bat` file like that? That seems... mildly unexpected. But then for something like "run `pwsh.exe`, close it, open `foo.bat`", that makes sense to bring the `pwsh` Terminal window back - that was the last thing you had running. Yea, I'm gonna say this is by design. Sorry if it's a little unexpected! IIRC, closing the tab with the X button on the tab itself will prevent it from being persisted for the next launch. That we interpret as "the user wanted to close this thing and not see it again", vs closing the window as "close the terminal, but bring everything back".
claunia commented 2026-01-31 05:45:22 +00:00
Author
Owner
Copy Link

@rjk commented on GitHub (Jun 15, 2022):

Ok, I can understand if it's "by design" but I'll put in a suggestion to change that designed behavior.

There's a significant difference between this reopening browser tabs. Reopening tabs doesn't typically cause destructive actions, e.g. if your last action on github was "confirm delete all my repositories" and you reopened your browser some weeks later you'd be quite surprised if github deleted all the new repositories you'd created in those weeks. For example, the browser will probably only make GET requests, not POST requests even if that was the last action in a tab before closing.

I think there's a big difference between which tabs you had running, what their current directories are, and things like .bat files, since .bat files can be destructive. This means "Open windows from a previous session" becomes VERY dangerous. Normal users who don't think about such things could go for months happily using Terminal with that setting, then one day run a .bat file that does , and then not understand why it's automatically run the next time they start Terminal.

At the least there should be a warning about persisted commands from previous sessions that could be destructive.

Anyways, I'll open a new issue for that discussion.

@rjk commented on GitHub (Jun 15, 2022): Ok, I can understand if it's "by design" but I'll put in a suggestion to change that designed behavior. There's a significant difference between this reopening browser tabs. Reopening tabs doesn't typically cause destructive actions, e.g. if your last action on github was "confirm delete all my repositories" and you reopened your browser some weeks later you'd be quite surprised if github deleted all the new repositories you'd created in those weeks. For example, the browser will probably only make GET requests, not POST requests even if that was the last action in a tab before closing. I think there's a big difference between which tabs you had running, what their current directories are, and things like .bat files, since .bat files can be destructive. This means "Open windows from a previous session" becomes VERY dangerous. Normal users who don't think about such things could go for months happily using Terminal with that setting, then one day run a .bat file that does , and then not understand why it's automatically run the next time they start Terminal. At the least there should be a warning about persisted commands from previous sessions that could be destructive. Anyways, I'll open a new issue for that discussion.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Issue-Bug Needs-Tag-Fix Needs-Triage Product-Terminal Resolution-By-Design
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#17538
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?