starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Revisit TerminalSelection to add tests, clean up, proper selection mechanics #1760

New Issue
Closed
opened 2026-01-30 22:35:49 +00:00 by claunia · 5 comments
claunia commented 2026-01-30 22:35:49 +00:00
Owner
Copy Link

Originally created by @carlos-zamora on GitHub (Jun 19, 2019).

Originally assigned to: @carlos-zamora on GitHub.

More of a mental note of all the misc. selection stuff I need to do. Hopefully I can get this in very soon so that we can verify that nothing was broken.

  • Add testing for the following scenarios:
    • endSelectionPosition being located out of bounds
  • _GetSelectionRects() clean up
    • the pre-processing part is just a bit nasty now. There should be a way to simplify it. Need to be careful with testing this though.
  • Proper selection mechanics
    • when your endSelectionPosition is out of bounds vertically, the x-position should still update, but the y-position should be at the boundary
    • when your endSelectionPosition is out of bounds horizontally, the y-position should still update, but the y-position should be at the buffer boundary
    • this is particularly important for #1247. As the y-position must be detected to be out of the bounds, so that's still valid. But it should be displayed as updating the x-position.
Originally created by @carlos-zamora on GitHub (Jun 19, 2019). Originally assigned to: @carlos-zamora on GitHub. More of a mental note of all the misc. selection stuff I need to do. Hopefully I can get this in very soon so that we can verify that nothing was broken. - [x] Add testing for the following scenarios: - [x] `endSelectionPosition` being located out of bounds - [ ] `_GetSelectionRects()` clean up - the pre-processing part is just a bit nasty now. There should be a way to simplify it. Need to be careful with testing this though. - [x] Proper selection mechanics - when your `endSelectionPosition` is out of bounds **vertically**, the x-position should still update, but the y-position should be at the boundary - when your `endSelectionPosition` is out of bounds **horizontally**, the y-position should still update, but the y-position should be at the **buffer** boundary - this is particularly important for #1247. As the y-position must be detected to be out of the bounds, so that's still valid. But it should be displayed as updating the x-position.
claunia commented 2026-01-30 22:35:50 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Aug 14, 2019):

  • no need for us to track the start and end Y-offsets separately; they are generally the same (?)
  • concern about the logic being fragmented into a few different functions: chunk selections are expanded during GetSelectionRects instead of during selection (?)
@DHowett-MSFT commented on GitHub (Aug 14, 2019): * [x] no need for us to track the start and end Y-offsets separately; they are generally the same (?) * [ ] concern about the logic being fragmented into a few different functions: chunk selections are expanded during _GetSelectionRects_ instead of during selection (?)
claunia commented 2026-01-30 22:35:50 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Aug 16, 2019):

  • IsAreaSelected and IsSelectionActive are the SAME THING
@carlos-zamora commented on GitHub (Aug 16, 2019): - [x] `IsAreaSelected` and `IsSelectionActive` are the SAME THING
claunia commented 2026-01-30 22:35:50 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Aug 17, 2019):

  • IsAreaSelected and IsSelectionActive are the SAME THING

So, this one's on me. I created IsAreaSelected() in #1691 when I made some changes to IRenderData. This can actually get resolved in #2296 since I'm already touching that area of the code.

@carlos-zamora commented on GitHub (Aug 17, 2019): > * [x] `IsAreaSelected` and `IsSelectionActive` are the SAME THING So, this one's on me. I created `IsAreaSelected()` in #1691 when I made some changes to `IRenderData`. This can actually get resolved in #2296 since I'm already touching that area of the code.
claunia commented 2026-01-30 22:35:50 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Aug 20, 2019):

  • concern about the logic being fragmented into a few different functions: chunk selections are expanded during GetSelectionRects instead of during selection (?)

I'm thinking now that this might be OK. Keyboard selection would just set the anchors to whatever these functions return. That'll allow us to reuse the same function for the weird box selections that cover wide glyphs and words (on double click selections).

@carlos-zamora commented on GitHub (Aug 20, 2019): > * [ ] concern about the logic being fragmented into a few different functions: chunk selections are expanded during _GetSelectionRects_ instead of during selection (?) I'm thinking now that this might be OK. Keyboard selection would just set the anchors to whatever these functions return. That'll allow us to reuse the same function for the weird box selections that cover wide glyphs and words (on double click selections).
claunia commented 2026-01-30 22:35:50 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Sep 24, 2019):

:tada:This issue was addressed in #2511, which has now been successfully released as Windows Terminal Preview v0.5.2661.0.🎉

Handy links:

@ghost commented on GitHub (Sep 24, 2019): :tada:This issue was addressed in #2511, which has now been successfully released as `Windows Terminal Preview v0.5.2661.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v0.5.2661.0) * [Store Download](https://www.microsoft.com/store/apps/9n0dx20hk701?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CodeHealth Area-Interaction Issue-Task Needs-Tag-Fix Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#1760
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?