starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 00:15:10 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

colortool utility sets foreground color to bright white upon exiting if ran with -c #17615

New Issue
Closed
opened 2026-01-31 05:47:48 +00:00 by claunia · 6 comments
claunia commented 2026-01-31 05:47:48 +00:00
Owner
Copy Link

Originally created by @george-tsiros on GitHub (Jun 1, 2022).

Windows Terminal version

none

Windows build number

10.0.22000.675

Other Software

cmd.exe

Steps to reproduce

run cmd
color 70
colortool -c

Expected Behavior

foreground color is gray ("7")

Actual Behavior

foreground color is white ("f")

Originally created by @george-tsiros on GitHub (Jun 1, 2022). ### Windows Terminal version none ### Windows build number 10.0.22000.675 ### Other Software cmd.exe ### Steps to reproduce run cmd `color 70` `colortool -c` ### Expected Behavior foreground color is gray ("7") ### Actual Behavior foreground color is white ("f")
claunia commented 2026-01-31 05:47:49 +00:00
Author
Owner
Copy Link

@george-tsiros commented on GitHub (Jun 1, 2022):

in program.cs, insert a copy of the lines 152 and 153 between lines 172 and 173

@george-tsiros commented on GitHub (Jun 1, 2022): in program.cs, insert a copy of the lines 152 and 153 between lines 172 and 173
claunia commented 2026-01-31 05:47:49 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jun 6, 2022):

in program.cs, insert a copy of the lines 152 and 153 between lines 172 and 173

Are we looking at the same file/? In the current main, these are the sections you called out

ed27737233/src/tools/ColorTool/ColorTool/Program.cs (L151-L155)
ed27737233/src/tools/ColorTool/ColorTool/Program.cs (L168-L174)

I don't really think that ~L172 is the right place to be restoring the console mode (and I don't think that would really work for this either...)

I'm also pretty sure that -c is supposed to restore the previous attributes:
ed27737233/src/tools/ColorTool/ColorTool/ColorTable.cs (L146-L149)

@zadjii-msft commented on GitHub (Jun 6, 2022): > in program.cs, insert a copy of the lines 152 and 153 between lines 172 and 173 Are we looking at the same file/? In the current `main`, these are the sections you called out https://github.com/microsoft/terminal/blob/ed27737233714dea77877624d1beeb49e2ccd36e/src/tools/ColorTool/ColorTool/Program.cs#L151-L155 https://github.com/microsoft/terminal/blob/ed27737233714dea77877624d1beeb49e2ccd36e/src/tools/ColorTool/ColorTool/Program.cs#L168-L174 I don't really think that ~L172 is the right place to be restoring the console mode (and I don't think that would really work for this either...) I'm also pretty sure that `-c` is _supposed_ to restore the previous attributes: https://github.com/microsoft/terminal/blob/ed27737233714dea77877624d1beeb49e2ccd36e/src/tools/ColorTool/ColorTool/ColorTable.cs#L146-L149
claunia commented 2026-01-31 05:47:50 +00:00
Author
Owner
Copy Link

@george-tsiros commented on GitHub (Jun 6, 2022):

i had v1.0.0.0

@george-tsiros commented on GitHub (Jun 6, 2022): i had v1.0.0.0
claunia commented 2026-01-31 05:47:50 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jun 6, 2022):

Can you try a newer version/? The code that looks like it's responsible for restoring the colors is at least in #418, and that shipped as a ColorTool update all the way back in April 2019

@zadjii-msft commented on GitHub (Jun 6, 2022): Can you try a newer version/? The code that looks like it's responsible for restoring the colors is at least in #418, and that shipped as a ColorTool update all the way back in [April 2019](https://github.com/microsoft/terminal/releases/tag/1904.29002)
claunia commented 2026-01-31 05:47:50 +00:00
Author
Owner
Copy Link

@george-tsiros commented on GitHub (Jun 6, 2022):

please close this issue completely, it was my mistake

@george-tsiros commented on GitHub (Jun 6, 2022): please close this issue completely, it was my mistake
claunia commented 2026-01-31 05:47:50 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jun 6, 2022):

No worries, glad you figured it out!

@zadjii-msft commented on GitHub (Jun 6, 2022): No worries, glad you figured it out!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Issue-Bug Needs-Attention Needs-Tag-Fix Needs-Triage Product-Colortool
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#17615
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?