starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[Settings UI] Adding an action with no key chord hits an assert #17619

New Issue
Open
opened 2026-01-31 05:47:56 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 05:47:56 +00:00
Owner
Copy Link

Originally created by @carlos-zamora on GitHub (Jun 2, 2022).

Originally assigned to: @zadjii-msft on GitHub.

Windows Terminal version

main @ 9dca6c2

Windows build number

doesn't matter

Other Software

none

Steps to reproduce

  1. Go to Settings > Actions
  2. Add a new keybinding with an empty key chord
  3. hit save

Expected Behavior

We should require a key chord before adding the action.

Actual Behavior

[Debug mode] hit an assert in KeyChord: assert(_vkey || _scanCode);
[Otherwise]

  • nothing happens
  • if you try to add another keybinding like this, it detects a conflict with another action that has that "key chord"
Originally created by @carlos-zamora on GitHub (Jun 2, 2022). Originally assigned to: @zadjii-msft on GitHub. ### Windows Terminal version main @ 9dca6c2 ### Windows build number doesn't matter ### Other Software none ### Steps to reproduce 1. Go to Settings > Actions 2. Add a new keybinding with an empty key chord 3. hit save ### Expected Behavior We should require a key chord before adding the action. ### Actual Behavior [Debug mode] hit an assert in `KeyChord`: `assert(_vkey || _scanCode);` [Otherwise] - nothing happens - if you try to add another keybinding like this, it detects a conflict with another action that has that "key chord"
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-SettingsUI In-PR Issue-Bug Needs-Tag-Fix Priority-2 Product-Terminal Severity-Crash
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#17619
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?