starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Make Open JSON file easier to discover #17627

New Issue
Closed
opened 2026-01-31 05:48:11 +00:00 by claunia · 9 comments
claunia commented 2026-01-31 05:48:11 +00:00
Owner
Copy Link

Originally created by @a5hk on GitHub (Jun 4, 2022).

Description of the new feature/enhancement

Once in a while I want to change something in the JSON settings file, and many times I spend several minutes to find that option. It mostly happens when the window is maximized. The button is too far away from the rest of the options.

image

Proposed technical implementation details (optional)

I think it can be added to this menu:

image

Originally created by @a5hk on GitHub (Jun 4, 2022). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> # Description of the new feature/enhancement Once in a while I want to change something in the JSON settings file, and many times I spend several minutes to find that option. It mostly happens when the window is maximized. The button is too far away from the rest of the options. ![image](https://user-images.githubusercontent.com/5412540/171995491-4ba53e72-d9aa-4cbc-b407-ec2c32908517.png) <!-- A clear and concise description of what the problem is that the new feature would solve. Describe why and how a user would use this new functionality (if applicable). --> # Proposed technical implementation details (optional) I think it can be added to this menu: ![image](https://user-images.githubusercontent.com/5412540/171995636-1c4a5959-adf2-4c5c-a6d9-9405af17cf70.png) <!-- A clear and concise description of what you want to happen. -->
claunia commented 2026-01-31 05:48:12 +00:00
Author
Owner
Copy Link

@237dmitry commented on GitHub (Jun 4, 2022):

As a variant you can create environment variable or shell variable. I create in pwsh's profile $WT_SETTINGS var:

Screenshot 2022-06-04 140059

And edit file in your favorite editor, for example:

> notepad $WT_SETTINGS
@237dmitry commented on GitHub (Jun 4, 2022): As a variant you can create environment variable or shell variable. I create in pwsh's profile `$WT_SETTINGS` var: ![Screenshot 2022-06-04 140059](https://user-images.githubusercontent.com/78153320/171996189-bbc97b45-648b-419e-8c5a-335267c2f743.png) And edit file in your favorite editor, for example: ```powershell > notepad $WT_SETTINGS ```
claunia commented 2026-01-31 05:48:12 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jun 4, 2022):

You can also get to the JSON file by holding down Shift and clicking on the "Settings" menu item, my pressing Ctrl+Shift+,, or by opening the command palette with Ctrl+Shift+P and searching for JSON.

Are any of those sufficient?

@DHowett commented on GitHub (Jun 4, 2022): You can also get to the JSON file by holding down <kbd>Shift</kbd> and clicking on the "Settings" menu item, my pressing <kbd>Ctrl+Shift+,</kbd>, or by opening the command palette with <kbd>Ctrl+Shift+P</kbd> and searching for `JSON`. Are any of those sufficient?
claunia commented 2026-01-31 05:48:13 +00:00
Author
Owner
Copy Link

@a5hk commented on GitHub (Jun 4, 2022):

Are any of those sufficient?

I first learned about the settings file through UI. Now that I know a JSON settings file exists, the last option is sufficient for me, I won't forget that one. However, the command is "Open settings file", searching JSON didn't work for me. I have version 1.12.10982.0 installed.

@a5hk commented on GitHub (Jun 4, 2022): > Are any of those sufficient? I first learned about the settings file through UI. Now that I know a JSON settings file exists, the last option is sufficient for me, I won't forget that one. However, the command is "Open settings file", searching `JSON` didn't work for me. I have version `1.12.10982.0` installed.
claunia commented 2026-01-31 05:48:13 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jun 6, 2022):

opening the command palette with Ctrl+Shift+P and searching for JSON.

ed27737233/src/cascadia/TerminalSettingsModel/defaults.json (L293)

image

Looks like that string doesn't actually have "JSON" in it - should it?

(part of #1571 would also cover the ability to add your own actions to the new tab menu, so you could feel free to add a "Open JSON" action that way)

@zadjii-msft commented on GitHub (Jun 6, 2022): > opening the command palette with Ctrl+Shift+P and searching for `JSON`. https://github.com/microsoft/terminal/blob/ed27737233714dea77877624d1beeb49e2ccd36e/src/cascadia/TerminalSettingsModel/defaults.json#L293 ![image](https://user-images.githubusercontent.com/18356694/172175759-278ee681-18a7-4791-95e5-6bea8ce75b73.png) Looks like that string doesn't actually have "JSON" in it - should it? (part of #1571 would also cover the ability to add your own actions to the new tab menu, so you could feel free to add a "Open JSON" action that way)
claunia commented 2026-01-31 05:48:13 +00:00
Author
Owner
Copy Link

@a5hk commented on GitHub (Jun 6, 2022):

Looks like that string doesn't actually have "JSON" in it - should it?

IMO having JSON in that string would make the command more discoverable, at least for VS Code users:

image

@a5hk commented on GitHub (Jun 6, 2022): > Looks like that string doesn't actually have "JSON" in it - should it? IMO having JSON in that string would make the command more discoverable, at least for VS Code users: ![image](https://user-images.githubusercontent.com/5412540/172194668-5da330b0-0ac7-4877-8fa3-2fcb12ec57db.png)
claunia commented 2026-01-31 05:48:13 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jun 6, 2022):

Discussion:

  • Yes we should change the string to "Open settings file (JSON)" with json locked
  • We should also probably add a tooltip to the New Tab dropdown entry as well
@zadjii-msft commented on GitHub (Jun 6, 2022): Discussion: * Yes we should change the string to "Open settings file (JSON)" with json locked * We should also probably add a tooltip to the New Tab dropdown entry as well
claunia commented 2026-01-31 05:48:14 +00:00
Author
Owner
Copy Link

@vadimkantorov commented on GitHub (Jun 7, 2022):

Discussion:

  • Yes we should change the string to "Open settings file (JSON)" with json locked
  • We should also probably add a tooltip to the New Tab dropdown entry as well

Related: https://github.com/microsoft/terminal/issues/10354, sometimes "settings file" is clearer, sometimes "json", but consistency is even more important IMO

@vadimkantorov commented on GitHub (Jun 7, 2022): > Discussion: > > * Yes we should change the string to "Open settings file (JSON)" with json locked > * We should also probably add a tooltip to the New Tab dropdown entry as well Related: https://github.com/microsoft/terminal/issues/10354, sometimes "settings file" is clearer, sometimes "json", but consistency is even more important IMO
claunia commented 2026-01-31 05:48:14 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jul 6, 2022):

:tada:This issue was addressed in #13265, which has now been successfully released as Windows Terminal v1.14.186.🎉

Handy links:

@ghost commented on GitHub (Jul 6, 2022): :tada:This issue was addressed in #13265, which has now been successfully released as `Windows Terminal v1.14.186`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.14.186) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
claunia commented 2026-01-31 05:48:14 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jul 6, 2022):

:tada:This issue was addressed in #13265, which has now been successfully released as Windows Terminal Preview v1.15.186.🎉

Handy links:

@ghost commented on GitHub (Jul 6, 2022): :tada:This issue was addressed in #13265, which has now been successfully released as `Windows Terminal Preview v1.15.186`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.15.186) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface good first issue Help Wanted Issue-Task Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#17627
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?