starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

PSReadLine's -ViModeIndicator "Cursor" doesn't work correctly #17642

New Issue
Closed
opened 2026-01-31 05:48:41 +00:00 by claunia · 6 comments
claunia commented 2026-01-31 05:48:41 +00:00
Owner
Copy Link

Originally created by @nlguerra2003 on GitHub (Jun 6, 2022).

Windows Terminal version

1.12.10983.0

Windows build number

10.0.22621.0

Other Software

PSReadLine

Steps to reproduce

  • Activate PSReadLine's Vi mode: Set-PSReadLineOption -EditMode Vi
  • Activate "Cursor" as mode indicator: Set-PSReadLineOption -ViModeIndicator Cursor
  • Since you start in INSERT mode, just type Esc to change to NORMAL.

Expected Behavior

Cursor should, as it happens in "pure" powershell, be a box in NORMAL mode, and the default one in INSERT (it doesn't matter what cursor you set up in WT).

Actual Behavior

Cursor won't change no matter what mode you select. It will always be the configured cursor.

Originally created by @nlguerra2003 on GitHub (Jun 6, 2022). ### Windows Terminal version 1.12.10983.0 ### Windows build number 10.0.22621.0 ### Other Software PSReadLine ### Steps to reproduce - Activate PSReadLine's Vi mode: `Set-PSReadLineOption -EditMode Vi` - Activate "Cursor" as mode indicator: `Set-PSReadLineOption -ViModeIndicator Cursor` - Since you start in INSERT mode, just type Esc to change to NORMAL. ### Expected Behavior Cursor should, as it happens in "pure" powershell, be a box in NORMAL mode, and the default one in INSERT (it doesn't matter what cursor you set up in WT). ### Actual Behavior Cursor won't change no matter what mode you select. It will always be the configured cursor.
claunia added the Issue-BugResolution-ExternalNeeds-Tag-Fix labels 2026-01-31 05:48:41 +00:00
claunia commented 2026-01-31 05:48:42 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jun 6, 2022):

Which version of PowerShell and PSReadline are you using/?

@zadjii-msft commented on GitHub (Jun 6, 2022): Which version of PowerShell and PSReadline are you using/?
claunia commented 2026-01-31 05:48:42 +00:00
Author
Owner
Copy Link

@nlguerra2003 commented on GitHub (Jun 6, 2022):

PS Version: 7.2.4
PSReadLine Version: 2.2.5
@nlguerra2003 commented on GitHub (Jun 6, 2022): ``` PS Version: 7.2.4 PSReadLine Version: 2.2.5 ```
claunia commented 2026-01-31 05:48:43 +00:00
Author
Owner
Copy Link

@juliekoubova commented on GitHub (Dec 26, 2022):

Happy holidays, folks! Any update on this?

@juliekoubova commented on GitHub (Dec 26, 2022): Happy holidays, folks! Any update on this?
claunia commented 2026-01-31 05:48:43 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Dec 26, 2022):

The problem was that PSReadLine was originally using the .NET Console.CursorSize API to change the cursor size, and that relies on the Win32 SetConsoleCursorInfo API, which isn't supported in Windows Terminal (that's more or less tracked in issue #7382).

The good news is that PSReadLine recently merged a PR (https://github.com/PowerShell/PSReadLine/pull/3374) which updates the ViModeIndicator implementation to use escape sequences to change the cursor shape (switching between a block cursor and underscore cursor), and that should work in Windows Terminal.

Unfortunately it doesn't look like that fix has been released yet, but I'm guessing it will likely be included in the next PSReadLine release.

@j4james commented on GitHub (Dec 26, 2022): The problem was that PSReadLine was originally using the .NET `Console.CursorSize` API to change the cursor size, and that relies on the Win32 `SetConsoleCursorInfo` API, which isn't supported in Windows Terminal (that's more or less tracked in issue #7382). The good news is that PSReadLine recently merged a PR (https://github.com/PowerShell/PSReadLine/pull/3374) which updates the `ViModeIndicator` implementation to use escape sequences to change the cursor shape (switching between a block cursor and underscore cursor), and that should work in Windows Terminal. Unfortunately it doesn't look like that fix has been released yet, but I'm guessing it will likely be included in the next PSReadLine release.
claunia commented 2026-01-31 05:48:43 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jan 3, 2023):

Sorry, must've lost this in the backlog.

Yep, I'd reckon this is fixed by the aforementioned upstream PsReadline issue.

/dup https://github.com/PowerShell/PSReadLine/issues/3334

@zadjii-msft commented on GitHub (Jan 3, 2023): Sorry, must've lost this in the backlog. Yep, I'd reckon this is fixed by the aforementioned upstream PsReadline issue. /dup https://github.com/PowerShell/PSReadLine/issues/3334
claunia commented 2026-01-31 05:48:43 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jan 3, 2023):

Hi! We've identified this issue as a duplicate of one that exists on somebody else's Issue Tracker. Please make sure you subscribe to the referenced external issue for future updates. Thanks for your report!

@ghost commented on GitHub (Jan 3, 2023): Hi! We've identified this issue as a duplicate of one that exists on somebody else's Issue Tracker. Please make sure you subscribe to the referenced external issue for future updates. Thanks for your report!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Issue-Bug Needs-Tag-Fix Resolution-External
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#17642
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?