starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Light tab color causes unreadably dark foreground (text) color when the tab is not focused #17656

New Issue
Closed
opened 2026-01-31 05:49:09 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 05:49:09 +00:00
Owner
Copy Link

Originally created by @MikeTheGreat on GitHub (Jun 8, 2022).

Windows Terminal version

1.12.10982.0

Windows build number

Microsoft Windows [Version 10.0.19043.1706]

Other Software

None

Steps to reproduce

  1. Start MS terminal
  2. Open a total of 2+ tabs
  3. Make sure that you're running a 'Dark' theme
  4. Set the color of a tab to be bright enough that the foreground text switches to black (the 'Teal' option seems to work well - it's custom color is #05FFEE)
  5. Focus a tab (let's call it "Tab A") and bask in the readable text. The tab color is that nice, bright teal and the text has automatically been made black, an easy-to-read, high contrast color.
  6. Switch to a different tab. Notice that Tab A's tab color is now very dark / dim (which is a very reasonable way to convey to the user that the tab isn't currently focused). Notice also that the text color is still black, and thus unreadable.
  7. Look upon incredibly low contrast, unfocused Tab A and weep, for there is no possible way to read that text.

Expected Behavior

I'd love to be able to read the text on my unfocused tabs, even if I choose a light tab color for them.

I think what might solve this is: when a tab becomes unfocused and you dim the tab go back and adjust the foreground (text) color to be white.

Actual Behavior

Foreground color remains black.

I can't read black text on a really, really dark tab.

Oh boy is it hard to see what

Cue the weeping :)

Originally created by @MikeTheGreat on GitHub (Jun 8, 2022). ### Windows Terminal version 1.12.10982.0 ### Windows build number Microsoft Windows [Version 10.0.19043.1706] ### Other Software None ### Steps to reproduce 1. Start MS terminal 2. Open a total of 2+ tabs 3. Make sure that you're running a 'Dark' theme 4. Set the color of a tab to be bright enough that the foreground text switches to black (the 'Teal' option seems to work well - it's custom color is `#05FFEE`) 5. Focus a tab (let's call it "Tab A") and bask in the readable text. The tab color is that nice, bright teal and the text has automatically been made black, an easy-to-read, high contrast color. 6. Switch to a different tab. Notice that Tab A's tab color is now very dark / dim (which is a very reasonable way to convey to the user that the tab isn't currently focused). Notice also that the text color is still black, and thus unreadable. 7. Look upon incredibly low contrast, unfocused Tab A and weep, for there is no possible way to read that text. ### Expected Behavior I'd love to be able to read the text on my unfocused tabs, even if I choose a light tab color for them. I *think* what might solve this is: when a tab becomes unfocused and you dim the tab go back and adjust the foreground (text) color to be white. ### Actual Behavior Foreground color remains black. I can't read black text on a really, really dark tab. Oh boy is it hard to see what Cue the weeping :)
claunia commented 2026-01-31 05:49:12 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jun 8, 2022):

image

Shouldn't be too hard to set the unfocused text color based on the contrast with the unfocused color. Tricks will be:

  • Do we actually control the unfocused color in this scenario? Or are we just letting WinUI apply some default amount of transparency on top of the tab view item
  • Does the TabViewItem actually have a resource for it's unfocused text color, separate from the focused tab text color?
@zadjii-msft commented on GitHub (Jun 8, 2022): ![image](https://user-images.githubusercontent.com/18356694/172600385-0eca6d48-26ac-410c-b7dc-1a5784646ee7.png) Shouldn't be too hard to set the unfocused text color based on the contrast with the unfocused color. Tricks will be: * Do we actually control the unfocused color in this scenario? Or are we just letting WinUI apply some default amount of transparency on top of the tab view item * Does the TabViewItem actually have a resource for it's unfocused text color, separate from the focused tab text color?
claunia commented 2026-01-31 05:49:13 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Sep 13, 2022):

:tada:This issue was addressed in #13689, which has now been successfully released as Windows Terminal Preview v1.16.252.🎉

Handy links:

@ghost commented on GitHub (Sep 13, 2022): :tada:This issue was addressed in #13689, which has now been successfully released as `Windows Terminal Preview v1.16.252`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.16.252) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Theming Area-UserInterface Help Wanted Issue-Bug Needs-Tag-Fix Priority-3 Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#17656
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?