starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-24 07:54:35 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

We might need another dependency for MIDI support #17659

New Issue
Closed
opened 2026-01-31 05:49:15 +00:00 by claunia · 10 comments
claunia commented 2026-01-31 05:49:15 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Jun 8, 2022).

~Promoted from a Teams thread. Tracking here so we don't lose it. ~

Notes from @DHowett:

@j4james handled this for us, by adding a package dependency on GmDls. We need to make sure that when Terminal is installed, users get access to it. I am somewhat concerned about what this means for Inbox Terminal, though: It costs us 3MB on disk which will be aggressively counted against us by Windows Perf Gates
I looked at the code that loads gm.dls and it seems like it was never updated to consider Centennial apps. If a process has "strong identity" (a package), it forces a catalog enumeration to find the GmDls package. We might be able to defray the cost of pulling in a second copy of gm.dls to the Windows image by giving it the ability to "fail over" to the system32 one.

Originally created by @zadjii-msft on GitHub (Jun 8, 2022). ~Promoted from a Teams thread. Tracking here so we don't lose it. ~ Notes from @DHowett: > @j4james handled this for us, by adding a package dependency on `GmDls`. We need to make sure that when Terminal is installed, users get access to it. I am somewhat concerned about what this means for Inbox Terminal, though: It costs us 3MB on disk which will be aggressively counted against us by Windows Perf Gates > I looked at the code that loads gm.dls and it seems like it was never updated to consider Centennial apps. If a process has "strong identity" (a package), it forces a catalog enumeration to find the GmDls package. We might be able to defray the cost of pulling in a second copy of gm.dls to the Windows image by giving it the ability to "fail over" to the system32 one.
claunia commented 2026-01-31 05:49:16 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Jun 9, 2022):

Btw, if you want to revert PR #13208 until we can figure out a solution for this, that's fine by me. It's not exactly an essential feature.

And if in turns out that we can't use the MIDI API, I could try and come up with another way to produce the sound. I just chose MIDI because it seemed easiest.

@j4james commented on GitHub (Jun 9, 2022): Btw, if you want to revert PR #13208 until we can figure out a solution for this, that's fine by me. It's not exactly an essential feature. And if in turns out that we can't use the MIDI API, I could try and come up with another way to produce the sound. I just chose MIDI because it seemed easiest.
claunia commented 2026-01-31 05:49:16 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jun 9, 2022):

Plan of record right now is to stash this behind velocity, so it only ships in Preview (and critically, not in the OS-side build). That way we can get a little longer window on figuring out how we want to resolve this.

@zadjii-msft commented on GitHub (Jun 9, 2022): Plan of record right now is to stash this behind velocity, so it only ships in Preview (and critically, not in the OS-side build). That way we can get a little longer window on figuring out how we want to resolve this.
claunia commented 2026-01-31 05:49:16 +00:00
Author
Owner
Copy Link

@phil-blain commented on GitHub (Jun 9, 2022):

Hi, I just tried to compile Terminal from 4e20a8631c and installing it from a loose package as detailed in https://github.com/microsoft/terminal/blob/main/doc/building.md.

I can confirm that installing the loose package fails for me with (pardon my French!)

Add-AppxPackage : Deployment failed with HRESULT: 0x80073CF3, Échec des mises à jour, de la dépendance ou de la validation des conflits du package.
Windows ne peut pas installer le package WindowsTerminalDev_0.0.1.0_x64__8wekyb3d8bbwe, car ce package dépend d’une infrastructure qui n’a pas pu être trouvée. Indiquez
l’infrastructure «Microsoft.Midi.GmDls» publiée par «CN=Microsoft Corporation, O=Microsoft Corporation, L=Redmond, S=Washington, C=US», avec une architecture neutre ou de
processeur x64 et la version minimale 1.0.0.0, en plus de ce package à installer. Les infrastructures avec le nom «Microsoft.Midi.GmDls» installées actuellement sont
Windows ne peut pas installer le package WindowsTerminalDev_0.0.1.0_x64__8wekyb3d8bbwe, car ce package dépend d’une infrastructure qui n’a pas pu être trouvée. Indiquez
l’infrastructure «Microsoft.Midi.GmDls» publiée par «CN=Microsoft Corporation, O=Microsoft Corporation, L=Redmond, S=Washington, C=US», avec une architecture neutre ou de
processeur x64 et la version minimale 1.0.0.0, en plus de ce package à installer. Les infrastructures avec le nom «Microsoft.Midi.GmDls» installées actuellement sont: {}
NOTE: For additional information, look for [ActivityId] 92e6da5a-7c16-0002-9b44-ea92167cd801 in the Event Log or use the command line Get-AppPackageLog -ActivityID
92e6da5a-7c16-0002-9b44-ea92167cd801
At line:1 char:1
+ Add-AppxPackage -Path ..\loose\AppxManifest.xml -Register -ForceUpdat ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : WriteError: (C:\Users\me...ppxManifest.xml:String) [Add-AppxPackage], IOException
    + FullyQualifiedErrorId : DeploymentError,Microsoft.Windows.Appx.PackageManager.Commands.AddAppxPackageCommand

I'm currently building from 9dca6c27eeeb4371c87cdc553d01b8876d028d21^ (i.e. 7dbe741e1) just to confirm that 9dca6c27ee is indeed is the culprit, but since I found this issue in the meantime I'm pretty sure now :P

@phil-blain commented on GitHub (Jun 9, 2022): Hi, I just tried to compile Terminal from 4e20a8631cbb5b20defe549a0e75bc7719969bee and installing it from a loose package as detailed in https://github.com/microsoft/terminal/blob/main/doc/building.md. I can confirm that installing the loose package fails for me with (pardon my French!) ~~~ Add-AppxPackage : Deployment failed with HRESULT: 0x80073CF3, Échec des mises à jour, de la dépendance ou de la validation des conflits du package. Windows ne peut pas installer le package WindowsTerminalDev_0.0.1.0_x64__8wekyb3d8bbwe, car ce package dépend d’une infrastructure qui n’a pas pu être trouvée. Indiquez l’infrastructure «Microsoft.Midi.GmDls» publiée par «CN=Microsoft Corporation, O=Microsoft Corporation, L=Redmond, S=Washington, C=US», avec une architecture neutre ou de processeur x64 et la version minimale 1.0.0.0, en plus de ce package à installer. Les infrastructures avec le nom «Microsoft.Midi.GmDls» installées actuellement sont Windows ne peut pas installer le package WindowsTerminalDev_0.0.1.0_x64__8wekyb3d8bbwe, car ce package dépend d’une infrastructure qui n’a pas pu être trouvée. Indiquez l’infrastructure «Microsoft.Midi.GmDls» publiée par «CN=Microsoft Corporation, O=Microsoft Corporation, L=Redmond, S=Washington, C=US», avec une architecture neutre ou de processeur x64 et la version minimale 1.0.0.0, en plus de ce package à installer. Les infrastructures avec le nom «Microsoft.Midi.GmDls» installées actuellement sont: {} NOTE: For additional information, look for [ActivityId] 92e6da5a-7c16-0002-9b44-ea92167cd801 in the Event Log or use the command line Get-AppPackageLog -ActivityID 92e6da5a-7c16-0002-9b44-ea92167cd801 At line:1 char:1 + Add-AppxPackage -Path ..\loose\AppxManifest.xml -Register -ForceUpdat ... + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + CategoryInfo : WriteError: (C:\Users\me...ppxManifest.xml:String) [Add-AppxPackage], IOException + FullyQualifiedErrorId : DeploymentError,Microsoft.Windows.Appx.PackageManager.Commands.AddAppxPackageCommand ~~~ I'm currently building from `9dca6c27eeeb4371c87cdc553d01b8876d028d21^` (i.e. 7dbe741e1) just to confirm that 9dca6c27eeeb4371c87cdc553d01b8876d028d21 is indeed is the culprit, but since I found this issue in the meantime I'm pretty sure now :P
claunia commented 2026-01-31 05:49:17 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jun 9, 2022):

Curious. That package should be available on your system, @phil-blain, somewhere in C:\Program Files (x86). It comes with the Windows SDK or one of the extension SDKs that ships with Visual Studio...

@DHowett commented on GitHub (Jun 9, 2022): Curious. That package should be available on your system, @phil-blain, somewhere in `C:\Program Files (x86)`. It comes with the Windows SDK or one of the extension SDKs that ships with Visual Studio...
claunia commented 2026-01-31 05:49:17 +00:00
Author
Owner
Copy Link

@phil-blain commented on GitHub (Jun 9, 2022):

It is indeed in C:\Program Files (x86)\Microsoft SDKs\Windows Kits\10\ExtensionSDKs\Microsoft.Midi.GmDls\10.0.22000.0. Maybe the installation does not work because it is not listed as a PackageDependency in the genereated AppxManifest.xml ?

@phil-blain commented on GitHub (Jun 9, 2022): It is indeed in `C:\Program Files (x86)\Microsoft SDKs\Windows Kits\10\ExtensionSDKs\Microsoft.Midi.GmDls\10.0.22000.0`. Maybe the installation does not work because it is not listed as a `PackageDependency` in the genereated `AppxManifest.xml` ?
claunia commented 2026-01-31 05:49:17 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jun 10, 2022):

With #13258 merged, I'm moving this out to 1.16

@zadjii-msft commented on GitHub (Jun 10, 2022): With #13258 merged, I'm moving this out to 1.16
claunia commented 2026-01-31 05:49:17 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Jul 7, 2022):

@DHowett FYI, I've been playing around with an alternate implementation that uses DirectSound to generate the audio in place of Midi. Would it be worthwhile submitting a PR with that change, or do you have other plans for resolving this?

@j4james commented on GitHub (Jul 7, 2022): @DHowett FYI, I've been playing around with an alternate implementation that uses DirectSound to generate the audio in place of Midi. Would it be worthwhile submitting a PR with that change, or do you have other plans for resolving this?
claunia commented 2026-01-31 05:49:18 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jul 8, 2022):

Huh, that seems like it might be a good way out of this! We wouldn't need to ship another package dependency...

I don't have any concrete plans that will resolve the GmDls package in the near future. My plans are more like, "Fix this in Windows 18 by getting the owner to let me move around some of their code," which would never be serviceable to earlier versions of Windows. :(

@DHowett commented on GitHub (Jul 8, 2022): _Huh,_ that seems like it might be a good way out of this! We wouldn't need to ship another package dependency... I don't have any concrete plans that will resolve the `GmDls` package in the near future. My plans are more like, "Fix this in Windows 18 by getting the owner to let me move around some of their code," which would never be serviceable to earlier versions of Windows. :(
claunia commented 2026-01-31 05:49:18 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Jul 8, 2022):

which would never be serviceable to earlier versions of Windows. :(

OK, that's a deciding factor for me. I'll try and put together a PR this weekend.

@j4james commented on GitHub (Jul 8, 2022): > which would never be serviceable to earlier versions of Windows. :( OK, that's a deciding factor for me. I'll try and put together a PR this weekend.
claunia commented 2026-01-31 05:49:18 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Aug 5, 2022):

:tada:This issue was addressed in #13471, which has now been successfully released as Windows Terminal Preview v1.15.200.🎉

Handy links:

@ghost commented on GitHub (Aug 5, 2022): :tada:This issue was addressed in #13471, which has now been successfully released as `Windows Terminal Preview v1.15.200`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.15.200) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-VT Issue-Bug Priority-0 Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#17659
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?