starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-24 07:54:35 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

About dialog should have a copy button #1769

New Issue
Closed
opened 2026-01-30 22:36:00 +00:00 by claunia · 5 comments
claunia commented 2026-01-30 22:36:00 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Jun 19, 2019).

Or just straight up be copyable. There's gotta be a way to do that with UWP.

Originally created by @zadjii-msft on GitHub (Jun 19, 2019). Or just straight up be copyable. There's gotta be a way to do that with UWP.
claunia commented 2026-01-30 22:36:01 +00:00
Author
Owner
Copy Link

@pingzing commented on GitHub (Jun 20, 2019):

Provided you're using TextBlocks, you should just be able to decorate them with the IsTextSelectionEnabled property.

You'll probably need to make fire_and_forget App::_ShowDialog in App.cpp set the title and content of the dialog to be TextBlock controls, rather than just raw strings (which I'm pretty sure ContentDialog wraps up in TextBlocks anyway).

@pingzing commented on GitHub (Jun 20, 2019): Provided you're using TextBlocks, you should just be able to decorate them with the [IsTextSelectionEnabled property](https://docs.microsoft.com/en-us/uwp/api/windows.ui.xaml.controls.textblock.istextselectionenabled#Windows_UI_Xaml_Controls_TextBlock_IsTextSelectionEnabled). You'll probably need to make `fire_and_forget App::_ShowDialog` in `App.cpp` set the title and content of the dialog to be `TextBlock` controls, rather than just raw strings (which I'm pretty sure ContentDialog wraps up in TextBlocks anyway).
claunia commented 2026-01-30 22:36:02 +00:00
Author
Owner
Copy Link

@rbeesley commented on GitHub (Jun 20, 2019):

For older Win32 dialogs, you've been able to copy the dialog with Ctrl-C. You'd see an output in the clipboard something like:

image*

=

---------------------------
Microsoft OneNote
---------------------------
Your work notebooks can't be synced because of a mismatched IT policy. Connect to your corporate network to try again, or contact your IT administrator.
---------------------------
OK   
---------------------------

A common dialog, or something like an About dialog, should have similar capability. If that capability doesn't exist in UWP today, it should be logged as a bug for the framework to support it.

* As it were, this is a dialog I had to create in a .vbs script to log a bug against OneNote, because Office apps don't usually work as they should. However, that being said, I'd like to see Terminal drive getting this capability built into UWP if it doesn't exist today. Any simple dialog, should maintain this very basic functionality.

@rbeesley commented on GitHub (Jun 20, 2019): For older Win32 dialogs, you've been able to copy the dialog with Ctrl-C. You'd see an output in the clipboard something like: ![image](https://user-images.githubusercontent.com/3703112/59872112-dfeb1080-934d-11e9-9edf-6f734c120407.png)* = ``` --------------------------- Microsoft OneNote --------------------------- Your work notebooks can't be synced because of a mismatched IT policy. Connect to your corporate network to try again, or contact your IT administrator. --------------------------- OK --------------------------- ``` A common dialog, or something like an About dialog, should have similar capability. If that capability doesn't exist in UWP today, it should be logged as a bug for the framework to support it. \* As it were, this is a dialog I had to create in a .vbs script to log a bug against OneNote, because Office apps don't usually work as they should. However, that being said, I'd like to see Terminal drive getting this capability built into UWP if it doesn't exist today. Any simple dialog, should maintain this very basic functionality.
claunia commented 2026-01-30 22:36:02 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jun 20, 2019):

I don't know much about UWP XAML, but presumably the reason UWP XAML ContentDialogs don't support this by default is that you can put whatever content you want in them. How does copy work for some of these more complicated ContentDialogs?

@zadjii-msft commented on GitHub (Jun 20, 2019): I don't know much about UWP XAML, but presumably the reason UWP XAML ContentDialogs don't support this by default is that you can put _whatever content you want in them_. How does copy work for [some of these more complicated ContentDialogs](https://docs.microsoft.com/en-us/uwp/api/windows.ui.xaml.controls.contentdialog#examples)?
claunia commented 2026-01-30 22:36:02 +00:00
Author
Owner
Copy Link

@mdtauk commented on GitHub (Jun 20, 2019):

@zadjii-msft Is right, making it a default behaviour does not make sense for when ContentDialogs contain more than text. But the ability to select the text content, and copy it for future reference is useful, and possible by allowing the selection of the TextBlock content.

@mdtauk commented on GitHub (Jun 20, 2019): @zadjii-msft Is right, making it a default behaviour does not make sense for when ContentDialogs contain more than text. But the ability to select the text content, and copy it for future reference is useful, and possible by allowing the selection of the TextBlock content.
claunia commented 2026-01-30 22:36:03 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Jul 3, 2019):

This was just submitted to the store with the v0.2.1831.0 servicing release. It may take some time for the store to process it. We figured, "it's a small change, why not do it?" Thanks to @Summon528 for the fix.

@DHowett-MSFT commented on GitHub (Jul 3, 2019): This was just submitted to the store with the v0.2.1831.0 servicing release. It may take some time for the store to process it. We figured, "it's a small change, why not do it?" Thanks to @Summon528 for the fix.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Help Wanted Issue-Bug Product-Terminal Resolution-Fix-Available
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#1769
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?