starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Collapsible Regions #17709

New Issue
Open
opened 2026-01-31 05:51:05 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 05:51:05 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Jun 14, 2022).

Writing notes on GH for posterity

Reference

Nested trees is super hard / probably a bad idea.

The cool idea is syncing this up with marks #11000, and how those two work together. We could collapse individual commands.

Implementation

Rendering a collapsed region might need a dev spec

  • I'm not sure the right way for us to just... remove the line from the buffer. It has to be there, but we need to skip it essentially. How do we do that performantly? Track in the first line of the region "I'm a collapsed region of N lines", and have the renderer then skip ahead N to read the next line? that might work...
  • But what about when the very first row of the mutable viewport is part of a region that's collapsed? we'd need to work back up to the row that the region started on. Unless we track the row that this collapsed row belongs to...
  • Of course, how does this work with reflow?
  • Circling the buffer?
  • Collapsed text in the mutable viewport is still writable. That's maybe weird - ^[H could take the cursor inside a collapsed region

Furthermore, how do we communicate these regions up to the control layer, for it to overlay UI?

UI Design

We might definitely need to have a gutter on the left to provide a UI for this. I've already been thinking about using the gutter for marks. Should the padding be used for the gutter? Or should the gutter be in addition to padding? Cause 1dip of padding on the left is not gonna be enough for these UI elements

We should probably do the UI elements in XAML, in TermControl.

Originally created by @zadjii-msft on GitHub (Jun 14, 2022). Writing notes on GH for posterity ### Reference * Collapsable regions [terminal-wg/specifications#3](https://gitlab.freedesktop.org/terminal-wg/specifications/-/issues/3) * https://github.com/xtermjs/xterm.js/issues/1875 * Semantic markers for prompts [terminal-wg/specifications#4](https://gitlab.freedesktop.org/terminal-wg/specifications/-/issues/4) Nested trees is super hard / probably a bad idea. The cool idea is syncing this up with marks #11000, and how those two work together. We could collapse individual commands. ### Implementation Rendering a collapsed region might need a dev spec - I'm not sure the right way for us to just... remove the line from the buffer. It has to be there, but we need to skip it essentially. How do we do that performantly? Track in the first line of the region "I'm a collapsed region of N lines", and have the renderer then skip ahead N to read the next line? _that might work..._ - But what about when the very first row of the mutable viewport is part of a region that's collapsed? we'd need to work back up to the row that the region started on. Unless we track the row that this collapsed row belongs to... - Of course, how does this work with reflow? - Circling the buffer? - Collapsed text in the mutable viewport is still writable. That's maybe weird - `^[H` could take the cursor inside a collapsed region Furthermore, how do we communicate these regions up to the control layer, for it to overlay UI? ### UI Design We might definitely need to have a gutter on the left to provide a UI for this. I've already been thinking about using the gutter for marks. Should the `padding` be used for the gutter? Or should the gutter be _in addition to_ `padding`? Cause 1dip of padding on the left is not gonna be enough for these UI elements We should probably do the UI elements in XAML, in TermControl.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-TerminalControl Area-UserInterface Issue-Feature Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#17709
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?