starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

SerializationTests::Actions started failing recently #17739

New Issue
Closed
opened 2026-01-31 05:51:55 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 05:51:55 +00:00
Owner
Copy Link

Originally created by @j4james on GitHub (Jun 18, 2022).

Originally assigned to: @zadjii-msft on GitHub.

Windows Terminal version

Commit 848314ef17

Windows build number

10.0.19044.1706

Other Software

No response

Steps to reproduce

  1. Build a recent commit of OpenConsole (I think anything after 799b5d4add should do).
  2. Run the unit tests.

Expected Behavior

All the tests should pass.

Actual Behavior

There is a failure in SettingsModelLocalTests::SerializationTests::Actions when attempting to serialize the pair of findMatch actions. It seems that the commands are being reordered.

Click to see error 
Error: Verify: AreEqual(toString(json), toString(result)) - Values ([
        {
                "command" :
                {
                        "action" : "findMatch",
                        "direction" : "next"
                },
                "keys" : "ctrl+shift+s"
        },
        {
                "command" :
                {
                        "action" : "findMatch",
                        "direction" : "prev"
                },
                "keys" : "ctrl+shift+r"
        }
], [
        {
                "command" :
                {
                        "action" : "findMatch",
                        "direction" : "prev"
                },
                "keys" : "ctrl+shift+r"
        },
        {
                "command" :
                {
                        "action" : "findMatch",
                        "direction" : "next"
                },
                "keys" : "ctrl+shift+s"
        }
])

I'm not sure if this is actually an indication of a bug - is the order of the commands expected to be retained? But at the very least I'd expect the test to be corrected if this is just an altered hash map order or something of that sort.

If it helps, I think the first time the test stopped working was after commit 799b5d4add.

Originally created by @j4james on GitHub (Jun 18, 2022). Originally assigned to: @zadjii-msft on GitHub. ### Windows Terminal version Commit 848314ef17419430153561016d1fabe912338844 ### Windows build number 10.0.19044.1706 ### Other Software _No response_ ### Steps to reproduce 1. Build a recent commit of OpenConsole (I think anything after 799b5d4add799ac2fbf5c855b774cd7dcb957697 should do). 2. Run the unit tests. ### Expected Behavior All the tests should pass. ### Actual Behavior There is a failure in `SettingsModelLocalTests::SerializationTests::Actions` when attempting to serialize the pair of `findMatch` actions. It seems that the commands are being reordered. <details> <summary>Click to see error</summary> ``` Error: Verify: AreEqual(toString(json), toString(result)) - Values ([ { "command" : { "action" : "findMatch", "direction" : "next" }, "keys" : "ctrl+shift+s" }, { "command" : { "action" : "findMatch", "direction" : "prev" }, "keys" : "ctrl+shift+r" } ], [ { "command" : { "action" : "findMatch", "direction" : "prev" }, "keys" : "ctrl+shift+r" }, { "command" : { "action" : "findMatch", "direction" : "next" }, "keys" : "ctrl+shift+s" } ]) ``` </details> I'm not sure if this is actually an indication of a bug - is the order of the commands expected to be retained? But at the very least I'd expect the test to be corrected if this is just an altered hash map order or something of that sort. If it helps, I think the first time the test stopped working was after commit 799b5d4add799ac2fbf5c855b774cd7dcb957697.
claunia commented 2026-01-31 05:51:56 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jun 20, 2022):

If it helps, I think the first time the test stopped working was after commit 799b5d4add.

That's w e i r d, Cause, that shouldn't really affect this at all 🙃

I don't think the order really matters at all tbh, string comparing the json was just a shortcut vs having to actually re-parse and structurally analyze for equality. Let's just swap the order around (if it's seemingly stable in the new order)

@zadjii-msft commented on GitHub (Jun 20, 2022): > If it helps, I think the first time the test stopped working was after commit https://github.com/microsoft/terminal/commit/799b5d4add799ac2fbf5c855b774cd7dcb957697. That's w e i r d, Cause, that shouldn't really affect this at all 🙃 I don't think the order really matters at all tbh, string comparing the json was just a shortcut vs having to actually re-parse and structurally analyze for equality. Let's just swap the order around (if it's seemingly stable in the new order)
claunia commented 2026-01-31 05:51:56 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jun 20, 2022):

I've got a fix in, well... 5a40e8061 I think. I think I accidentally did a git add --all there, so it's a bit tangled with other prototypes. I'll submit the PR tomorrow.

@zadjii-msft commented on GitHub (Jun 20, 2022): I've got a fix in, well... 5a40e8061 I think. I think I accidentally did a `git add --all` there, so it's a bit tangled with other prototypes. I'll submit the PR tomorrow.
claunia commented 2026-01-31 05:51:56 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jul 5, 2022):

Note to self: dev/migrie/b/12788-did-it-work. That's the branch where I tried to do the CI changes that really did not work.

@zadjii-msft commented on GitHub (Jul 5, 2022): Note to self: `dev/migrie/b/12788-did-it-work`. That's the branch where I tried to do the CI changes that _really_ did not work.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CodeHealth Issue-Bug Needs-Triage Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#17739
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?