starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Solarized Light scheme is not correct. #17802

New Issue
Closed
opened 2026-01-31 05:53:51 +00:00 by claunia · 1 comment
claunia commented 2026-01-31 05:53:51 +00:00
Owner
Copy Link

Originally created by @kgfly on GitHub (Jun 26, 2022).

Windows Terminal version

1.13.11431.0

Windows build number

10.0.19044.1766

Other Software

No response

Steps to reproduce

In VS22 dev profile, add

            "colorScheme": "Solarized Light",

Expected Behavior

For warning string, the font color does not have any special color.

image

Actual Behavior

waring string should have a different color than normal font color. etc, in above, blue circle should different color than red circle

Originally created by @kgfly on GitHub (Jun 26, 2022). ### Windows Terminal version 1.13.11431.0 ### Windows build number 10.0.19044.1766 ### Other Software _No response_ ### Steps to reproduce In VS22 dev profile, add "colorScheme": "Solarized Light", ### Expected Behavior For warning string, the font color does not have any special color. ![image](https://user-images.githubusercontent.com/12282281/175831412-f498253f-43a8-41ac-a4c6-f08eeeabcfed.png) ### Actual Behavior waring string should have a different color than normal font color. etc, in above, blue circle should different color than red circle
claunia commented 2026-01-31 05:53:52 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jul 5, 2022):

DAYS SINCE I'VE REGRETTED SHIPPING SOLARIZED: 301 0

I'm suspecting that this tool is outputting text in "bright yellow", which in the default Solarized scheme is basically just gray.

image

Alas, by design, solarized doesn't have both a bright and dark yellow - it's only got one yellow. We're following the Solarized spec here, but feel free to modify it by hand to have both yellow and brightYellow be the same value.

@zadjii-msft commented on GitHub (Jul 5, 2022): ### [DAYS SINCE I'VE REGRETTED SHIPPING SOLARIZED: ~~301~~ 0](https://github.com/microsoft/terminal/issues/11171#issuecomment-914624178) I'm suspecting that this tool is outputting text in "bright yellow", which in the default Solarized scheme is basically just gray. ![image](https://user-images.githubusercontent.com/18356694/177303775-fb8f5beb-0746-4e94-b13f-632dbb483816.png) Alas, by design, solarized doesn't have both a bright and dark yellow - [it's only got one yellow](https://ethanschoonover.com/solarized/). We're following the Solarized spec here, but feel free to modify it by hand to have both `yellow` and `brightYellow` be the same value.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Issue-Bug Issue-Question Needs-Tag-Fix Needs-Triage Resolution-Answered
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#17802
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?