starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Add a warning to the proportional font selector #17814

New Issue
Closed
opened 2026-01-31 05:54:21 +00:00 by claunia · 12 comments
claunia commented 2026-01-31 05:54:21 +00:00
Owner
Copy Link

Originally created by @givinghawk on GitHub (Jun 27, 2022).

Windows Terminal version

1.13.11431.0

Windows build number

10.0.19044.1766

Other Software

No response

Steps to reproduce

Open the program

Expected Behavior

Cursor on text at point of editing

Actual Behavior

Cursor is way off of where I am editing

image

Originally created by @givinghawk on GitHub (Jun 27, 2022). ### Windows Terminal version 1.13.11431.0 ### Windows build number 10.0.19044.1766 ### Other Software _No response_ ### Steps to reproduce Open the program ### Expected Behavior Cursor on text at point of editing ### Actual Behavior Cursor is way off of where I am editing ![image](https://user-images.githubusercontent.com/72263189/175997122-50bb190b-2a11-4f5d-9130-92a842f8e207.png)
claunia commented 2026-01-31 05:54:24 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jun 27, 2022):

You appear to be using a proportional font in your terminal. This is not a supported configuration, and is why non-monospace fonts are hidden by default. :)

@DHowett commented on GitHub (Jun 27, 2022): You appear to be using a proportional font in your terminal. This is not a supported configuration, and is why non-monospace fonts are hidden by default. :)
claunia commented 2026-01-31 05:54:24 +00:00
Author
Owner
Copy Link

@givinghawk commented on GitHub (Jun 27, 2022):

ah! i did not realise. thanks!

@givinghawk commented on GitHub (Jun 27, 2022): ah! i did not realise. thanks!
claunia commented 2026-01-31 05:54:24 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jun 27, 2022):

No problem! We should actually add a warning! Thanks for bringing this to our attention.

If it seems weird that we offer a "break my terminal" checkbox that lets you select bad fonts, it is to work around a problem where a good font is mis-identified (by the OS) as an invalid monospace font.

@DHowett commented on GitHub (Jun 27, 2022): No problem! We should actually add a warning! Thanks for bringing this to our attention. If it seems weird that we offer a "break my terminal" checkbox that lets you select bad fonts, it is to work around a problem where a good font is mis-identified (by the OS) as an invalid monospace font.
claunia commented 2026-01-31 05:54:25 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Apr 17, 2023):

@jamespack Hope you don't mind me saying, but this one feels kinda up the same alley of some of the other stuff you've been helping with 😉

@zadjii-msft commented on GitHub (Apr 17, 2023): @jamespack Hope you don't mind me saying, but this one feels kinda up the same alley of some of the other stuff you've been helping with 😉
claunia commented 2026-01-31 05:54:25 +00:00
Author
Owner
Copy Link

@jamespack commented on GitHub (Apr 17, 2023):

Don't mind at all. Happy to PR it

@jamespack commented on GitHub (Apr 17, 2023): Don't mind at all. Happy to PR it
claunia commented 2026-01-31 05:54:25 +00:00
Author
Owner
Copy Link

@jamespack commented on GitHub (Apr 17, 2023):

image

this guy?

@jamespack commented on GitHub (Apr 17, 2023): <img width="289" alt="image" src="https://user-images.githubusercontent.com/2086722/232524952-d86c2369-69cf-46d6-b625-f9dad99dd26a.png"> this guy?
claunia commented 2026-01-31 05:54:25 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Apr 17, 2023):

That's the one. I'm looking through the settings app now to see if there's some precedent for like, a Warning InfoBar (within a Expander) if you choose a weird compatibility setting. Just for some UX precedent.

@zadjii-msft commented on GitHub (Apr 17, 2023): That's the one. I'm looking through the settings app now to see if there's some precedent for like, a Warning InfoBar (within a Expander) if you choose a weird compatibility setting. Just for some UX precedent.
claunia commented 2026-01-31 05:54:25 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Apr 17, 2023):

image

Well, that's not exactly what I was looking for but that feels kinda close. Something big and yellow to say "Warning: non-monospaced will likely result in visual artifacts. Use at your own discretion" whenever the selected font isn't in MonospaceFontList

@zadjii-msft commented on GitHub (Apr 17, 2023): ![image](https://user-images.githubusercontent.com/18356694/232527803-2ff3d8ea-6aef-4fec-a7b7-c38350748f59.png) Well, that's not exactly what I was looking for but that feels kinda close. Something big and yellow to say "Warning: non-monospaced will likely result in visual artifacts. Use at your own discretion" whenever the selected font isn't in `MonospaceFontList`
claunia commented 2026-01-31 05:54:26 +00:00
Author
Owner
Copy Link

@jamespack commented on GitHub (Apr 17, 2023):

image

So not here then. I thought it would wrap 🤣

@jamespack commented on GitHub (Apr 17, 2023): <img width="810" alt="image" src="https://user-images.githubusercontent.com/2086722/232536076-2919d250-09df-4114-89da-ee32d409b982.png"> So not here then. I thought it would wrap 🤣
claunia commented 2026-01-31 05:54:26 +00:00
Author
Owner
Copy Link

@jamespack commented on GitHub (Apr 17, 2023):

Something like this?

image

Top or bottom of the container? Id assume we want the text in the resources?

@jamespack commented on GitHub (Apr 17, 2023): Something like this? <img width="865" alt="image" src="https://user-images.githubusercontent.com/2086722/232539558-9081fa90-8ddd-472a-900a-9b64161da087.png"> Top or bottom of the container? Id assume we want the text in the resources?
claunia commented 2026-01-31 05:54:26 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Apr 17, 2023):

That's literally exactly what I imagined. I'd put it underneath (but I'm no UX designer), and yea strings in the resources. You sure whipped that up quick 😛

@zadjii-msft commented on GitHub (Apr 17, 2023): That's literally exactly what I imagined. I'd put it underneath (but I'm no UX designer), and yea strings in the resources. You sure whipped that up quick 😛
claunia commented 2026-01-31 05:54:27 +00:00
Author
Owner
Copy Link

@jamespack commented on GitHub (Apr 17, 2023):

https://github.com/microsoft/terminal/pull/15195

Think I got everything where it needs to be. If that is not quite what you had in mind or I missed something let me know. :)

@jamespack commented on GitHub (Apr 17, 2023): https://github.com/microsoft/terminal/pull/15195 Think I got everything where it needs to be. If that is not quite what you had in mind or I missed something let me know. :)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-SettingsUI good first issue In-PR Issue-Task Needs-Tag-Fix Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#17814
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?