starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 00:15:10 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Display a specific error for not finding the default profile #1785

New Issue
Closed
opened 2026-01-30 22:36:25 +00:00 by claunia · 3 comments
claunia commented 2026-01-30 22:36:25 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Jun 20, 2019).

Originally assigned to: @zadjii-msft on GitHub.

From #1343

Even more correct would be to specifically display a message that there was no default profile (though that might be too much for this release).

  • If we load the profiles.json and the defaultProfile doesn't exist in the list of profiles, we should display an error specific to that failure case.
  • We should also use the first profile as the default temporarily. We'll need to make sure not to persist this runtime change.

Maybe also:

  • Check if the commandline is a path to a single executable, and if it is, warn if it doesn't exist? Dunno how we'd get the first arg from the commandline easily but it could totally be done.
Originally created by @zadjii-msft on GitHub (Jun 20, 2019). Originally assigned to: @zadjii-msft on GitHub. From #1343 > Even more correct would be to specifically display a message that there was no default profile (though that might be too much for this release). * [ ] If we load the `profiles.json` and the `defaultProfile` doesn't exist in the list of profiles, we should display an error specific to that failure case. * [ ] We should also use the _first_ profile as the default _temporarily_. We'll need to make sure not to persist this runtime change. Maybe also: * [ ] Check if the commandline is a path to a single executable, and if it is, warn if it doesn't exist? Dunno how we'd get the first arg from the commandline _easily_ but it could totally be done.
claunia commented 2026-01-30 22:36:26 +00:00
Author
Owner
Copy Link

@karypid commented on GitHub (Jul 2, 2019):

I would like to add that this should also happen if the default profile is present but fails to load.

So, even if profiles.json is correct and default profile actually exists in it, but the command runs and exits in less than 5 seconds, you should get a dialog saying "command exited almost immediately, please check profiles.json to ensure it is correct".

This is similar to what OS X's Terminal application and the popular Windows "ConEmu" application already do.

I actually came across this issue in a nasty way: when I installed Windows Terminal on a new laptop, Windows Store downloaded the profiles.json file from my previous laptop. When I launched the application the window appeared and immediately disappeared without giving me a chance to read the output. What was happening is that I had edited the command for my default profile and set it to:

            "commandline" : "powershell.exe -noexit -file env.ps1",

Now, normally in my home folder I have a file "env.ps1" where I define some functions, aliases etc. Because the new laptop did NOT have this file yet, powershell would exit immediately with an error.

@karypid commented on GitHub (Jul 2, 2019): I would like to add that this should also happen if the default profile is present but fails to load. So, even if profiles.json is correct and default profile actually exists in it, but the command runs and exits in less than 5 seconds, you should get a dialog saying "command exited almost immediately, please check profiles.json to ensure it is correct". This is similar to what OS X's Terminal application and the popular Windows "ConEmu" application already do. I actually came across this issue in a nasty way: when I installed Windows Terminal on a new laptop, Windows Store downloaded the profiles.json file from my previous laptop. When I launched the application the window appeared and immediately disappeared without giving me a chance to read the output. What was happening is that I had edited the command for my default profile and set it to: ``` "commandline" : "powershell.exe -noexit -file env.ps1", ``` Now, normally in my home folder I have a file "env.ps1" where I define some functions, aliases etc. Because the new laptop did NOT have this file yet, powershell would exit immediately with an error.
claunia commented 2026-01-30 22:36:26 +00:00
Author
Owner
Copy Link

@miniksa commented on GitHub (Aug 1, 2019):

Please at least minimally stop the crash from happening when the default is gone. Choose a different profile and try to recover.

@miniksa commented on GitHub (Aug 1, 2019): Please at least minimally stop the crash from happening when the default is gone. Choose a different profile and try to recover.
claunia commented 2026-01-30 22:36:26 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Aug 27, 2019):

:tada:This issue was addressed in #2422, which has now been successfully released as Windows Terminal Preview v0.4.2382.0.🎉

Handy links:

@ghost commented on GitHub (Aug 27, 2019): :tada:This issue was addressed in #2422, which has now been successfully released as `Windows Terminal Preview v0.4.2382.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v0.4.2382.0) * [Store Download](https://www.microsoft.com/store/apps/9n0dx20hk701?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Issue-Task Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#1785
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?