Command palette goes to the top when you go back (<) from a submenu #17890

Closed
opened 2026-01-31 05:57:35 +00:00 by claunia · 6 comments
Owner

Originally created by @vefatica on GitHub (Jul 7, 2022).

As the subject says, if I open a submenu of the command palette (e.g., "New tab") and go back via the <-button, I'm back at the top of the command palette. I'd prefer to be back where I was. It's not a bug, but the bahavior could be made more friendly.

Originally created by @vefatica on GitHub (Jul 7, 2022). As the subject says, if I open a submenu of the command palette (e.g., "New tab") and go back via the <-button, I'm back at the top of the command palette. I'd prefer to be back where I was. It's not a bug, but the bahavior could be made more friendly.
Author
Owner

@zadjii-msft commented on GitHub (Jul 7, 2022):

Hmm this is in #5400, I'm pretty sure it's a full issue somewhere too

The "go back" button should pop only one layer of the stack, not go all the way back to the root (https://github.com/microsoft/terminal/pull/8051#issuecomment-722045813)

@zadjii-msft commented on GitHub (Jul 7, 2022): Hmm this is in #5400, I'm pretty sure it's a full issue somewhere too > The "go back" button should pop only one layer of the stack, not go all the way back to the root (https://github.com/microsoft/terminal/pull/8051#issuecomment-722045813)
Author
Owner

@vefatica commented on GitHub (Jul 7, 2022):

I guess that's a matter of terminology. The actual behavior and my desired behavior both go back to the command palette. It's the position in the command palette after going back that concerns me ... back to the beginning of the command palette or back to where I was.

@vefatica commented on GitHub (Jul 7, 2022): I guess that's a matter of terminology. The actual behavior and my desired behavior both go back to the command palette. It's the position in the command palette after going back that concerns me ... back to the beginning of the command palette or back to where I was.
Author
Owner

@JerBast commented on GitHub (Jul 13, 2022):

@zadjii-msft, I would be happy to work on this as my first contribution to this repo (if possible). I assume the desired result is to focus the filtered view to the previously selected item when returning from a nested collection?

image

@JerBast commented on GitHub (Jul 13, 2022): @zadjii-msft, I would be happy to work on this as my first contribution to this repo (if possible). I assume the desired result is to focus the filtered view to the previously selected item when returning from a nested collection? ![image](https://user-images.githubusercontent.com/27634653/178750016-6adf00ba-6cc2-4558-b9ba-4ccfcce37115.png)
Author
Owner

@zadjii-msft commented on GitHub (Jul 13, 2022):

That's what I would do, yea! Lemme know if you have any questions. This line: 574a72b505/src/cascadia/TerminalApp/CommandPalette.cpp (L539) is where I'd start ☺️

@zadjii-msft commented on GitHub (Jul 13, 2022): That's what I would do, yea! Lemme know if you have any questions. This line: https://github.com/microsoft/terminal/blob/574a72b505a682a09ea9d533295d3d576556e6c0/src/cascadia/TerminalApp/CommandPalette.cpp#L539 is where I'd start ☺️
Author
Owner

@ghost commented on GitHub (Sep 13, 2022):

:tada:This issue was addressed in #13504, which has now been successfully released as Windows Terminal Preview v1.16.252.🎉

Handy links:

@ghost commented on GitHub (Sep 13, 2022): :tada:This issue was addressed in #13504, which has now been successfully released as `Windows Terminal Preview v1.16.252`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.16.252) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Author
Owner

@vefatica commented on GitHub (Sep 13, 2022):

I just got this one:

"Microsoft.WindowsTerminalPreview_Win10_1.16.2523.0_8wekyb3d8bbwe.msixbundle"

or maybe it's this one:

WindowsTerminalPreview 1.16.2209.09003

Is that one Windows Terminal Preview v1.16.252?

It has too many version descriptions!

The back button works as desired. I didn't mention it earlier but I'd expect Esc to do the same thing (i.e., go back) but it just closes the command palette.

@vefatica commented on GitHub (Sep 13, 2022): I just got this one: `"Microsoft.WindowsTerminalPreview_Win10_1.16.2523.0_8wekyb3d8bbwe.msixbundle"` or maybe it's this one: `WindowsTerminalPreview 1.16.2209.09003` Is that one Windows Terminal Preview v1.16.252? It has too many version descriptions! The back button works as desired. I didn't mention it earlier but I'd expect Esc to do the same thing (i.e., go back) but it just closes the command palette.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#17890